2020-03-06 14:17:12 +00:00
|
|
|
//! See Rustc Dev Guide chapters on [trait-resolution] and [trait-specialization] for more info on
|
|
|
|
//! how this works.
|
2018-02-25 21:24:14 +00:00
|
|
|
//!
|
2020-03-09 21:33:04 +00:00
|
|
|
//! [trait-resolution]: https://rustc-dev-guide.rust-lang.org/traits/resolution.html
|
|
|
|
//! [trait-specialization]: https://rustc-dev-guide.rust-lang.org/traits/specialization.html
|
2014-09-12 14:54:08 +00:00
|
|
|
|
2022-02-02 17:36:45 +00:00
|
|
|
use crate::infer::outlives::env::OutlivesEnvironment;
|
2023-05-23 16:56:25 +00:00
|
|
|
use crate::infer::InferOk;
|
2022-08-22 18:52:49 +00:00
|
|
|
use crate::traits::outlives_bounds::InferCtxtExt as _;
|
2023-07-25 16:49:17 +00:00
|
|
|
use crate::traits::select::{IntercrateAmbiguityCause, TreatInductiveCycleAs};
|
2022-03-24 21:41:30 +00:00
|
|
|
use crate::traits::util::impl_subject_and_oblig;
|
2020-01-24 20:57:01 +00:00
|
|
|
use crate::traits::SkipLeakCheck;
|
2021-10-23 03:03:33 +00:00
|
|
|
use crate::traits::{
|
2022-12-01 18:59:58 +00:00
|
|
|
self, Obligation, ObligationCause, ObligationCtxt, PredicateObligation, PredicateObligations,
|
|
|
|
SelectionContext,
|
2021-10-23 03:03:33 +00:00
|
|
|
};
|
2022-07-09 17:48:53 +00:00
|
|
|
use rustc_data_structures::fx::FxIndexSet;
|
2022-01-23 20:41:46 +00:00
|
|
|
use rustc_errors::Diagnostic;
|
2022-08-23 12:08:30 +00:00
|
|
|
use rustc_hir::def_id::{DefId, CRATE_DEF_ID, LOCAL_CRATE};
|
2023-05-09 20:18:22 +00:00
|
|
|
use rustc_infer::infer::{DefineOpaqueTypes, InferCtxt, TyCtxtInferExt};
|
2022-08-02 06:02:04 +00:00
|
|
|
use rustc_infer::traits::util;
|
2022-01-30 21:55:22 +00:00
|
|
|
use rustc_middle::traits::specialization_graph::OverlapMode;
|
2023-05-09 20:18:22 +00:00
|
|
|
use rustc_middle::traits::DefiningAnchor;
|
2022-05-24 07:15:19 +00:00
|
|
|
use rustc_middle::ty::fast_reject::{DeepRejectCtxt, TreatParams};
|
2023-02-22 02:18:40 +00:00
|
|
|
use rustc_middle::ty::visit::{TypeVisitable, TypeVisitableExt};
|
2023-06-14 02:18:30 +00:00
|
|
|
use rustc_middle::ty::{self, Ty, TyCtxt, TypeVisitor};
|
2023-07-25 01:49:29 +00:00
|
|
|
use rustc_session::lint::builtin::COINDUCTIVE_OVERLAP_IN_COHERENCE;
|
2020-01-01 18:30:57 +00:00
|
|
|
use rustc_span::symbol::sym;
|
2019-12-31 17:15:40 +00:00
|
|
|
use rustc_span::DUMMY_SP;
|
2022-03-18 17:07:22 +00:00
|
|
|
use std::fmt::Debug;
|
2020-03-20 03:28:17 +00:00
|
|
|
use std::iter;
|
2022-07-21 09:51:09 +00:00
|
|
|
use std::ops::ControlFlow;
|
2014-09-12 14:54:08 +00:00
|
|
|
|
2023-07-04 08:06:39 +00:00
|
|
|
use super::query::evaluate_obligation::InferCtxtExt;
|
2022-12-01 18:59:58 +00:00
|
|
|
use super::NormalizeExt;
|
|
|
|
|
2017-11-22 21:01:51 +00:00
|
|
|
/// Whether we do the orphan check relative to this crate or
|
|
|
|
/// to some remote crate.
|
2017-11-29 18:50:26 +00:00
|
|
|
#[derive(Copy, Clone, Debug)]
|
2017-11-22 21:01:51 +00:00
|
|
|
enum InCrate {
|
|
|
|
Local,
|
|
|
|
Remote,
|
2017-11-22 20:39:40 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Debug, Copy, Clone)]
|
|
|
|
pub enum Conflict {
|
|
|
|
Upstream,
|
2020-02-08 18:14:50 +00:00
|
|
|
Downstream,
|
2017-11-22 20:39:40 +00:00
|
|
|
}
|
2015-03-30 21:46:34 +00:00
|
|
|
|
2017-07-23 13:30:47 +00:00
|
|
|
pub struct OverlapResult<'tcx> {
|
|
|
|
pub impl_header: ty::ImplHeader<'tcx>,
|
2022-07-09 17:48:53 +00:00
|
|
|
pub intercrate_ambiguity_causes: FxIndexSet<IntercrateAmbiguityCause>,
|
2018-11-20 16:20:05 +00:00
|
|
|
|
2019-02-08 13:53:55 +00:00
|
|
|
/// `true` if the overlap might've been permitted before the shift
|
2018-11-20 16:20:05 +00:00
|
|
|
/// to universes.
|
|
|
|
pub involves_placeholder: bool,
|
|
|
|
}
|
|
|
|
|
2022-01-23 20:41:46 +00:00
|
|
|
pub fn add_placeholder_note(err: &mut Diagnostic) {
|
2020-02-27 12:34:08 +00:00
|
|
|
err.note(
|
2018-11-20 16:20:05 +00:00
|
|
|
"this behavior recently changed as a result of a bug fix; \
|
2020-02-27 12:34:08 +00:00
|
|
|
see rust-lang/rust#56105 for details",
|
|
|
|
);
|
2017-07-23 13:30:47 +00:00
|
|
|
}
|
|
|
|
|
2023-05-23 16:56:25 +00:00
|
|
|
#[derive(Debug, Clone, Copy)]
|
|
|
|
enum TrackAmbiguityCauses {
|
|
|
|
Yes,
|
|
|
|
No,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl TrackAmbiguityCauses {
|
|
|
|
fn is_yes(self) -> bool {
|
|
|
|
match self {
|
|
|
|
TrackAmbiguityCauses::Yes => true,
|
|
|
|
TrackAmbiguityCauses::No => false,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-10-11 20:37:11 +00:00
|
|
|
/// If there are types that satisfy both impls, returns `Some`
|
2018-01-29 23:20:24 +00:00
|
|
|
/// with a suitably-freshened `ImplHeader` with those types
|
2022-10-11 20:37:11 +00:00
|
|
|
/// substituted. Otherwise, returns `None`.
|
|
|
|
#[instrument(skip(tcx, skip_leak_check), level = "debug")]
|
2022-12-20 21:10:40 +00:00
|
|
|
pub fn overlapping_impls(
|
|
|
|
tcx: TyCtxt<'_>,
|
2018-01-29 23:20:24 +00:00
|
|
|
impl1_def_id: DefId,
|
|
|
|
impl2_def_id: DefId,
|
2020-01-24 20:57:01 +00:00
|
|
|
skip_leak_check: SkipLeakCheck,
|
2022-01-30 21:55:22 +00:00
|
|
|
overlap_mode: OverlapMode,
|
2022-12-20 21:10:40 +00:00
|
|
|
) -> Option<OverlapResult<'_>> {
|
2021-02-04 09:45:17 +00:00
|
|
|
// Before doing expensive operations like entering an inference context, do
|
|
|
|
// a quick check via fast_reject to tell if the impl headers could possibly
|
|
|
|
// unify.
|
2023-03-12 00:59:54 +00:00
|
|
|
let drcx = DeepRejectCtxt { treat_obligation_params: TreatParams::AsCandidateKey };
|
2023-01-11 18:32:33 +00:00
|
|
|
let impl1_ref = tcx.impl_trait_ref(impl1_def_id);
|
|
|
|
let impl2_ref = tcx.impl_trait_ref(impl2_def_id);
|
2022-05-24 07:15:19 +00:00
|
|
|
let may_overlap = match (impl1_ref, impl2_ref) {
|
2023-07-11 21:35:29 +00:00
|
|
|
(Some(a), Some(b)) => drcx.args_refs_may_unify(a.skip_binder().args, b.skip_binder().args),
|
2022-05-24 07:15:19 +00:00
|
|
|
(None, None) => {
|
2023-02-07 08:29:48 +00:00
|
|
|
let self_ty1 = tcx.type_of(impl1_def_id).skip_binder();
|
|
|
|
let self_ty2 = tcx.type_of(impl2_def_id).skip_binder();
|
2022-05-24 07:15:19 +00:00
|
|
|
drcx.types_may_unify(self_ty1, self_ty2)
|
2021-03-08 23:32:41 +00:00
|
|
|
}
|
2022-05-24 07:15:19 +00:00
|
|
|
_ => bug!("unexpected impls: {impl1_def_id:?} {impl2_def_id:?}"),
|
|
|
|
};
|
|
|
|
|
|
|
|
if !may_overlap {
|
2021-02-04 09:45:17 +00:00
|
|
|
// Some types involved are definitely different, so the impls couldn't possibly overlap.
|
|
|
|
debug!("overlapping_impls: fast_reject early-exit");
|
2022-10-11 20:37:11 +00:00
|
|
|
return None;
|
2021-02-04 09:45:17 +00:00
|
|
|
}
|
2014-10-09 21:19:50 +00:00
|
|
|
|
2023-05-23 16:56:25 +00:00
|
|
|
let _overlap_with_bad_diagnostics = overlap(
|
|
|
|
tcx,
|
|
|
|
TrackAmbiguityCauses::No,
|
|
|
|
skip_leak_check,
|
|
|
|
impl1_def_id,
|
|
|
|
impl2_def_id,
|
|
|
|
overlap_mode,
|
|
|
|
)?;
|
2018-01-26 22:21:43 +00:00
|
|
|
|
|
|
|
// In the case where we detect an error, run the check again, but
|
2022-03-30 19:14:15 +00:00
|
|
|
// this time tracking intercrate ambiguity causes for better
|
2018-01-26 22:21:43 +00:00
|
|
|
// diagnostics. (These take time and can lead to false errors.)
|
2023-05-23 16:56:25 +00:00
|
|
|
let overlap = overlap(
|
|
|
|
tcx,
|
|
|
|
TrackAmbiguityCauses::Yes,
|
|
|
|
skip_leak_check,
|
|
|
|
impl1_def_id,
|
|
|
|
impl2_def_id,
|
|
|
|
overlap_mode,
|
|
|
|
)
|
|
|
|
.unwrap();
|
|
|
|
Some(overlap)
|
2015-02-12 17:42:02 +00:00
|
|
|
}
|
|
|
|
|
2019-06-13 22:32:15 +00:00
|
|
|
fn with_fresh_ty_vars<'cx, 'tcx>(
|
|
|
|
selcx: &mut SelectionContext<'cx, 'tcx>,
|
|
|
|
param_env: ty::ParamEnv<'tcx>,
|
|
|
|
impl_def_id: DefId,
|
|
|
|
) -> ty::ImplHeader<'tcx> {
|
2017-05-23 08:19:47 +00:00
|
|
|
let tcx = selcx.tcx();
|
2023-07-11 21:35:29 +00:00
|
|
|
let impl_args = selcx.infcx.fresh_args_for_item(DUMMY_SP, impl_def_id);
|
2017-05-23 08:19:47 +00:00
|
|
|
|
|
|
|
let header = ty::ImplHeader {
|
2017-07-03 18:19:51 +00:00
|
|
|
impl_def_id,
|
2023-07-11 21:35:29 +00:00
|
|
|
self_ty: tcx.type_of(impl_def_id).instantiate(tcx, impl_args),
|
|
|
|
trait_ref: tcx.impl_trait_ref(impl_def_id).map(|i| i.instantiate(tcx, impl_args)),
|
2023-06-22 18:17:13 +00:00
|
|
|
predicates: tcx
|
|
|
|
.predicates_of(impl_def_id)
|
2023-07-11 21:35:29 +00:00
|
|
|
.instantiate(tcx, impl_args)
|
2023-06-22 18:17:13 +00:00
|
|
|
.iter()
|
2023-07-25 01:17:58 +00:00
|
|
|
.map(|(c, s)| (c.as_predicate(), s))
|
2023-06-22 18:17:13 +00:00
|
|
|
.collect(),
|
2018-09-16 17:15:49 +00:00
|
|
|
};
|
2017-05-23 08:19:47 +00:00
|
|
|
|
2023-07-25 01:17:58 +00:00
|
|
|
let InferOk { value: mut header, obligations } = selcx
|
|
|
|
.infcx
|
|
|
|
.at(&ObligationCause::dummy_with_span(tcx.def_span(impl_def_id)), param_env)
|
|
|
|
.normalize(header);
|
2017-05-23 08:19:47 +00:00
|
|
|
|
2023-07-25 01:17:58 +00:00
|
|
|
header.predicates.extend(obligations.into_iter().map(|o| (o.predicate, o.cause.span)));
|
2017-05-23 08:19:47 +00:00
|
|
|
header
|
|
|
|
}
|
|
|
|
|
2015-12-01 19:26:47 +00:00
|
|
|
/// Can both impl `a` and impl `b` be satisfied by a common type (including
|
2019-02-08 13:53:55 +00:00
|
|
|
/// where-clauses)? If so, returns an `ImplHeader` that unifies the two impls.
|
2023-05-23 16:56:25 +00:00
|
|
|
#[instrument(level = "debug", skip(tcx))]
|
|
|
|
fn overlap<'tcx>(
|
|
|
|
tcx: TyCtxt<'tcx>,
|
|
|
|
track_ambiguity_causes: TrackAmbiguityCauses,
|
2020-01-24 20:57:01 +00:00
|
|
|
skip_leak_check: SkipLeakCheck,
|
2022-01-21 13:50:42 +00:00
|
|
|
impl1_def_id: DefId,
|
|
|
|
impl2_def_id: DefId,
|
2022-01-30 21:55:22 +00:00
|
|
|
overlap_mode: OverlapMode,
|
2018-11-20 16:20:05 +00:00
|
|
|
) -> Option<OverlapResult<'tcx>> {
|
2022-01-22 21:16:11 +00:00
|
|
|
if overlap_mode.use_negative_impl() {
|
2023-06-14 02:18:30 +00:00
|
|
|
if impl_intersection_has_negative_obligation(tcx, impl1_def_id, impl2_def_id)
|
|
|
|
|| impl_intersection_has_negative_obligation(tcx, impl2_def_id, impl1_def_id)
|
2022-01-22 21:16:11 +00:00
|
|
|
{
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-05-23 16:56:25 +00:00
|
|
|
let infcx = tcx
|
|
|
|
.infer_ctxt()
|
|
|
|
.with_opaque_type_inference(DefiningAnchor::Bubble)
|
|
|
|
.skip_leak_check(skip_leak_check.is_yes())
|
|
|
|
.intercrate(true)
|
2023-05-31 01:02:40 +00:00
|
|
|
.with_next_trait_solver(tcx.next_trait_solver_in_coherence())
|
2023-05-23 16:56:25 +00:00
|
|
|
.build();
|
|
|
|
let selcx = &mut SelectionContext::new(&infcx);
|
|
|
|
if track_ambiguity_causes.is_yes() {
|
|
|
|
selcx.enable_tracking_intercrate_ambiguity_causes();
|
|
|
|
}
|
|
|
|
|
2018-09-07 13:46:53 +00:00
|
|
|
// For the purposes of this check, we don't bring any placeholder
|
2017-05-23 08:19:47 +00:00
|
|
|
// types into scope; instead, we replace the generic types with
|
|
|
|
// fresh type variables, and hence we do our evaluations in an
|
|
|
|
// empty environment.
|
2018-02-10 18:18:02 +00:00
|
|
|
let param_env = ty::ParamEnv::empty();
|
2017-05-23 08:19:47 +00:00
|
|
|
|
2022-01-21 13:50:42 +00:00
|
|
|
let impl1_header = with_fresh_ty_vars(selcx, param_env, impl1_def_id);
|
|
|
|
let impl2_header = with_fresh_ty_vars(selcx, param_env, impl2_def_id);
|
2015-03-30 21:46:34 +00:00
|
|
|
|
2023-06-14 02:18:30 +00:00
|
|
|
// Equate the headers to find their intersection (the general type, with infer vars,
|
|
|
|
// that may apply both impls).
|
|
|
|
let equate_obligations = equate_impl_headers(selcx.infcx, &impl1_header, &impl2_header)?;
|
2022-01-22 21:16:11 +00:00
|
|
|
debug!("overlap: unification check succeeded");
|
|
|
|
|
2023-07-25 16:49:17 +00:00
|
|
|
if overlap_mode.use_implicit_negative() {
|
|
|
|
for mode in [TreatInductiveCycleAs::Ambig, TreatInductiveCycleAs::Recur] {
|
|
|
|
if let Some(failing_obligation) = selcx.with_treat_inductive_cycle_as(mode, |selcx| {
|
|
|
|
impl_intersection_has_impossible_obligation(
|
|
|
|
selcx,
|
|
|
|
param_env,
|
|
|
|
&impl1_header,
|
|
|
|
&impl2_header,
|
|
|
|
&equate_obligations,
|
|
|
|
)
|
|
|
|
}) {
|
|
|
|
if matches!(mode, TreatInductiveCycleAs::Recur) {
|
|
|
|
let first_local_impl = impl1_header
|
|
|
|
.impl_def_id
|
|
|
|
.as_local()
|
|
|
|
.or(impl2_header.impl_def_id.as_local())
|
|
|
|
.expect("expected one of the impls to be local");
|
|
|
|
infcx.tcx.struct_span_lint_hir(
|
|
|
|
COINDUCTIVE_OVERLAP_IN_COHERENCE,
|
|
|
|
infcx.tcx.local_def_id_to_hir_id(first_local_impl),
|
|
|
|
infcx.tcx.def_span(first_local_impl),
|
|
|
|
"impls that are not considered to overlap may be considered to \
|
|
|
|
overlap in the future",
|
|
|
|
|lint| {
|
|
|
|
lint.span_label(
|
|
|
|
infcx.tcx.def_span(impl1_header.impl_def_id),
|
|
|
|
"the first impl is here",
|
|
|
|
)
|
|
|
|
.span_label(
|
|
|
|
infcx.tcx.def_span(impl2_header.impl_def_id),
|
|
|
|
"the second impl is here",
|
|
|
|
);
|
|
|
|
if !failing_obligation.cause.span.is_dummy() {
|
|
|
|
lint.span_label(
|
|
|
|
failing_obligation.cause.span,
|
|
|
|
"this where-clause causes a cycle, but it may be treated \
|
|
|
|
as possibly holding in the future, causing the impls to overlap",
|
|
|
|
);
|
|
|
|
}
|
|
|
|
lint
|
|
|
|
},
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
}
|
2022-01-21 14:02:52 +00:00
|
|
|
}
|
|
|
|
|
2023-05-23 16:56:25 +00:00
|
|
|
// We toggle the `leak_check` by using `skip_leak_check` when constructing the
|
|
|
|
// inference context, so this may be a noop.
|
|
|
|
if infcx.leak_check(ty::UniverseIndex::ROOT, None).is_err() {
|
2022-02-21 09:40:41 +00:00
|
|
|
debug!("overlap: leak check failed");
|
|
|
|
return None;
|
2022-01-21 14:02:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
let intercrate_ambiguity_causes = selcx.take_intercrate_ambiguity_causes();
|
|
|
|
debug!("overlap: intercrate_ambiguity_causes={:#?}", intercrate_ambiguity_causes);
|
2023-05-23 16:56:25 +00:00
|
|
|
let involves_placeholder = infcx
|
|
|
|
.inner
|
|
|
|
.borrow_mut()
|
|
|
|
.unwrap_region_constraints()
|
|
|
|
.data()
|
|
|
|
.constraints
|
|
|
|
.iter()
|
|
|
|
.any(|c| c.0.involves_placeholders());
|
2022-01-21 14:02:52 +00:00
|
|
|
|
2022-11-25 23:31:28 +00:00
|
|
|
let impl_header = selcx.infcx.resolve_vars_if_possible(impl1_header);
|
2022-01-21 14:02:52 +00:00
|
|
|
Some(OverlapResult { impl_header, intercrate_ambiguity_causes, involves_placeholder })
|
|
|
|
}
|
|
|
|
|
2023-03-15 13:00:15 +00:00
|
|
|
#[instrument(level = "debug", skip(infcx), ret)]
|
|
|
|
fn equate_impl_headers<'tcx>(
|
|
|
|
infcx: &InferCtxt<'tcx>,
|
|
|
|
impl1: &ty::ImplHeader<'tcx>,
|
|
|
|
impl2: &ty::ImplHeader<'tcx>,
|
2022-01-22 21:16:11 +00:00
|
|
|
) -> Option<PredicateObligations<'tcx>> {
|
2023-03-15 13:00:15 +00:00
|
|
|
let result = match (impl1.trait_ref, impl2.trait_ref) {
|
|
|
|
(Some(impl1_ref), Some(impl2_ref)) => infcx
|
|
|
|
.at(&ObligationCause::dummy(), ty::ParamEnv::empty())
|
|
|
|
.eq(DefineOpaqueTypes::Yes, impl1_ref, impl2_ref),
|
|
|
|
(None, None) => infcx.at(&ObligationCause::dummy(), ty::ParamEnv::empty()).eq(
|
|
|
|
DefineOpaqueTypes::Yes,
|
|
|
|
impl1.self_ty,
|
|
|
|
impl2.self_ty,
|
|
|
|
),
|
|
|
|
_ => bug!("mk_eq_impl_headers given mismatched impl kinds"),
|
|
|
|
};
|
|
|
|
|
|
|
|
result.map(|infer_ok| infer_ok.obligations).ok()
|
2022-01-22 21:16:11 +00:00
|
|
|
}
|
|
|
|
|
2023-06-14 02:18:30 +00:00
|
|
|
/// Check if both impls can be satisfied by a common type by considering whether
|
|
|
|
/// any of either impl's obligations is not known to hold.
|
|
|
|
///
|
|
|
|
/// For example, given these two impls:
|
|
|
|
/// `impl From<MyLocalType> for Box<dyn Error>` (in my crate)
|
|
|
|
/// `impl<E> From<E> for Box<dyn Error> where E: Error` (in libstd)
|
|
|
|
///
|
|
|
|
/// After replacing both impl headers with inference vars (which happens before
|
|
|
|
/// this function is called), we get:
|
|
|
|
/// `Box<dyn Error>: From<MyLocalType>`
|
|
|
|
/// `Box<dyn Error>: From<?E>`
|
|
|
|
///
|
|
|
|
/// This gives us `?E = MyLocalType`. We then certainly know that `MyLocalType: Error`
|
|
|
|
/// never holds in intercrate mode since a local impl does not exist, and a
|
|
|
|
/// downstream impl cannot be added -- therefore can consider the intersection
|
|
|
|
/// of the two impls above to be empty.
|
|
|
|
///
|
|
|
|
/// Importantly, this works even if there isn't a `impl !Error for MyLocalType`.
|
|
|
|
fn impl_intersection_has_impossible_obligation<'cx, 'tcx>(
|
2022-01-21 14:02:52 +00:00
|
|
|
selcx: &mut SelectionContext<'cx, 'tcx>,
|
|
|
|
param_env: ty::ParamEnv<'tcx>,
|
|
|
|
impl1_header: &ty::ImplHeader<'tcx>,
|
2023-07-25 16:49:17 +00:00
|
|
|
impl2_header: &ty::ImplHeader<'tcx>,
|
|
|
|
obligations: &PredicateObligations<'tcx>,
|
|
|
|
) -> Option<PredicateObligation<'tcx>> {
|
2022-11-25 23:31:28 +00:00
|
|
|
let infcx = selcx.infcx;
|
2023-06-14 02:18:30 +00:00
|
|
|
|
2023-07-25 16:49:17 +00:00
|
|
|
[&impl1_header.predicates, &impl2_header.predicates]
|
2023-06-14 02:18:30 +00:00
|
|
|
.into_iter()
|
|
|
|
.flatten()
|
2023-07-25 01:17:58 +00:00
|
|
|
.map(|&(predicate, span)| {
|
|
|
|
Obligation::new(infcx.tcx, ObligationCause::dummy_with_span(span), param_env, predicate)
|
2016-02-26 18:51:10 +00:00
|
|
|
})
|
2023-07-25 16:49:17 +00:00
|
|
|
.chain(obligations.into_iter().cloned())
|
|
|
|
.find(|obligation: &PredicateObligation<'tcx>| {
|
|
|
|
if infcx.next_trait_solver() {
|
|
|
|
infcx.evaluate_obligation(obligation).map_or(false, |result| !result.may_apply())
|
|
|
|
} else {
|
|
|
|
// We use `evaluate_root_obligation` to correctly track intercrate
|
|
|
|
// ambiguity clauses. We cannot use this in the new solver.
|
|
|
|
selcx.evaluate_root_obligation(obligation).map_or(
|
|
|
|
false, // Overflow has occurred, and treat the obligation as possibly holding.
|
|
|
|
|result| !result.may_apply(),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
})
|
2015-02-12 17:42:02 +00:00
|
|
|
}
|
|
|
|
|
2023-06-14 02:18:30 +00:00
|
|
|
/// Check if both impls can be satisfied by a common type by considering whether
|
|
|
|
/// any of first impl's obligations is known not to hold *via a negative predicate*.
|
|
|
|
///
|
|
|
|
/// For example, given these two impls:
|
|
|
|
/// `struct MyCustomBox<T: ?Sized>(Box<T>);`
|
|
|
|
/// `impl From<&str> for MyCustomBox<dyn Error>` (in my crate)
|
|
|
|
/// `impl<E> From<E> for MyCustomBox<dyn Error> where E: Error` (in my crate)
|
|
|
|
///
|
|
|
|
/// After replacing the second impl's header with inference vars, we get:
|
|
|
|
/// `MyCustomBox<dyn Error>: From<&str>`
|
|
|
|
/// `MyCustomBox<dyn Error>: From<?E>`
|
|
|
|
///
|
|
|
|
/// This gives us `?E = &str`. We then try to prove the first impl's predicates
|
|
|
|
/// after negating, giving us `&str: !Error`. This is a negative impl provided by
|
|
|
|
/// libstd, and therefore we can guarantee for certain that libstd will never add
|
|
|
|
/// a positive impl for `&str: Error` (without it being a breaking change).
|
|
|
|
fn impl_intersection_has_negative_obligation(
|
|
|
|
tcx: TyCtxt<'_>,
|
|
|
|
impl1_def_id: DefId,
|
|
|
|
impl2_def_id: DefId,
|
|
|
|
) -> bool {
|
2022-02-04 01:40:29 +00:00
|
|
|
debug!("negative_impl(impl1_def_id={:?}, impl2_def_id={:?})", impl1_def_id, impl2_def_id);
|
2022-01-21 15:53:50 +00:00
|
|
|
|
|
|
|
// Create an infcx, taking the predicates of impl1 as assumptions:
|
|
|
|
let infcx = tcx.infer_ctxt().build();
|
2022-03-18 01:51:45 +00:00
|
|
|
// create a parameter environment corresponding to a (placeholder) instantiation of impl1
|
2022-03-24 15:27:09 +00:00
|
|
|
let impl_env = tcx.param_env(impl1_def_id);
|
2022-03-24 17:17:54 +00:00
|
|
|
let subject1 = match traits::fully_normalize(
|
|
|
|
&infcx,
|
|
|
|
ObligationCause::dummy(),
|
|
|
|
impl_env,
|
2023-07-11 21:35:29 +00:00
|
|
|
tcx.impl_subject(impl1_def_id).instantiate_identity(),
|
2022-03-24 17:17:54 +00:00
|
|
|
) {
|
|
|
|
Ok(s) => s,
|
2022-08-13 22:04:50 +00:00
|
|
|
Err(err) => {
|
|
|
|
tcx.sess.delay_span_bug(
|
|
|
|
tcx.def_span(impl1_def_id),
|
2023-07-25 21:04:01 +00:00
|
|
|
format!("failed to fully normalize {impl1_def_id:?}: {err:?}"),
|
2022-08-13 22:04:50 +00:00
|
|
|
);
|
|
|
|
return false;
|
|
|
|
}
|
2022-03-24 15:27:09 +00:00
|
|
|
};
|
2022-09-20 03:03:59 +00:00
|
|
|
|
2022-03-24 15:27:09 +00:00
|
|
|
// Attempt to prove that impl2 applies, given all of the above.
|
|
|
|
let selcx = &mut SelectionContext::new(&infcx);
|
2023-07-11 21:35:29 +00:00
|
|
|
let impl2_args = infcx.fresh_args_for_item(DUMMY_SP, impl2_def_id);
|
2023-06-14 02:18:30 +00:00
|
|
|
let (subject2, normalization_obligations) =
|
2023-07-11 21:35:29 +00:00
|
|
|
impl_subject_and_oblig(selcx, impl_env, impl2_def_id, impl2_args, |_, _| {
|
2023-05-05 14:52:53 +00:00
|
|
|
ObligationCause::dummy()
|
|
|
|
});
|
2022-09-20 03:03:59 +00:00
|
|
|
|
2023-06-14 02:18:30 +00:00
|
|
|
// do the impls unify? If not, then it's not currently possible to prove any
|
|
|
|
// obligations about their intersection.
|
|
|
|
let Ok(InferOk { obligations: equate_obligations, .. }) =
|
2023-03-15 13:00:15 +00:00
|
|
|
infcx.at(&ObligationCause::dummy(), impl_env).eq(DefineOpaqueTypes::No, subject1, subject2)
|
2022-03-24 15:27:09 +00:00
|
|
|
else {
|
|
|
|
debug!("explicit_disjoint: {:?} does not unify with {:?}", subject1, subject2);
|
2023-06-14 02:18:30 +00:00
|
|
|
return false;
|
2022-03-24 15:27:09 +00:00
|
|
|
};
|
2022-03-18 17:07:22 +00:00
|
|
|
|
2023-06-14 02:18:30 +00:00
|
|
|
for obligation in normalization_obligations.into_iter().chain(equate_obligations) {
|
|
|
|
if negative_impl_exists(&infcx, &obligation, impl1_def_id) {
|
|
|
|
debug!("overlap: obligation unsatisfiable {:?}", obligation);
|
|
|
|
return true;
|
|
|
|
}
|
2022-03-18 17:07:22 +00:00
|
|
|
}
|
2023-06-14 02:18:30 +00:00
|
|
|
|
|
|
|
false
|
2022-03-18 17:07:22 +00:00
|
|
|
}
|
|
|
|
|
2023-06-14 02:18:30 +00:00
|
|
|
/// Try to prove that a negative impl exist for the obligation or its supertraits.
|
|
|
|
///
|
|
|
|
/// If such a negative impl exists, then the obligation definitely must not hold
|
|
|
|
/// due to coherence, even if it's not necessarily "knowable" in this crate. Any
|
|
|
|
/// valid impl downstream would not be able to exist due to the overlapping
|
|
|
|
/// negative impl.
|
2022-11-21 14:26:23 +00:00
|
|
|
#[instrument(level = "debug", skip(infcx))]
|
|
|
|
fn negative_impl_exists<'tcx>(
|
|
|
|
infcx: &InferCtxt<'tcx>,
|
2022-01-21 13:53:17 +00:00
|
|
|
o: &PredicateObligation<'tcx>,
|
2022-08-22 18:52:49 +00:00
|
|
|
body_def_id: DefId,
|
2022-01-21 13:53:17 +00:00
|
|
|
) -> bool {
|
2022-03-18 17:13:06 +00:00
|
|
|
// Try to prove a negative obligation exists for super predicates
|
2023-04-06 23:11:19 +00:00
|
|
|
for pred in util::elaborate(infcx.tcx, iter::once(o.predicate)) {
|
2023-06-14 02:18:30 +00:00
|
|
|
if prove_negated_obligation(infcx.fork(), &o.with(infcx.tcx, pred), body_def_id) {
|
2022-03-17 15:09:00 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
2022-02-02 17:36:45 +00:00
|
|
|
|
2022-03-17 15:09:00 +00:00
|
|
|
false
|
|
|
|
}
|
2022-03-17 14:26:45 +00:00
|
|
|
|
2022-03-17 15:09:00 +00:00
|
|
|
#[instrument(level = "debug", skip(infcx))]
|
2023-06-14 02:18:30 +00:00
|
|
|
fn prove_negated_obligation<'tcx>(
|
2022-09-09 18:01:06 +00:00
|
|
|
infcx: InferCtxt<'tcx>,
|
2022-03-17 15:09:00 +00:00
|
|
|
o: &PredicateObligation<'tcx>,
|
2022-08-22 18:52:49 +00:00
|
|
|
body_def_id: DefId,
|
2022-03-17 15:09:00 +00:00
|
|
|
) -> bool {
|
|
|
|
let tcx = infcx.tcx;
|
2022-02-02 17:36:45 +00:00
|
|
|
|
2022-03-17 17:55:16 +00:00
|
|
|
let Some(o) = o.flip_polarity(tcx) else {
|
|
|
|
return false;
|
|
|
|
};
|
2022-02-10 19:38:27 +00:00
|
|
|
|
2022-08-20 03:23:23 +00:00
|
|
|
let param_env = o.param_env;
|
2023-03-14 13:19:06 +00:00
|
|
|
let ocx = ObligationCtxt::new(&infcx);
|
|
|
|
ocx.register_obligation(o);
|
|
|
|
let errors = ocx.select_all_or_error();
|
|
|
|
if !errors.is_empty() {
|
2022-03-17 17:55:16 +00:00
|
|
|
return false;
|
|
|
|
}
|
2022-03-17 14:26:45 +00:00
|
|
|
|
2023-01-15 11:58:46 +00:00
|
|
|
let body_def_id = body_def_id.as_local().unwrap_or(CRATE_DEF_ID);
|
2022-08-22 18:52:49 +00:00
|
|
|
|
2022-08-23 12:08:30 +00:00
|
|
|
let ocx = ObligationCtxt::new(&infcx);
|
2023-06-27 21:13:39 +00:00
|
|
|
let Ok(wf_tys) = ocx.assumed_wf_types(param_env, body_def_id) else {
|
|
|
|
return false;
|
|
|
|
};
|
|
|
|
|
2022-08-23 12:08:30 +00:00
|
|
|
let outlives_env = OutlivesEnvironment::with_bounds(
|
|
|
|
param_env,
|
2023-01-15 11:58:46 +00:00
|
|
|
infcx.implied_bounds_tys(param_env, body_def_id, wf_tys),
|
2022-08-23 12:08:30 +00:00
|
|
|
);
|
2022-07-29 06:17:17 +00:00
|
|
|
infcx.resolve_regions(&outlives_env).is_empty()
|
2022-01-21 13:53:17 +00:00
|
|
|
}
|
|
|
|
|
2022-07-20 12:32:58 +00:00
|
|
|
/// Returns whether all impls which would apply to the `trait_ref`
|
|
|
|
/// e.g. `Ty: Trait<Arg>` are already known in the local crate.
|
|
|
|
///
|
|
|
|
/// This both checks whether any downstream or sibling crates could
|
|
|
|
/// implement it and whether an upstream crate can add this impl
|
|
|
|
/// without breaking backwards compatibility.
|
2023-08-04 10:17:28 +00:00
|
|
|
#[instrument(level = "debug", skip(tcx, lazily_normalize_ty), ret)]
|
|
|
|
pub fn trait_ref_is_knowable<'tcx, E: Debug>(
|
2019-06-13 21:48:52 +00:00
|
|
|
tcx: TyCtxt<'tcx>,
|
2019-06-11 21:11:55 +00:00
|
|
|
trait_ref: ty::TraitRef<'tcx>,
|
2023-08-04 10:17:28 +00:00
|
|
|
mut lazily_normalize_ty: impl FnMut(Ty<'tcx>) -> Result<Ty<'tcx>, E>,
|
|
|
|
) -> Result<Result<(), Conflict>, E> {
|
2022-07-20 12:32:58 +00:00
|
|
|
if Some(trait_ref.def_id) == tcx.lang_items().fn_ptr_trait() {
|
|
|
|
// The only types implementing `FnPtr` are function pointers,
|
|
|
|
// so if there's no impl of `FnPtr` in the current crate,
|
|
|
|
// then such an impl will never be added in the future.
|
2023-08-04 10:17:28 +00:00
|
|
|
return Ok(Ok(()));
|
2022-07-20 12:32:58 +00:00
|
|
|
}
|
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
if orphan_check_trait_ref(trait_ref, InCrate::Remote, &mut lazily_normalize_ty)?.is_ok() {
|
2017-11-22 20:39:40 +00:00
|
|
|
// A downstream or cousin crate is allowed to implement some
|
|
|
|
// substitution of this trait-ref.
|
2023-08-04 10:17:28 +00:00
|
|
|
return Ok(Err(Conflict::Downstream));
|
2017-11-28 12:52:34 +00:00
|
|
|
}
|
|
|
|
|
2017-11-22 20:39:40 +00:00
|
|
|
if trait_ref_is_local_or_fundamental(tcx, trait_ref) {
|
|
|
|
// This is a local or fundamental trait, so future-compatibility
|
|
|
|
// is no concern. We know that downstream/cousin crates are not
|
|
|
|
// allowed to implement a substitution of this trait ref, which
|
|
|
|
// means impls could only come from dependencies of this crate,
|
|
|
|
// which we already know about.
|
2023-08-04 10:17:28 +00:00
|
|
|
return Ok(Ok(()));
|
2017-11-22 20:39:40 +00:00
|
|
|
}
|
2017-11-22 21:01:51 +00:00
|
|
|
|
2017-11-22 20:39:40 +00:00
|
|
|
// This is a remote non-fundamental trait, so if another crate
|
|
|
|
// can be the "final owner" of a substitution of this trait-ref,
|
|
|
|
// they are allowed to implement it future-compatibly.
|
|
|
|
//
|
|
|
|
// However, if we are a final owner, then nobody else can be,
|
|
|
|
// and if we are an intermediate owner, then we don't care
|
|
|
|
// about future-compatibility, which means that we're OK if
|
|
|
|
// we are an owner.
|
2023-08-04 10:17:28 +00:00
|
|
|
if orphan_check_trait_ref(trait_ref, InCrate::Local, &mut lazily_normalize_ty)?.is_ok() {
|
|
|
|
Ok(Ok(()))
|
2017-11-22 20:39:40 +00:00
|
|
|
} else {
|
2023-08-04 10:17:28 +00:00
|
|
|
Ok(Err(Conflict::Upstream))
|
2015-03-30 21:46:34 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-13 21:48:52 +00:00
|
|
|
pub fn trait_ref_is_local_or_fundamental<'tcx>(
|
|
|
|
tcx: TyCtxt<'tcx>,
|
2019-06-11 21:11:55 +00:00
|
|
|
trait_ref: ty::TraitRef<'tcx>,
|
|
|
|
) -> bool {
|
2019-05-08 03:21:18 +00:00
|
|
|
trait_ref.def_id.krate == LOCAL_CRATE || tcx.has_attr(trait_ref.def_id, sym::fundamental)
|
2017-08-28 20:50:41 +00:00
|
|
|
}
|
|
|
|
|
2023-01-17 09:39:35 +00:00
|
|
|
#[derive(Debug)]
|
Implement new orphan rule that requires that impls of remote traits meet the following two criteria:
- the self type includes some local type; and,
- type parameters in the self type must be constrained by a local type.
A type parameter is called *constrained* if it appears in some type-parameter of a local type.
Here are some examples that are accepted. In all of these examples, I
assume that `Foo` is a trait defined in another crate. If `Foo` were
defined in the local crate, then all the examples would be legal.
- `impl Foo for LocalType`
- `impl<T> Foo<T> for LocalType` -- T does not appear in Self, so it is OK
- `impl<T> Foo<T> for LocalType<T>` -- T here is constrained by LocalType
- `impl<T> Foo<T> for (LocalType<T>, T)` -- T here is constrained by LocalType
Here are some illegal examples (again, these examples assume that
`Foo` is not local to the current crate):
- `impl Foo for int` -- the Self type is not local
- `impl<T> Foo for T` -- T appears in Self unconstrained by a local type
- `impl<T> Foo for (LocalType, T)` -- T appears in Self unconstrained by a local type
This is a [breaking-change]. For the time being, you can opt out of
the new rules by placing `#[old_orphan_check]` on the trait (and
enabling the feature gate where the trait is defined). Longer term,
you should restructure your traits to avoid the problem. Usually this
means changing the order of parameters so that the "central" type
parameter is in the `Self` position.
As an example of that refactoring, consider the `BorrowFrom` trait:
```rust
pub trait BorrowFrom<Sized? Owned> for Sized? {
fn borrow_from(owned: &Owned) -> &Self;
}
```
As defined, this trait is commonly implemented for custom pointer
types, such as `Arc`. Those impls follow the pattern:
```rust
impl<T> BorrowFrom<Arc<T>> for T {...}
```
Unfortunately, this impl is illegal because the self type `T` is not
local to the current crate. Therefore, we are going to change the order of the parameters,
so that `BorrowFrom` becomes `Borrow`:
```rust
pub trait Borrow<Sized? Borrowed> for Sized? {
fn borrow_from(owned: &Self) -> &Borrowed;
}
```
Now the `Arc` impl is written:
```rust
impl<T> Borrow<T> for Arc<T> { ... }
```
This impl is legal because the self type (`Arc<T>`) is local.
2015-01-05 01:35:06 +00:00
|
|
|
pub enum OrphanCheckErr<'tcx> {
|
2019-10-27 17:22:22 +00:00
|
|
|
NonLocalInputType(Vec<(Ty<'tcx>, bool /* Is this the first input type? */)>),
|
2019-11-09 16:32:15 +00:00
|
|
|
UncoveredTy(Ty<'tcx>, Option<Ty<'tcx>>),
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 08:30:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Checks the coherence orphan rules. `impl_def_id` should be the
|
2019-02-08 13:53:55 +00:00
|
|
|
/// `DefId` of a trait impl. To pass, either the trait must be local, or else
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 08:30:51 +00:00
|
|
|
/// two conditions must be satisfied:
|
|
|
|
///
|
Implement new orphan rule that requires that impls of remote traits meet the following two criteria:
- the self type includes some local type; and,
- type parameters in the self type must be constrained by a local type.
A type parameter is called *constrained* if it appears in some type-parameter of a local type.
Here are some examples that are accepted. In all of these examples, I
assume that `Foo` is a trait defined in another crate. If `Foo` were
defined in the local crate, then all the examples would be legal.
- `impl Foo for LocalType`
- `impl<T> Foo<T> for LocalType` -- T does not appear in Self, so it is OK
- `impl<T> Foo<T> for LocalType<T>` -- T here is constrained by LocalType
- `impl<T> Foo<T> for (LocalType<T>, T)` -- T here is constrained by LocalType
Here are some illegal examples (again, these examples assume that
`Foo` is not local to the current crate):
- `impl Foo for int` -- the Self type is not local
- `impl<T> Foo for T` -- T appears in Self unconstrained by a local type
- `impl<T> Foo for (LocalType, T)` -- T appears in Self unconstrained by a local type
This is a [breaking-change]. For the time being, you can opt out of
the new rules by placing `#[old_orphan_check]` on the trait (and
enabling the feature gate where the trait is defined). Longer term,
you should restructure your traits to avoid the problem. Usually this
means changing the order of parameters so that the "central" type
parameter is in the `Self` position.
As an example of that refactoring, consider the `BorrowFrom` trait:
```rust
pub trait BorrowFrom<Sized? Owned> for Sized? {
fn borrow_from(owned: &Owned) -> &Self;
}
```
As defined, this trait is commonly implemented for custom pointer
types, such as `Arc`. Those impls follow the pattern:
```rust
impl<T> BorrowFrom<Arc<T>> for T {...}
```
Unfortunately, this impl is illegal because the self type `T` is not
local to the current crate. Therefore, we are going to change the order of the parameters,
so that `BorrowFrom` becomes `Borrow`:
```rust
pub trait Borrow<Sized? Borrowed> for Sized? {
fn borrow_from(owned: &Self) -> &Borrowed;
}
```
Now the `Arc` impl is written:
```rust
impl<T> Borrow<T> for Arc<T> { ... }
```
This impl is legal because the self type (`Arc<T>`) is local.
2015-01-05 01:35:06 +00:00
|
|
|
/// 1. All type parameters in `Self` must be "covered" by some local type constructor.
|
|
|
|
/// 2. Some local type must appear in `Self`.
|
2023-01-17 09:39:35 +00:00
|
|
|
#[instrument(level = "debug", skip(tcx), ret)]
|
2019-06-21 16:12:39 +00:00
|
|
|
pub fn orphan_check(tcx: TyCtxt<'_>, impl_def_id: DefId) -> Result<(), OrphanCheckErr<'_>> {
|
2014-09-12 14:54:08 +00:00
|
|
|
// We only except this routine to be invoked on implementations
|
|
|
|
// of a trait, not inherent implementations.
|
2023-07-11 21:35:29 +00:00
|
|
|
let trait_ref = tcx.impl_trait_ref(impl_def_id).unwrap().instantiate_identity();
|
2023-01-17 09:39:35 +00:00
|
|
|
debug!(?trait_ref);
|
2014-09-12 14:54:08 +00:00
|
|
|
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 08:30:51 +00:00
|
|
|
// If the *trait* is local to the crate, ok.
|
2015-08-16 13:06:23 +00:00
|
|
|
if trait_ref.def_id.is_local() {
|
2015-06-18 17:25:05 +00:00
|
|
|
debug!("trait {:?} is local to current crate", trait_ref.def_id);
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 08:30:51 +00:00
|
|
|
return Ok(());
|
2014-09-12 14:54:08 +00:00
|
|
|
}
|
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
orphan_check_trait_ref::<!>(trait_ref, InCrate::Local, |ty| Ok(ty)).unwrap()
|
2015-03-30 21:46:34 +00:00
|
|
|
}
|
|
|
|
|
2019-02-08 13:53:55 +00:00
|
|
|
/// Checks whether a trait-ref is potentially implementable by a crate.
|
2017-11-29 18:50:26 +00:00
|
|
|
///
|
|
|
|
/// The current rule is that a trait-ref orphan checks in a crate C:
|
|
|
|
///
|
|
|
|
/// 1. Order the parameters in the trait-ref in subst order - Self first,
|
2018-11-27 02:59:49 +00:00
|
|
|
/// others linearly (e.g., `<U as Foo<V, W>>` is U < V < W).
|
2017-11-29 18:50:26 +00:00
|
|
|
/// 2. Of these type parameters, there is at least one type parameter
|
|
|
|
/// in which, walking the type as a tree, you can reach a type local
|
|
|
|
/// to C where all types in-between are fundamental types. Call the
|
|
|
|
/// first such parameter the "local key parameter".
|
2018-11-27 02:59:49 +00:00
|
|
|
/// - e.g., `Box<LocalType>` is OK, because you can visit LocalType
|
2017-11-29 18:50:26 +00:00
|
|
|
/// going through `Box`, which is fundamental.
|
|
|
|
/// - similarly, `FundamentalPair<Vec<()>, Box<LocalType>>` is OK for
|
|
|
|
/// the same reason.
|
|
|
|
/// - but (knowing that `Vec<T>` is non-fundamental, and assuming it's
|
|
|
|
/// not local), `Vec<LocalType>` is bad, because `Vec<->` is between
|
|
|
|
/// the local type and the type parameter.
|
2020-07-20 21:18:06 +00:00
|
|
|
/// 3. Before this local type, no generic type parameter of the impl must
|
|
|
|
/// be reachable through fundamental types.
|
|
|
|
/// - e.g. `impl<T> Trait<LocalType> for Vec<T>` is fine, as `Vec` is not fundamental.
|
2022-05-24 07:15:19 +00:00
|
|
|
/// - while `impl<T> Trait<LocalType> for Box<T>` results in an error, as `T` is
|
2020-07-20 21:18:06 +00:00
|
|
|
/// reachable through the fundamental type `Box`.
|
2017-11-29 18:50:26 +00:00
|
|
|
/// 4. Every type in the local key parameter not known in C, going
|
|
|
|
/// through the parameter's type tree, must appear only as a subtree of
|
|
|
|
/// a type local to C, with only fundamental types between the type
|
|
|
|
/// local to C and the local key parameter.
|
2018-11-27 02:59:49 +00:00
|
|
|
/// - e.g., `Vec<LocalType<T>>>` (or equivalently `Box<Vec<LocalType<T>>>`)
|
2017-11-29 18:50:26 +00:00
|
|
|
/// is bad, because the only local type with `T` as a subtree is
|
|
|
|
/// `LocalType<T>`, and `Vec<->` is between it and the type parameter.
|
|
|
|
/// - similarly, `FundamentalPair<LocalType<T>, T>` is bad, because
|
2018-02-16 14:56:50 +00:00
|
|
|
/// the second occurrence of `T` is not a subtree of *any* local type.
|
2017-11-29 18:50:26 +00:00
|
|
|
/// - however, `LocalType<Vec<T>>` is OK, because `T` is a subtree of
|
|
|
|
/// `LocalType<Vec<T>>`, which is local and has no types between it and
|
|
|
|
/// the type parameter.
|
|
|
|
///
|
|
|
|
/// The orphan rules actually serve several different purposes:
|
|
|
|
///
|
2018-11-27 02:59:49 +00:00
|
|
|
/// 1. They enable link-safety - i.e., 2 mutually-unknowing crates (where
|
2017-11-29 18:50:26 +00:00
|
|
|
/// every type local to one crate is unknown in the other) can't implement
|
|
|
|
/// the same trait-ref. This follows because it can be seen that no such
|
|
|
|
/// type can orphan-check in 2 such crates.
|
|
|
|
///
|
|
|
|
/// To check that a local impl follows the orphan rules, we check it in
|
|
|
|
/// InCrate::Local mode, using type parameters for the "generic" types.
|
|
|
|
///
|
|
|
|
/// 2. They ground negative reasoning for coherence. If a user wants to
|
|
|
|
/// write both a conditional blanket impl and a specific impl, we need to
|
|
|
|
/// make sure they do not overlap. For example, if we write
|
2022-04-15 22:04:34 +00:00
|
|
|
/// ```ignore (illustrative)
|
2017-11-29 18:50:26 +00:00
|
|
|
/// impl<T> IntoIterator for Vec<T>
|
|
|
|
/// impl<T: Iterator> IntoIterator for T
|
|
|
|
/// ```
|
2017-12-05 13:43:37 +00:00
|
|
|
/// We need to be able to prove that `Vec<$0>: !Iterator` for every type $0.
|
2017-11-29 18:50:26 +00:00
|
|
|
/// We can observe that this holds in the current crate, but we need to make
|
|
|
|
/// sure this will also hold in all unknown crates (both "independent" crates,
|
|
|
|
/// which we need for link-safety, and also child crates, because we don't want
|
|
|
|
/// child crates to get error for impl conflicts in a *dependency*).
|
|
|
|
///
|
|
|
|
/// For that, we only allow negative reasoning if, for every assignment to the
|
|
|
|
/// inference variables, every unknown crate would get an orphan error if they
|
|
|
|
/// try to implement this trait-ref. To check for this, we use InCrate::Remote
|
|
|
|
/// mode. That is sound because we already know all the impls from known crates.
|
|
|
|
///
|
2020-05-01 20:28:15 +00:00
|
|
|
/// 3. For non-`#[fundamental]` traits, they guarantee that parent crates can
|
2017-11-29 18:50:26 +00:00
|
|
|
/// add "non-blanket" impls without breaking negative reasoning in dependent
|
|
|
|
/// crates. This is the "rebalancing coherence" (RFC 1023) restriction.
|
|
|
|
///
|
|
|
|
/// For that, we only a allow crate to perform negative reasoning on
|
2020-05-01 20:28:15 +00:00
|
|
|
/// non-local-non-`#[fundamental]` only if there's a local key parameter as per (2).
|
2017-11-29 18:50:26 +00:00
|
|
|
///
|
|
|
|
/// Because we never perform negative reasoning generically (coherence does
|
|
|
|
/// not involve type parameters), this can be interpreted as doing the full
|
|
|
|
/// orphan check (using InCrate::Local mode), substituting non-local known
|
|
|
|
/// types for all inference variables.
|
|
|
|
///
|
|
|
|
/// This allows for crates to future-compatibly add impls as long as they
|
|
|
|
/// can't apply to types with a key parameter in a child crate - applying
|
|
|
|
/// the rules, this basically means that every type parameter in the impl
|
|
|
|
/// must appear behind a non-fundamental type (because this is not a
|
|
|
|
/// type-system requirement, crate owners might also go for "semantic
|
|
|
|
/// future-compatibility" involving things such as sealed traits, but
|
|
|
|
/// the above requirement is sufficient, and is necessary in "open world"
|
|
|
|
/// cases).
|
|
|
|
///
|
|
|
|
/// Note that this function is never called for types that have both type
|
|
|
|
/// parameters and inference variables.
|
2023-08-04 10:17:28 +00:00
|
|
|
#[instrument(level = "trace", skip(lazily_normalize_ty), ret)]
|
|
|
|
fn orphan_check_trait_ref<'tcx, E: Debug>(
|
2019-06-11 21:11:55 +00:00
|
|
|
trait_ref: ty::TraitRef<'tcx>,
|
|
|
|
in_crate: InCrate,
|
2023-08-04 10:17:28 +00:00
|
|
|
lazily_normalize_ty: impl FnMut(Ty<'tcx>) -> Result<Ty<'tcx>, E>,
|
|
|
|
) -> Result<Result<(), OrphanCheckErr<'tcx>>, E> {
|
2023-04-27 06:52:17 +00:00
|
|
|
if trait_ref.has_infer() && trait_ref.has_param() {
|
2017-11-29 18:50:26 +00:00
|
|
|
bug!(
|
|
|
|
"can't orphan check a trait ref with both params and inference variables {:?}",
|
|
|
|
trait_ref
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
let mut checker = OrphanChecker::new(in_crate, lazily_normalize_ty);
|
|
|
|
Ok(match trait_ref.visit_with(&mut checker) {
|
2022-07-21 09:51:09 +00:00
|
|
|
ControlFlow::Continue(()) => Err(OrphanCheckErr::NonLocalInputType(checker.non_local_tys)),
|
2023-08-04 10:17:28 +00:00
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::NormalizationFailure(err)) => return Err(err),
|
2022-07-21 09:51:09 +00:00
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::ParamTy(ty)) => {
|
|
|
|
// Does there exist some local type after the `ParamTy`.
|
|
|
|
checker.search_first_local_ty = true;
|
|
|
|
if let Some(OrphanCheckEarlyExit::LocalTy(local_ty)) =
|
|
|
|
trait_ref.visit_with(&mut checker).break_value()
|
|
|
|
{
|
|
|
|
Err(OrphanCheckErr::UncoveredTy(ty, Some(local_ty)))
|
|
|
|
} else {
|
|
|
|
Err(OrphanCheckErr::UncoveredTy(ty, None))
|
2020-03-20 03:28:17 +00:00
|
|
|
}
|
2019-09-17 12:40:36 +00:00
|
|
|
}
|
2022-07-21 09:51:09 +00:00
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(_)) => Ok(()),
|
2023-08-04 10:17:28 +00:00
|
|
|
})
|
2015-03-30 21:46:34 +00:00
|
|
|
}
|
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
struct OrphanChecker<'tcx, F> {
|
2021-12-14 09:44:49 +00:00
|
|
|
in_crate: InCrate,
|
2022-07-21 09:51:09 +00:00
|
|
|
in_self_ty: bool,
|
2023-08-04 10:17:28 +00:00
|
|
|
lazily_normalize_ty: F,
|
2022-07-21 09:51:09 +00:00
|
|
|
/// Ignore orphan check failures and exclusively search for the first
|
|
|
|
/// local type.
|
|
|
|
search_first_local_ty: bool,
|
|
|
|
non_local_tys: Vec<(Ty<'tcx>, bool)>,
|
|
|
|
}
|
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
impl<'tcx, F, E> OrphanChecker<'tcx, F>
|
|
|
|
where
|
|
|
|
F: FnOnce(Ty<'tcx>) -> Result<Ty<'tcx>, E>,
|
|
|
|
{
|
|
|
|
fn new(in_crate: InCrate, lazily_normalize_ty: F) -> Self {
|
2022-07-21 09:51:09 +00:00
|
|
|
OrphanChecker {
|
|
|
|
in_crate,
|
|
|
|
in_self_ty: true,
|
2023-08-04 10:17:28 +00:00
|
|
|
lazily_normalize_ty,
|
2022-07-21 09:51:09 +00:00
|
|
|
search_first_local_ty: false,
|
|
|
|
non_local_tys: Vec::new(),
|
2020-07-17 19:40:47 +00:00
|
|
|
}
|
2019-10-13 18:25:30 +00:00
|
|
|
}
|
2015-03-30 21:46:34 +00:00
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
fn found_non_local_ty(&mut self, t: Ty<'tcx>) -> ControlFlow<OrphanCheckEarlyExit<'tcx, E>> {
|
2022-07-21 09:51:09 +00:00
|
|
|
self.non_local_tys.push((t, self.in_self_ty));
|
2023-01-18 07:17:13 +00:00
|
|
|
ControlFlow::Continue(())
|
2022-07-21 09:51:09 +00:00
|
|
|
}
|
2020-03-20 03:28:17 +00:00
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
fn found_param_ty(&mut self, t: Ty<'tcx>) -> ControlFlow<OrphanCheckEarlyExit<'tcx, E>> {
|
2022-07-21 09:51:09 +00:00
|
|
|
if self.search_first_local_ty {
|
2023-01-18 07:17:13 +00:00
|
|
|
ControlFlow::Continue(())
|
2022-07-21 09:51:09 +00:00
|
|
|
} else {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::ParamTy(t))
|
2020-03-20 03:28:17 +00:00
|
|
|
}
|
2022-07-21 09:51:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
fn def_id_is_local(&mut self, def_id: DefId) -> bool {
|
|
|
|
match self.in_crate {
|
|
|
|
InCrate::Local => def_id.is_local(),
|
|
|
|
InCrate::Remote => false,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-03-20 03:28:17 +00:00
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
enum OrphanCheckEarlyExit<'tcx, E> {
|
|
|
|
NormalizationFailure(E),
|
2022-07-21 09:51:09 +00:00
|
|
|
ParamTy(Ty<'tcx>),
|
|
|
|
LocalTy(Ty<'tcx>),
|
2015-03-30 21:46:34 +00:00
|
|
|
}
|
|
|
|
|
2023-08-04 10:17:28 +00:00
|
|
|
impl<'tcx, F, E> TypeVisitor<TyCtxt<'tcx>> for OrphanChecker<'tcx, F>
|
|
|
|
where
|
|
|
|
F: FnMut(Ty<'tcx>) -> Result<Ty<'tcx>, E>,
|
|
|
|
{
|
|
|
|
type BreakTy = OrphanCheckEarlyExit<'tcx, E>;
|
2022-07-21 09:51:09 +00:00
|
|
|
fn visit_region(&mut self, _r: ty::Region<'tcx>) -> ControlFlow<Self::BreakTy> {
|
2023-01-18 07:17:13 +00:00
|
|
|
ControlFlow::Continue(())
|
2017-11-22 20:39:40 +00:00
|
|
|
}
|
|
|
|
|
2022-07-21 09:51:09 +00:00
|
|
|
fn visit_ty(&mut self, ty: Ty<'tcx>) -> ControlFlow<Self::BreakTy> {
|
2023-08-04 10:17:28 +00:00
|
|
|
// Need to lazily normalize here in with `-Ztrait-solver=next-coherence`.
|
|
|
|
let ty = match (self.lazily_normalize_ty)(ty) {
|
|
|
|
Ok(ty) => ty,
|
|
|
|
Err(err) => return ControlFlow::Break(OrphanCheckEarlyExit::NormalizationFailure(err)),
|
|
|
|
};
|
|
|
|
|
2022-07-21 09:51:09 +00:00
|
|
|
let result = match *ty.kind() {
|
|
|
|
ty::Bool
|
|
|
|
| ty::Char
|
|
|
|
| ty::Int(..)
|
|
|
|
| ty::Uint(..)
|
|
|
|
| ty::Float(..)
|
|
|
|
| ty::Str
|
|
|
|
| ty::FnDef(..)
|
|
|
|
| ty::FnPtr(_)
|
|
|
|
| ty::Array(..)
|
|
|
|
| ty::Slice(..)
|
|
|
|
| ty::RawPtr(..)
|
|
|
|
| ty::Never
|
|
|
|
| ty::Tuple(..)
|
2023-03-07 12:03:11 +00:00
|
|
|
| ty::Alias(ty::Projection | ty::Inherent | ty::Weak, ..) => {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
2022-07-21 09:51:09 +00:00
|
|
|
|
|
|
|
ty::Param(..) => self.found_param_ty(ty),
|
|
|
|
|
|
|
|
ty::Placeholder(..) | ty::Bound(..) | ty::Infer(..) => match self.in_crate {
|
|
|
|
InCrate::Local => self.found_non_local_ty(ty),
|
|
|
|
// The inference variable might be unified with a local
|
|
|
|
// type in that remote crate.
|
|
|
|
InCrate::Remote => ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty)),
|
|
|
|
},
|
|
|
|
|
|
|
|
// For fundamental types, we just look inside of them.
|
|
|
|
ty::Ref(_, ty, _) => ty.visit_with(self),
|
2023-07-11 21:35:29 +00:00
|
|
|
ty::Adt(def, args) => {
|
2022-07-21 09:51:09 +00:00
|
|
|
if self.def_id_is_local(def.did()) {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else if def.is_fundamental() {
|
2023-07-11 21:35:29 +00:00
|
|
|
args.visit_with(self)
|
2022-07-21 09:51:09 +00:00
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
2018-12-04 11:28:06 +00:00
|
|
|
}
|
2022-07-21 09:51:09 +00:00
|
|
|
ty::Foreign(def_id) => {
|
|
|
|
if self.def_id_is_local(def_id) {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ty::Dynamic(tt, ..) => {
|
|
|
|
let principal = tt.principal().map(|p| p.def_id());
|
2023-05-24 14:19:22 +00:00
|
|
|
if principal.is_some_and(|p| self.def_id_is_local(p)) {
|
2022-07-21 09:51:09 +00:00
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ty::Error(_) => ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty)),
|
2023-01-17 09:39:35 +00:00
|
|
|
ty::Closure(did, ..) | ty::Generator(did, ..) => {
|
|
|
|
if self.def_id_is_local(did) {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
2022-07-21 09:51:09 +00:00
|
|
|
}
|
2023-01-17 09:39:35 +00:00
|
|
|
// This should only be created when checking whether we have to check whether some
|
|
|
|
// auto trait impl applies. There will never be multiple impls, so we can just
|
|
|
|
// act as if it were a local type here.
|
2022-10-01 12:56:24 +00:00
|
|
|
ty::GeneratorWitness(_) | ty::GeneratorWitnessMIR(..) => {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
}
|
2022-11-26 21:51:55 +00:00
|
|
|
ty::Alias(ty::Opaque, ..) => {
|
2022-07-24 10:34:35 +00:00
|
|
|
// This merits some explanation.
|
|
|
|
// Normally, opaque types are not involved when performing
|
|
|
|
// coherence checking, since it is illegal to directly
|
|
|
|
// implement a trait on an opaque type. However, we might
|
|
|
|
// end up looking at an opaque type during coherence checking
|
|
|
|
// if an opaque type gets used within another type (e.g. as
|
|
|
|
// the type of a field) when checking for auto trait or `Sized`
|
|
|
|
// impls. This requires us to decide whether or not an opaque
|
|
|
|
// type should be considered 'local' or not.
|
|
|
|
//
|
|
|
|
// We choose to treat all opaque types as non-local, even
|
|
|
|
// those that appear within the same crate. This seems
|
|
|
|
// somewhat surprising at first, but makes sense when
|
|
|
|
// you consider that opaque types are supposed to hide
|
|
|
|
// the underlying type *within the same crate*. When an
|
|
|
|
// opaque type is used from outside the module
|
|
|
|
// where it is declared, it should be impossible to observe
|
|
|
|
// anything about it other than the traits that it implements.
|
|
|
|
//
|
|
|
|
// The alternative would be to look at the underlying type
|
|
|
|
// to determine whether or not the opaque type itself should
|
|
|
|
// be considered local. However, this could make it a breaking change
|
|
|
|
// to switch the underlying ('defining') type from a local type
|
|
|
|
// to a remote type. This would violate the rule that opaque
|
|
|
|
// types should be completely opaque apart from the traits
|
|
|
|
// that they implement, so we don't use this behavior.
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
2022-07-21 09:51:09 +00:00
|
|
|
};
|
|
|
|
// A bit of a hack, the `OrphanChecker` is only used to visit a `TraitRef`, so
|
|
|
|
// the first type we visit is always the self type.
|
|
|
|
self.in_self_ty = false;
|
|
|
|
result
|
|
|
|
}
|
2014-09-12 14:54:08 +00:00
|
|
|
|
2022-07-29 07:43:22 +00:00
|
|
|
/// All possible values for a constant parameter already exist
|
|
|
|
/// in the crate defining the trait, so they are always non-local[^1].
|
|
|
|
///
|
|
|
|
/// Because there's no way to have an impl where the first local
|
|
|
|
/// generic argument is a constant, we also don't have to fail
|
|
|
|
/// the orphan check when encountering a parameter or a generic constant.
|
|
|
|
///
|
|
|
|
/// This means that we can completely ignore constants during the orphan check.
|
|
|
|
///
|
2023-01-05 08:45:44 +00:00
|
|
|
/// See `tests/ui/coherence/const-generics-orphan-check-ok.rs` for examples.
|
2022-07-29 07:43:22 +00:00
|
|
|
///
|
|
|
|
/// [^1]: This might not hold for function pointers or trait objects in the future.
|
|
|
|
/// As these should be quite rare as const arguments and especially rare as impl
|
|
|
|
/// parameters, allowing uncovered const parameters in impls seems more useful
|
|
|
|
/// than allowing `impl<T> Trait<local_fn_ptr, T> for i32` to compile.
|
2022-07-21 09:51:09 +00:00
|
|
|
fn visit_const(&mut self, _c: ty::Const<'tcx>) -> ControlFlow<Self::BreakTy> {
|
2023-01-18 07:17:13 +00:00
|
|
|
ControlFlow::Continue(())
|
2014-09-12 14:54:08 +00:00
|
|
|
}
|
|
|
|
}
|