This website requires JavaScript.
Explore
Help
Sign In
nordic-dev.net
/
rust
Watch
2
Star
0
Fork
0
You've already forked rust
mirror of
https://github.com/rust-lang/rust.git
synced
2025-06-20 19:47:33 +00:00
Code
Issues
Packages
Projects
Releases
Wiki
Activity
70b146c2cb
Branches
Tags
No results found.
rust
/
src
/
test
/
ui
/
async-await
/
issues
/
issue-54752-async-block.rs
7 lines
79 B
Rust
Raw
Normal View
History
Unescape
Escape
Move async/await tests to test/ui/async-await
2019-05-24 20:49:34 +00:00
// run-pass
abolish ICE when pretty-printing async block Joshua Netterfield reported an ICE when the unused-parentheses lint triggered around an async block (#54752). In order to compose an autofixable suggestion, the lint invokes the pretty-printer on the unnecessarily-parenthesized expression. (One wonders why the lint doesn't just use `SourceMap::span_to_snippet` instead, to preserve the formatting of the original source?—but for that, you'd have to ask the author of 5c9f806d.) But then the pretty-printer panics when trying to call `<pprust::State as PrintState>::end` when `State.boxes` is empty. Empirically, the problem would seem to be solved if we start some "boxes" beforehand in the `ast::ExprKind::Async` arm of the big match in `print_expr_outer_attr_style`, exactly like we do in the immediately-preceding match arm for `ast::ExprKind::Block`—it would seem pretty ("pretty") reasonable for the pretty-printing of async blocks to work a lot like the pretty-printing of ordinary non-async blocks, right?? Of course, it would be shamefully cargo-culty to commit code on the basis of this kind of mere reasoning-by-analogy (in contrast to understanding the design of the pretty-printer in such detail that the correctness of the patch is comprehended with all the lucid certainty of mathematical proof, rather than being merely surmised by intuition). But maybe we care more about fixing the bug with high probability today, than with certainty in some indefinite hypothetical future? Maybe the effort is worth a fifth of a shirt?? Humbly resolves #54752.
2018-10-03 04:43:05 +00:00
// edition:2018
// pp-exact
fn
main
(
)
{
let
_a
=
(
async
{
}
)
;
}
Reference in New Issue
Copy Permalink