rust/tests/ui/redundant_clone.rs

189 lines
3.9 KiB
Rust
Raw Normal View History

2019-09-10 02:56:34 +00:00
// run-rustfix
// rustfix-only-machine-applicable
2021-02-12 04:27:04 +00:00
#![allow(clippy::implicit_clone)]
2018-10-23 07:01:45 +00:00
use std::ffi::OsString;
2018-12-09 22:26:16 +00:00
use std::path::Path;
2018-10-23 07:01:45 +00:00
fn main() {
2019-09-10 02:56:34 +00:00
let _s = ["lorem", "ipsum"].join(" ").to_string();
2018-10-23 07:01:45 +00:00
let s = String::from("foo");
2019-09-10 02:56:34 +00:00
let _s = s.clone();
2018-10-23 07:01:45 +00:00
let s = String::from("foo");
2019-09-10 02:56:34 +00:00
let _s = s.to_string();
2018-10-23 07:01:45 +00:00
let s = String::from("foo");
2019-09-10 02:56:34 +00:00
let _s = s.to_owned();
2018-10-23 07:01:45 +00:00
2019-09-10 02:56:34 +00:00
let _s = Path::new("/a/b/").join("c").to_owned();
2018-10-23 07:01:45 +00:00
2019-09-10 02:56:34 +00:00
let _s = Path::new("/a/b/").join("c").to_path_buf();
2018-10-23 07:01:45 +00:00
2019-09-10 02:56:34 +00:00
let _s = OsString::new().to_owned();
2018-10-23 07:01:45 +00:00
2019-09-10 02:56:34 +00:00
let _s = OsString::new().to_os_string();
2018-10-25 12:08:32 +00:00
// Check that lint level works
2018-12-09 22:26:16 +00:00
#[allow(clippy::redundant_clone)]
2019-09-10 02:56:34 +00:00
let _s = String::new().to_string();
2018-12-09 11:19:21 +00:00
let tup = (String::from("foo"),);
2019-09-10 02:56:34 +00:00
let _t = tup.0.clone();
2018-12-09 11:19:21 +00:00
let tup_ref = &(String::from("foo"),);
let _s = tup_ref.0.clone(); // this `.clone()` cannot be removed
{
let x = String::new();
let y = &x;
2019-09-10 02:56:34 +00:00
let _x = x.clone(); // ok; `x` is borrowed by `y`
let _ = y.len();
}
let x = (String::new(),);
let _ = Some(String::new()).unwrap_or_else(|| x.0.clone()); // ok; closure borrows `x`
2019-09-10 02:56:34 +00:00
with_branch(Alpha, true);
cannot_double_move(Alpha);
2019-09-10 02:56:34 +00:00
cannot_move_from_type_with_drop();
borrower_propagation();
not_consumed();
issue_5405();
manually_drop();
2018-10-23 07:01:45 +00:00
}
#[derive(Clone)]
struct Alpha;
fn with_branch(a: Alpha, b: bool) -> (Alpha, Alpha) {
if b {
2018-10-23 07:01:45 +00:00
(a.clone(), a.clone())
} else {
(Alpha, a)
}
}
2018-12-09 11:19:21 +00:00
fn cannot_double_move(a: Alpha) -> (Alpha, Alpha) {
(a.clone(), a)
}
2018-12-09 11:19:21 +00:00
struct TypeWithDrop {
x: String,
}
impl Drop for TypeWithDrop {
fn drop(&mut self) {}
}
fn cannot_move_from_type_with_drop() -> String {
let s = TypeWithDrop { x: String::new() };
2018-12-09 11:19:21 +00:00
s.x.clone() // removing this `clone()` summons E0509
}
fn borrower_propagation() {
let s = String::new();
let t = String::new();
{
fn b() -> bool {
unimplemented!()
}
2019-09-10 02:56:34 +00:00
let _u = if b() { &s } else { &t };
// ok; `s` and `t` are possibly borrowed
2019-09-10 02:56:34 +00:00
let _s = s.clone();
let _t = t.clone();
}
{
2019-09-10 02:56:34 +00:00
let _u = || s.len();
let _v = [&t; 32];
let _s = s.clone(); // ok
let _t = t.clone(); // ok
}
{
2019-09-10 02:56:34 +00:00
let _u = {
let u = Some(&s);
let _ = s.clone(); // ok
u
};
2019-09-10 02:56:34 +00:00
let _s = s.clone(); // ok
}
{
use std::convert::identity as id;
2019-09-10 02:56:34 +00:00
let _u = id(id(&s));
let _s = s.clone(); // ok, `u` borrows `s`
}
2019-09-10 02:56:34 +00:00
let _s = s.clone();
let _t = t.clone();
#[derive(Clone)]
struct Foo {
x: usize,
}
{
let f = Foo { x: 123 };
let _x = Some(f.x);
let _f = f.clone();
}
{
let f = Foo { x: 123 };
let _x = &f.x;
let _f = f.clone(); // ok
}
}
fn not_consumed() {
let x = std::path::PathBuf::from("home");
let y = x.clone().join("matthias");
// join() creates a new owned PathBuf, does not take a &mut to x variable, thus the .clone() is
// redundant. (It also does not consume the PathBuf)
println!("x: {:?}, y: {:?}", x, y);
2020-03-12 16:25:18 +00:00
let mut s = String::new();
s.clone().push_str("foo"); // OK, removing this `clone()` will change the behavior.
s.push_str("bar");
assert_eq!(s, "bar");
2020-03-12 17:06:47 +00:00
let t = Some(s);
// OK
if let Some(x) = t.clone() {
println!("{}", x);
}
if let Some(x) = t {
println!("{}", x);
}
}
#[allow(clippy::clone_on_copy)]
fn issue_5405() {
let a: [String; 1] = [String::from("foo")];
let _b: String = a[0].clone();
let c: [usize; 2] = [2, 3];
let _d: usize = c[1].clone();
}
fn manually_drop() {
use std::mem::ManuallyDrop;
use std::sync::Arc;
let a = ManuallyDrop::new(Arc::new("Hello!".to_owned()));
let _ = a.clone(); // OK
let p: *const String = Arc::into_raw(ManuallyDrop::into_inner(a));
unsafe {
Arc::from_raw(p);
Arc::from_raw(p);
}
}