2018-08-30 12:18:55 +00:00
|
|
|
// run-pass
|
2013-03-21 22:00:29 +00:00
|
|
|
trait X {
|
2015-01-20 23:45:07 +00:00
|
|
|
fn call<T: std::fmt::Debug>(&self, x: &T);
|
|
|
|
|
fn default_method<T: std::fmt::Debug>(&self, x: &T) {
|
2014-12-20 08:09:35 +00:00
|
|
|
println!("X::default_method {:?}", x);
|
2014-02-19 22:12:09 +00:00
|
|
|
}
|
2013-03-21 22:00:29 +00:00
|
|
|
}
|
|
|
|
|
|
2015-01-20 23:45:07 +00:00
|
|
|
#[derive(Debug)]
|
2022-07-25 20:36:03 +00:00
|
|
|
struct Y(#[allow(unused_tuple_struct_fields)] isize);
|
2013-03-21 22:00:29 +00:00
|
|
|
|
2015-01-20 23:45:07 +00:00
|
|
|
#[derive(Debug)]
|
Reject specialized Drop impls.
See Issue 8142 for discussion.
This makes it illegal for a Drop impl to be more specialized than the
original item.
So for example, all of the following are now rejected (when they would
have been blindly accepted before):
```rust
struct S<A> { ... };
impl Drop for S<i8> { ... } // error: specialized to concrete type
struct T<'a> { ... };
impl Drop for T<'static> { ... } // error: specialized to concrete region
struct U<A> { ... };
impl<A:Clone> Drop for U<A> { ... } // error: added extra type requirement
struct V<'a,'b>;
impl<'a,'b:a> Drop for V<'a,'b> { ... } // error: added extra region requirement
```
Due to examples like the above, this is a [breaking-change].
(The fix is to either remove the specialization from the `Drop` impl,
or to transcribe the requirements into the struct/enum definition;
examples of both are shown in the PR's fixed to `libstd`.)
----
This is likely to be the last thing blocking the removal of the
`#[unsafe_destructor]` attribute.
Includes two new error codes for the new dropck check.
Update run-pass tests to accommodate new dropck pass.
Update tests and docs to reflect new destructor restriction.
----
Implementation notes:
We identify Drop impl specialization by not being as parametric as the
struct/enum definition via unification.
More specifically:
1. Attempt unification of a skolemized instance of the struct/enum
with an instance of the Drop impl's type expression where all of
the impl's generics (i.e. the free variables of the type
expression) have been replaced with unification variables.
2. If unification fails, then reject Drop impl as specialized.
3. If unification succeeds, check if any of the skolemized
variables "leaked" into the constraint set for the inference
context; if so, then reject Drop impl as specialized.
4. Otherwise, unification succeeded without leaking skolemized
variables: accept the Drop impl.
We identify whether a Drop impl is injecting new predicates by simply
looking whether the predicate, after an appropriate substitution,
appears on the struct/enum definition.
2015-03-21 12:12:08 +00:00
|
|
|
struct Z<T: X+std::fmt::Debug> {
|
2013-03-21 22:00:29 +00:00
|
|
|
x: T
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl X for Y {
|
2015-01-20 23:45:07 +00:00
|
|
|
fn call<T: std::fmt::Debug>(&self, x: &T) {
|
2014-12-20 08:09:35 +00:00
|
|
|
println!("X::call {:?} {:?}", self, x);
|
2013-03-21 22:00:29 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-01-20 23:45:07 +00:00
|
|
|
impl<T: X + std::fmt::Debug> Drop for Z<T> {
|
2013-09-17 01:18:07 +00:00
|
|
|
fn drop(&mut self) {
|
2014-02-19 22:12:09 +00:00
|
|
|
// These statements used to cause an ICE.
|
|
|
|
|
self.x.call(self);
|
|
|
|
|
self.x.default_method(self);
|
2013-03-21 22:00:29 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-01-03 23:30:54 +00:00
|
|
|
pub fn main() {
|
2014-02-19 22:12:09 +00:00
|
|
|
let _z = Z {x: Y(42)};
|
2013-09-24 00:20:36 +00:00
|
|
|
}
|