rust/tests/ui/lexer/lex-bare-cr-string-literal-doc-comment.rs

// ignore-tidy-cr

/// doc comment with bare CR: '
'
pub fn foo() {}
//~^^ ERROR: bare CR not allowed in doc-comment

/** block doc comment with bare CR: '
' */
pub fn bar() {}
//~^^ ERROR: bare CR not allowed in block doc-comment

fn main() {
    //! doc comment with bare CR: '
'
    //~^ ERROR: bare CR not allowed in doc-comment

    /*! block doc comment with bare CR: '
' */
    //~^ ERROR: bare CR not allowed in block doc-comment

    // the following string literal has a bare CR in it
    let _s = "foo
bar"; //~ ERROR: bare CR not allowed in string

    // the following string literal has a bare CR in it
    let _s = r"bar
foo"; //~ ERROR: bare CR not allowed in raw string

    // the following string literal has a bare CR in it
    let _s = "foo\
bar"; //~ ERROR: unknown character escape: `\r`
}
Handle CRLF properly in the lexer The lexer already ignores CRLF in between tokens, but it doesn't properly handle carriage returns inside strings and doc comments. Teach it to treat CRLF as LF inside these tokens, and to disallow carriage returns that are not followed by linefeeds. This includes handling an escaped CRLF inside a regular string token the same way it handles an escaped LF. This is technically a breaking change, as bare carriage returns are no longer allowed, and CRLF sequences are now treated as LF inside strings and doc comments, but it's very unlikely to actually affect any real-world code. This change is necessary to have Rust code compile on Windows the same way it does on Unix. The mozilla/rust repository explicitly sets eol=lf for Rust source files, but other Rust repositories don't. Notably, rust-http cannot be compiled on Windows without converting the CRLF line endings back to LF. [breaking-change] 2014-05-24 08:13:59 +00:00			`// ignore-tidy-cr`

			`/// doc comment with bare CR: ' '`
			`pub fn foo() {}`
			`//~^^ ERROR: bare CR not allowed in doc-comment`

			`/** block doc comment with bare CR: ' ' */`
			`pub fn bar() {}`
			`//~^^ ERROR: bare CR not allowed in block doc-comment`

			`fn main() {`
Allow bare CR in ////-style comment. 2017-05-08 13:29:24 +00:00			`//! doc comment with bare CR: ' '`
			`//~^ ERROR: bare CR not allowed in doc-comment`

			`/! block doc comment with bare CR: ' ' /`
			`//~^ ERROR: bare CR not allowed in block doc-comment`

Handle CRLF properly in the lexer The lexer already ignores CRLF in between tokens, but it doesn't properly handle carriage returns inside strings and doc comments. Teach it to treat CRLF as LF inside these tokens, and to disallow carriage returns that are not followed by linefeeds. This includes handling an escaped CRLF inside a regular string token the same way it handles an escaped LF. This is technically a breaking change, as bare carriage returns are no longer allowed, and CRLF sequences are now treated as LF inside strings and doc comments, but it's very unlikely to actually affect any real-world code. This change is necessary to have Rust code compile on Windows the same way it does on Unix. The mozilla/rust repository explicitly sets eol=lf for Rust source files, but other Rust repositories don't. Notably, rust-http cannot be compiled on Windows without converting the CRLF line endings back to LF. [breaking-change] 2014-05-24 08:13:59 +00:00			`// the following string literal has a bare CR in it`
			`let _s = "foo bar"; //~ ERROR: bare CR not allowed in string`

			`// the following string literal has a bare CR in it`
			`let _s = r"bar foo"; //~ ERROR: bare CR not allowed in raw string`

			`// the following string literal has a bare CR in it`
Handle `Span`s for byte and raw strings and add more detail 2021-01-23 20:48:31 +00:00			let _s = "foo\ bar"; //~ ERROR: unknown character escape: `\r`
Handle CRLF properly in the lexer The lexer already ignores CRLF in between tokens, but it doesn't properly handle carriage returns inside strings and doc comments. Teach it to treat CRLF as LF inside these tokens, and to disallow carriage returns that are not followed by linefeeds. This includes handling an escaped CRLF inside a regular string token the same way it handles an escaped LF. This is technically a breaking change, as bare carriage returns are no longer allowed, and CRLF sequences are now treated as LF inside strings and doc comments, but it's very unlikely to actually affect any real-world code. This change is necessary to have Rust code compile on Windows the same way it does on Unix. The mozilla/rust repository explicitly sets eol=lf for Rust source files, but other Rust repositories don't. Notably, rust-http cannot be compiled on Windows without converting the CRLF line endings back to LF. [breaking-change] 2014-05-24 08:13:59 +00:00			`}`