2024-01-22 02:13:20 +00:00
# This file's format is documented at
# https://forge.rust-lang.org/triagebot/pr-assignment.html#configuration
2019-04-15 21:52:59 +00:00
[ relabel ]
allow-unauthenticated = [
2022-06-22 21:02:48 +00:00
"A-*" ,
"C-*" ,
2020-02-27 01:54:13 +00:00
"D-*" ,
2022-06-22 21:02:48 +00:00
"E-*" ,
"F-*" ,
"I-*" ,
"NLL-*" ,
"O-*" ,
"S-*" ,
"T-*" ,
"WG-*" ,
2023-04-14 02:55:27 +00:00
"beta-nominated" ,
2022-09-12 15:04:32 +00:00
"const-hack" ,
2023-09-20 05:49:23 +00:00
"llvm-*" ,
2021-11-04 12:35:10 +00:00
"needs-fcp" ,
2021-11-04 12:34:10 +00:00
"relnotes" ,
2022-11-26 00:06:52 +00:00
"requires-*" ,
2020-10-04 23:57:32 +00:00
"regression-*" ,
2023-08-10 20:27:49 +00:00
"rla-*" ,
2021-07-01 12:56:24 +00:00
"perf-*" ,
2019-10-03 16:31:06 +00:00
"AsyncAwait-OnDeck" ,
2023-07-06 15:57:03 +00:00
"needs-triage" ,
2024-01-13 18:49:39 +00:00
"has-merge-commits" ,
2019-04-15 21:52:59 +00:00
]
2019-05-16 20:22:18 +00:00
2023-10-19 05:39:28 +00:00
[ review-submitted ]
# This label is added when a "request changes" review is submitted.
reviewed_label = "S-waiting-on-author"
# These labels are removed when a "request changes" review is submitted.
2023-10-12 13:36:39 +00:00
review_labels = [ "S-waiting-on-review" ]
2023-10-15 22:37:05 +00:00
[ review-requested ]
# Those labels are removed when PR author requests a review from an assignee
remove_labels = [ "S-waiting-on-author" ]
# Those labels are added when PR author requests a review from an assignee
add_labels = [ "S-waiting-on-review" ]
2020-05-25 06:07:55 +00:00
[ glacier ]
2019-10-17 20:53:47 +00:00
[ ping . icebreakers-llvm ]
2020-03-12 17:06:40 +00:00
alias = [ "llvm" , "llvms" ]
2019-10-17 18:15:59 +00:00
message = "" " \
Hey LLVM ICE-breakers ! This bug has been identified as a good
"LLVM ICE-breaking candidate" . In case it ' s useful , here are some
[ instructions ] for tackling these sorts of bugs . Maybe take a look ?
Thanks ! < 3
2020-06-09 22:01:58 +00:00
[ instructions ] : https : / / rustc-dev-guide . rust-lang . org / notification-groups / llvm . html
2019-10-17 18:15:59 +00:00
"" "
label = "ICEBreaker-LLVM"
2020-01-27 18:58:27 +00:00
[ ping . icebreakers-cleanup-crew ]
2020-03-19 14:38:31 +00:00
alias = [ "cleanup" , "cleanups" , "cleanup-crew" , "shrink" , "reduce" , "bisect" ]
2020-01-27 18:58:27 +00:00
message = "" " \
Hey Cleanup Crew ICE-breakers ! This bug has been identified as a good
"Cleanup ICE-breaking candidate" . In case it ' s useful , here are some
[ instructions ] for tackling these sorts of bugs . Maybe take a look ?
Thanks ! < 3
2020-06-09 22:01:58 +00:00
[ instructions ] : https : / / rustc-dev-guide . rust-lang . org / notification-groups / cleanup-crew . html
2020-01-27 18:58:27 +00:00
"" "
label = "ICEBreaker-Cleanup-Crew"
2020-04-10 13:22:40 +00:00
2020-05-28 19:08:46 +00:00
[ ping . windows ]
message = "" " \
Hey Windows Group ! This bug has been identified as a good "Windows candidate" .
In case it ' s useful , here are some [ instructions ] for tackling these sorts of
bugs . Maybe take a look ?
Thanks ! < 3
2020-06-12 18:33:18 +00:00
2020-06-10 00:19:26 +00:00
[ instructions ] : https : / / rustc-dev-guide . rust-lang . org / notification-groups / windows . html
2020-05-28 19:08:46 +00:00
"" "
label = "O-windows"
2020-06-09 22:01:58 +00:00
[ ping . arm ]
message = "" " \
Hey ARM Group ! This bug has been identified as a good "ARM candidate" .
In case it ' s useful , here are some [ instructions ] for tackling these sorts of
bugs . Maybe take a look ?
Thanks ! < 3
2020-06-12 18:33:18 +00:00
2020-06-10 00:19:26 +00:00
[ instructions ] : https : / / rustc-dev-guide . rust-lang . org / notification-groups / arm . html
2020-06-09 22:01:58 +00:00
"" "
label = "O-ARM"
2020-07-28 12:01:13 +00:00
[ ping . risc-v ]
message = "" " \
Hey RISC-V Group ! This bug has been identified as a good "RISC-V candidate" .
In case it ' s useful , here are some [ instructions ] for tackling these sorts of
bugs . Maybe take a look ?
Thanks ! < 3
[ instructions ] : https : / / rustc-dev-guide . rust-lang . org / notification-groups / risc-v . html
"" "
label = "O-riscv"
2022-03-03 23:33:05 +00:00
[ ping . fuchsia ]
message = "" " \
Hey friends of Fuchsia ! This issue could use some guidance on how this should be
resolved / implemented on Fuchsia . Could one of you weigh in ?
"" "
label = "O-fuchsia"
2022-05-26 19:42:14 +00:00
[ ping . macos ]
message = "" " \
Hey MacOS Group ! This issue or PR could use some MacOS-specific guidance . Could one
of you weigh in ? Thanks < 3
"" "
label = "O-macos"
2020-04-10 13:22:40 +00:00
[ prioritize ]
label = "I-prioritize"
2020-06-11 17:21:09 +00:00
[ autolabel . "I-prioritize" ]
trigger_labels = [
2020-10-09 21:10:44 +00:00
"regression-untriaged" ,
2020-06-09 20:58:32 +00:00
"regression-from-stable-to-stable" ,
"regression-from-stable-to-beta" ,
"regression-from-stable-to-nightly" ,
2021-06-01 16:26:42 +00:00
"I-unsound" ,
2020-06-09 20:58:32 +00:00
]
2020-05-20 15:15:43 +00:00
exclude_labels = [
"P-*" ,
"T-infra" ,
"T-release" ,
2020-06-09 20:58:32 +00:00
"requires-nightly" ,
2020-05-20 15:15:43 +00:00
]
2020-06-11 17:21:09 +00:00
2021-12-12 00:51:07 +00:00
[ autolabel . "T-rustdoc" ]
trigger_files = [
# Source code
"src/librustdoc" ,
"src/tools/rustdoc" ,
"src/rustdoc-json-types" ,
# Tests
2023-01-05 08:45:44 +00:00
"tests/rustdoc" ,
"tests/rustdoc-ui" ,
"tests/rustdoc-gui" ,
"tests/rustdoc-js" ,
"tests/rustdoc-js-std" ,
"tests/rustdoc-json" ,
2021-12-12 00:51:07 +00:00
# Internal tooling
"src/etc/htmldocck.py" ,
"src/tools/jsondocck" ,
2022-08-23 13:49:37 +00:00
"src/tools/jsondoclint" ,
2021-12-12 00:51:07 +00:00
"src/tools/rustdoc-gui" ,
"src/tools/rustdoc-js" ,
"src/tools/rustdoc-themes" ,
]
2022-02-12 16:47:00 +00:00
exclude_labels = [
"T-*" ,
]
2021-12-12 00:51:07 +00:00
2022-08-19 16:31:32 +00:00
[ autolabel . "A-rustdoc-json" ]
trigger_files = [
"src/librustdoc/json/" ,
"src/rustdoc-json-types" ,
2023-01-05 08:45:44 +00:00
"tests/rustdoc-json" ,
2022-08-19 16:31:32 +00:00
"src/tools/jsondocck" ,
2022-08-23 13:49:37 +00:00
"src/tools/jsondoclint" ,
2022-08-19 16:31:32 +00:00
]
2021-12-12 02:03:52 +00:00
[ autolabel . "T-compiler" ]
trigger_files = [
# Source code
"compiler" ,
# Tests
2023-01-05 08:45:44 +00:00
"tests/ui" ,
2021-12-12 02:03:52 +00:00
]
2022-02-12 16:47:00 +00:00
exclude_labels = [
"T-*" ,
]
2021-12-12 02:03:52 +00:00
2022-04-12 17:48:56 +00:00
[ autolabel . "T-libs" ]
trigger_files = [
"library/alloc" ,
"library/core" ,
"library/panic_abort" ,
"library/panic_unwind" ,
"library/std" ,
"library/stdarch" ,
"library/term" ,
"library/test" ,
]
exclude_labels = [
"T-*" ,
]
2023-08-17 10:16:20 +00:00
[ autolabel . "O-android" ]
trigger_files = [
"library/std/src/os/android"
]
[ autolabel . "O-fuchsia" ]
trigger_files = [
"library/std/src/os/fuchsia"
]
[ autolabel . "O-hermit" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/hermit" ,
2023-08-17 10:16:20 +00:00
"library/std/src/os/hermit"
]
[ autolabel . "O-ios" ]
trigger_files = [
"library/std/src/os/ios"
]
[ autolabel . "O-itron" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/itron"
2023-08-17 10:16:20 +00:00
]
[ autolabel . "O-linux" ]
trigger_files = [
"library/std/src/os/linux"
]
[ autolabel . "O-macos" ]
trigger_files = [
"library/std/src/os/macos"
]
[ autolabel . "O-netbsd" ]
trigger_files = [
"library/std/src/os/netbsd"
]
[ autolabel . "O-redox" ]
trigger_files = [
"library/std/src/os/redox"
]
[ autolabel . "O-SGX" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/sgx" ,
2023-08-17 10:16:20 +00:00
"library/std/src/os/fortanix_sgx"
]
[ autolabel . "O-solaris" ]
trigger_files = [
"library/std/src/os/solaris"
]
[ autolabel . "O-solid" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/solid" ,
2023-08-17 10:16:20 +00:00
"library/std/src/os/solid"
]
[ autolabel . "O-unix" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/unix" ,
2023-08-17 10:16:20 +00:00
"library/std/src/os/unix"
]
[ autolabel . "O-wasi" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/wasi" ,
2023-08-17 10:16:20 +00:00
"library/std/src/os/wasi"
]
[ autolabel . "O-wasm" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/wasm" ,
2023-08-17 10:16:20 +00:00
"library/std/src/os/wasm"
]
[ autolabel . "O-watchos" ]
trigger_files = [
"library/std/src/os/watchos"
]
[ autolabel . "O-windows" ]
trigger_files = [
2024-01-11 23:06:39 +00:00
"library/std/src/sys/pal/windows" ,
2023-08-17 10:16:20 +00:00
"library/std/src/os/windows"
]
2023-01-19 08:15:57 +00:00
[ autolabel . "T-bootstrap" ]
2022-07-10 22:32:37 +00:00
trigger_files = [
"x.py" ,
2022-10-13 15:38:30 +00:00
"x" ,
"x.ps1" ,
2022-07-10 22:32:37 +00:00
"src/bootstrap" ,
"src/tools/rust-installer" ,
2022-11-13 14:31:49 +00:00
"src/tools/x" ,
2022-10-18 16:20:49 +00:00
"configure" ,
"Cargo.toml" ,
2023-03-11 22:10:00 +00:00
"config.example.toml" ,
2023-01-23 18:34:10 +00:00
"src/stage0.json" ,
"src/tools/compiletest" ,
"src/tools/tidy" ,
2023-05-20 11:42:37 +00:00
"src/tools/rustdoc-gui-test" ,
2022-07-10 22:32:37 +00:00
]
[ autolabel . "T-infra" ]
trigger_files = [
"src/ci" ,
"src/tools/bump-stage0" ,
2023-01-23 18:34:10 +00:00
"src/tools/cargotest" ,
"src/tools/tier-check" ,
2022-07-10 22:32:37 +00:00
]
2022-09-24 16:25:38 +00:00
[ autolabel . "T-style" ]
trigger_files = [
"src/doc/style-guide" ,
]
2022-08-12 08:14:40 +00:00
[ autolabel . "A-translation" ]
trigger_files = [
"compiler/rustc_error_messages" ,
"compiler/rustc_errors/src/translation.rs" ,
"compiler/rustc_macros/src/diagnostics"
]
2022-09-02 01:49:12 +00:00
[ autolabel . "A-query-system" ]
trigger_files = [
"compiler/rustc_query_system" ,
"compiler/rustc_query_impl" ,
"compiler/rustc_macros/src/query.rs"
]
2022-10-18 16:20:49 +00:00
[ autolabel . "A-testsuite" ]
trigger_files = [
"src/ci" ,
"src/tools/compiletest" ,
"src/tools/cargotest" ,
"src/tools/tidy" ,
"src/tools/remote-test-server" ,
"src/tools/remote-test-client" ,
"src/tools/tier-check"
]
[ autolabel . "A-meta" ]
trigger_files = [
"triagebot.toml" ,
"rustfmt.toml" ,
"LICENSES" ,
"README.md" ,
"CONTRIBUTING.md" ,
".reuse" ,
".mailmap" ,
".git-blame-ignore-revs" ,
".editorconfig"
]
[ autolabel . "T-release" ]
trigger_files = [
"RELEASES.md" ,
"src/stage0.json" ,
"src/version"
]
2022-10-24 16:16:45 +00:00
[ autolabel . "S-waiting-on-review" ]
new_pr = true
2023-07-06 15:57:03 +00:00
[ autolabel . "needs-triage" ]
new_issue = true
2023-07-09 22:39:06 +00:00
exclude_labels = [
2024-01-19 07:29:42 +00:00
"C-tracking-issue" ,
"A-diagnostics" ,
2023-07-09 22:39:06 +00:00
]
2023-07-06 15:57:03 +00:00
2023-01-11 12:02:14 +00:00
[ autolabel . "WG-trait-system-refactor" ]
trigger_files = [
2023-02-03 02:29:52 +00:00
"compiler/rustc_trait_selection/src/solve" ,
2023-07-14 08:32:27 +00:00
"compiler/rustc_middle/src/traits/solve"
2023-01-11 12:02:14 +00:00
]
2024-03-13 10:17:47 +00:00
[ autolabel . "PG-exploit-mitigations" ]
trigger_files = [
"compiler/rustc_symbol_mangling/src/typeid" ,
"src/doc/rustc/src/exploit-mitigations.md" ,
"src/doc/unstable-book/src/compiler-flags/branch-protection.md" ,
"src/doc/unstable-book/src/compiler-flags/cf-protection.md" ,
"src/doc/unstable-book/src/compiler-flags/control-flow-guard.md" ,
"src/doc/unstable-book/src/compiler-flags/sanitizer.md" ,
"src/doc/unstable-book/src/language-features/cfg-sanitize.md" ,
"src/doc/unstable-book/src/language-features/cfi-encoding.md" ,
"src/doc/unstable-book/src/language-features/no-sanitize.md" ,
"tests/codegen/sanitizer" ,
"tests/codegen/split-lto-unit.rs" ,
"tests/codegen/stack-probes-inline.rs" ,
"tests/codegen/stack-protector.rs" ,
"tests/ui/sanitizer" ,
"tests/ui/stack-protector"
]
2020-06-11 17:21:09 +00:00
[ notify-zulip . "I-prioritize" ]
2020-06-24 15:32:44 +00:00
zulip_stream = 245100 # #t-compiler/wg-prioritization/alerts
2020-12-20 22:08:55 +00:00
topic = "#{number} {title}"
2020-06-24 13:33:08 +00:00
message_on_add = "" " \
2020-06-24 15:36:17 +00:00
@ * WG-prioritization / alerts * issue #{number} has been requested for prioritization.
2020-06-24 13:33:08 +00:00
2020-07-20 19:29:58 +00:00
# [Procedure](https://forge.rust-lang.org/compiler/prioritization/procedure.html#assign-priority-to-unprioritized-issues-with-i-prioritize-label)
2020-06-24 13:33:08 +00:00
- Priority ?
- Regression ?
- Notify people / groups ?
- Needs ` I-nominated ` ?
"" "
2020-06-11 17:21:09 +00:00
message_on_remove = "Issue #{number}'s prioritization request has been removed."
2020-12-31 01:22:10 +00:00
message_on_close = "Issue #{number} has been closed while requested for prioritization."
message_on_reopen = "Issue #{number} has been reopened."
2020-09-08 08:43:52 +00:00
2022-06-03 14:08:17 +00:00
[ notify-zulip . "I-types-nominated" ]
zulip_stream = 326866 # #T-types/nominated
topic = "#{number}: {title}"
message_on_add = "" " \
@ * T-types * issue #{number} "{title}" has been nominated for team discussion.
"" "
message_on_remove = "Issue #{number}'s nomination has been removed. Thanks all for participating!"
message_on_close = "Issue #{number} has been closed. Thanks for participating!"
message_on_reopen = "Issue #{number} has been reopened. Pinging @*T-types*."
2021-07-26 09:38:46 +00:00
[ notify-zulip . "A-edition-2021" ]
required_labels = [ "C-bug" ]
2021-07-26 08:31:28 +00:00
zulip_stream = 268952 # #edition 2021
topic = "Edition Bugs"
message_on_add = "" " \
Issue #{number} "{title}" has been added.
"" "
2023-07-28 04:07:38 +00:00
[ no-merges ]
2023-11-04 02:40:21 +00:00
exclude_titles = [ "Rollup of" , "subtree update" , "Subtree update" ]
2023-07-28 04:07:38 +00:00
labels = [ "has-merge-commits" , "S-waiting-on-author" ]
2020-09-08 08:43:52 +00:00
[ github-releases ]
format = "rustc"
project-name = "Rust"
changelog-path = "RELEASES.md"
changelog-branch = "master"
2021-07-18 19:52:18 +00:00
[ shortcut ]
2022-06-27 15:57:06 +00:00
2024-02-20 10:25:06 +00:00
[ mentions . "triagebot.toml" ]
message = "`triagebot.toml` has been modified, there may have been changes to the review queue."
cc = [ "@davidtwco" , "@wesleywiser" ]
2022-06-27 15:57:06 +00:00
[ mentions . "compiler/rustc_codegen_cranelift" ]
cc = [ "@bjorn3" ]
[ mentions . "compiler/rustc_codegen_gcc" ]
2023-12-07 14:12:06 +00:00
cc = [ "@antoyo" , "@GuillaumeGomez" ]
2022-06-27 15:57:06 +00:00
[ mentions . "compiler/rustc_const_eval/src/interpret" ]
message = "Some changes occurred to the CTFE / Miri engine"
cc = [ "@rust-lang/miri" ]
[ mentions . "compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs" ]
message = "Some changes occurred in need_type_info.rs"
cc = [ "@lcnr" ]
2023-12-14 15:56:05 +00:00
[ mentions . "compiler/rustc_middle/src/ty/relate.rs" ]
message = "Type relation code was changed"
cc = [ "@compiler-errors" , "@lcnr" ]
[ mentions . "compiler/rustc_infer/src/infer/relate" ]
message = "Type relation code was changed"
cc = [ "@compiler-errors" , "@lcnr" ]
2022-06-27 15:57:06 +00:00
[ mentions . "compiler/rustc_middle/src/mir/interpret" ]
message = "Some changes occurred to the CTFE / Miri engine"
cc = [ "@rust-lang/miri" ]
[ mentions . "compiler/rustc_mir_transform/src/" ]
message = "Some changes occurred to MIR optimizations"
2022-06-28 12:14:42 +00:00
cc = [ "@rust-lang/wg-mir-opt" ]
2022-06-27 15:57:06 +00:00
[ mentions . "compiler/rustc_trait_selection/src/traits/const_evaluatable.rs" ]
2022-12-06 16:45:11 +00:00
message = "Some changes occurred in `const_evaluatable.rs`"
2022-12-06 16:33:19 +00:00
cc = [ "@BoxyUwU" ]
[ mentions . "compiler/rustc_middle/src/ty/abstract_const.rs" ]
2023-04-10 19:02:49 +00:00
message = "Some changes occurred in `abstract_const.rs`"
2022-12-06 16:33:19 +00:00
cc = [ "@BoxyUwU" ]
[ mentions . "compiler/rustc_ty_utils/src/consts.rs" ]
2023-04-10 19:02:49 +00:00
message = "Some changes occurred in `rustc_ty_utils::consts.rs`"
2022-12-06 16:33:19 +00:00
cc = [ "@BoxyUwU" ]
2022-06-27 15:57:06 +00:00
2022-12-23 23:28:02 +00:00
[ mentions . "compiler/rustc_trait_selection/src/solve/" ]
2022-12-04 03:19:10 +00:00
message = "Some changes occurred to the core trait solver"
2023-01-11 12:02:14 +00:00
cc = [ "@rust-lang/initiative-trait-system-refactor" ]
2022-12-04 03:19:10 +00:00
2022-11-25 13:26:10 +00:00
[ mentions . "compiler/rustc_trait_selection/src/traits/engine.rs" ]
message = "" "
Some changes occurred in engine . rs , potentially modifying the public API \
of ` ObligationCtxt ` .
"" "
2023-01-11 00:32:52 +00:00
cc = [ "@lcnr" , "@compiler-errors" ]
2022-11-25 13:26:10 +00:00
2024-03-14 14:07:34 +00:00
[ mentions . "compiler/rustc_hir_analysis/src/hir_ty_lowering" ]
message = "HIR ty lowering was modified"
cc = [ "@fmease" ]
Stop using `String` for error codes.
Error codes are integers, but `String` is used everywhere to represent
them. Gross!
This commit introduces `ErrCode`, an integral newtype for error codes,
replacing `String`. It also introduces a constant for every error code,
e.g. `E0123`, and removes the `error_code!` macro. The constants are
imported wherever used with `use rustc_errors::codes::*`.
With the old code, we have three different ways to specify an error code
at a use point:
```
error_code!(E0123) // macro call
struct_span_code_err!(dcx, span, E0123, "msg"); // bare ident arg to macro call
\#[diag(name, code = "E0123")] // string
struct Diag;
```
With the new code, they all use the `E0123` constant.
```
E0123 // constant
struct_span_code_err!(dcx, span, E0123, "msg"); // constant
\#[diag(name, code = E0123)] // constant
struct Diag;
```
The commit also changes the structure of the error code definitions:
- `rustc_error_codes` now just defines a higher-order macro listing the
used error codes and nothing else.
- Because that's now the only thing in the `rustc_error_codes` crate, I
moved it into the `lib.rs` file and removed the `error_codes.rs` file.
- `rustc_errors` uses that macro to define everything, e.g. the error
code constants and the `DIAGNOSTIC_TABLES`. This is in its new
`codes.rs` file.
2024-01-13 23:57:07 +00:00
[ mentions . "compiler/rustc_error_codes/src/lib.rs" ]
2022-06-27 15:57:06 +00:00
message = "Some changes occurred in diagnostic error codes"
cc = [ "@GuillaumeGomez" ]
2024-02-16 17:26:34 +00:00
[ mentions . "compiler/rustc_mir_build/src/build/matches" ]
message = "Some changes occurred in match lowering"
cc = [ "@Nadrieril" ]
2023-04-30 20:43:46 +00:00
[ mentions . "compiler/rustc_mir_build/src/thir/pattern" ]
2024-02-16 17:26:34 +00:00
message = "Some changes occurred in match checking"
2023-04-30 20:43:46 +00:00
cc = [ "@Nadrieril" ]
2023-12-11 10:02:24 +00:00
[ mentions . "compiler/rustc_pattern_analysis" ]
2024-02-16 17:26:34 +00:00
message = "Some changes occurred in exhaustiveness checking"
2023-12-11 10:02:24 +00:00
cc = [ "@Nadrieril" ]
2024-03-16 22:40:49 +00:00
[ mentions . "compiler/rustc_lint/src/context/diagnostics/check_cfg.rs" ]
cc = [ "@Urgau" ]
2023-12-19 15:16:02 +00:00
[ mentions . "library/core/src/intrinsics/simd.rs" ]
message = "" "
2023-12-26 11:42:40 +00:00
Some changes occurred to the platform-builtins intrinsics . Make sure the
LLVM backend as well as portable-simd gets adapted for the changes .
2023-12-19 15:16:02 +00:00
"" "
cc = [ "@antoyo" , "@GuillaumeGomez" , "@bjorn3" , "@calebzulawski" , "@programmerjake" ]
2023-06-01 02:54:01 +00:00
[ mentions . "library/portable-simd" ]
message = "" "
Portable SIMD is developed in its own repository . If possible , consider \
making this change to [ rust-lang / portable-simd ] ( https : / / github . com / rust-lang / portable-simd ) \
instead .
"" "
2023-06-08 05:26:31 +00:00
cc = [ "@calebzulawski" , "@programmerjake" ]
2023-06-01 02:54:01 +00:00
2022-06-27 15:57:06 +00:00
[ mentions . "src/librustdoc/clean/types.rs" ]
cc = [ "@camelid" ]
[ mentions . "src/librustdoc/html/static" ]
message = "Some changes occurred in HTML/CSS/JS."
cc = [
"@GuillaumeGomez" ,
"@jsha" ,
]
[ mentions . "src/librustdoc/html/static/css/themes" ]
message = "Some changes occurred in HTML/CSS themes."
cc = [ "@GuillaumeGomez" ]
2023-06-01 10:57:10 +00:00
[ mentions . "tests/rustdoc-gui/" ]
message = "Some changes occurred in GUI tests."
cc = [ "@GuillaumeGomez" ]
2024-03-16 19:15:45 +00:00
[ mentions . "tests/run-make/" ]
message = "Some changes occurred in run-make tests."
cc = [ "@jieyouxu" ]
2022-06-27 15:57:06 +00:00
[ mentions . "src/librustdoc/html/static/css/themes/ayu.css" ]
message = "A change occurred in the Ayu theme."
cc = [ "@Cldfire" ]
[ mentions . "src/rustdoc-json-types" ]
message = "" "
2022-06-28 18:38:07 +00:00
rustdoc-json-types is a * * public * * ( although nightly-only ) API . \
If possible , consider changing ` src / librustdoc / json / conversions . rs ` ; \
2022-06-27 15:57:06 +00:00
otherwise , make sure you bump the ` FORMAT_VERSION ` constant .
"" "
cc = [
"@CraftSpider" ,
"@aDotInTheVoid" ,
2022-07-29 20:04:06 +00:00
"@Enselic" ,
2022-09-11 02:04:57 +00:00
"@obi1kenobi" ,
2022-06-27 15:57:06 +00:00
]
[ mentions . "src/tools/cargo" ]
cc = [ "@ehuss" ]
[ mentions . "src/tools/clippy" ]
cc = [ "@rust-lang/clippy" ]
2024-03-16 19:15:45 +00:00
[ mentions . "src/tools/compiletest" ]
cc = [ "@jieyouxu" ]
2022-06-27 15:57:06 +00:00
[ mentions . "src/tools/miri" ]
2022-09-19 19:08:02 +00:00
message = "The Miri subtree was changed"
2022-06-27 15:57:06 +00:00
cc = [ "@rust-lang/miri" ]
2024-03-16 19:15:45 +00:00
[ mentions . "src/tools/run-make-support" ]
message = "The run-make-support library was changed"
cc = [ "@jieyouxu" ]
2022-11-27 12:28:48 +00:00
[ mentions . "src/tools/rust-analyzer" ]
2023-11-24 17:12:05 +00:00
message = "" "
rust-analyzer is developed in its own repository . If possible , consider making \
this change to [ rust-lang / rust-analyzer ] instead .
[ rust-lang / rust-analyzer ] : https : / / github . com / rust-lang / rust-analyzer
"" "
2023-03-10 10:22:27 +00:00
cc = [ "@rust-lang/rust-analyzer" ]
2022-11-27 12:28:48 +00:00
2022-06-27 15:57:06 +00:00
[ mentions . "src/tools/rustfmt" ]
cc = [ "@rust-lang/rustfmt" ]
2022-06-29 00:05:23 +00:00
[ mentions . "compiler/rustc_middle/src/mir/syntax.rs" ]
message = "This PR changes MIR"
2022-07-14 12:24:36 +00:00
cc = [ "@oli-obk" , "@RalfJung" , "@JakobDegen" , "@davidtwco" , "@celinval" , "@vakaras" ]
2022-08-10 16:13:18 +00:00
[ mentions . "compiler/rustc_error_messages" ]
message = "`rustc_error_messages` was changed"
2023-12-15 15:15:15 +00:00
cc = [ "@davidtwco" , "@compiler-errors" , "@TaKO8Ki" ]
2022-08-10 16:13:18 +00:00
[ mentions . "compiler/rustc_errors/src/translation.rs" ]
message = "`rustc_errors::translation` was changed"
2023-12-15 15:15:15 +00:00
cc = [ "@davidtwco" , "@compiler-errors" , "@TaKO8Ki" ]
2022-08-10 16:13:18 +00:00
[ mentions . "compiler/rustc_macros/src/diagnostics" ]
message = "`rustc_macros::diagnostics` was changed"
2023-12-15 15:15:15 +00:00
cc = [ "@davidtwco" , "@compiler-errors" , "@TaKO8Ki" ]
2022-10-24 16:16:45 +00:00
2023-09-14 15:50:11 +00:00
[ mentions . "compiler/stable_mir" ]
message = "This PR changes Stable MIR"
2024-03-22 15:28:34 +00:00
cc = [ "@oli-obk" , "@celinval" , "@ouz-a" ]
2023-09-14 15:50:11 +00:00
2022-10-26 23:45:24 +00:00
[ mentions . "compiler/rustc_target/src/spec" ]
message = "" "
These commits modify * * compiler targets * * .
( See the [ Target Tier Policy ] ( https : / / doc . rust-lang . org / nightly / rustc / target-tier-policy . html ) . )
"" "
2023-01-26 01:58:22 +00:00
[ mentions . "src/doc/style-guide" ]
cc = [ "@rust-lang/style" ]
2023-02-03 10:42:37 +00:00
[ mentions . "Cargo.lock" ]
message = "" "
2023-05-02 22:25:02 +00:00
These commits modify the ` Cargo . lock ` file . Unintentional changes to ` Cargo . lock ` can be introduced when switching branches and rebasing PRs .
2023-02-03 10:42:37 +00:00
2023-05-02 22:25:02 +00:00
If this was unintentional then you should revert the changes before this PR is merged .
Otherwise , you can ignore this comment .
2023-02-03 10:42:37 +00:00
"" "
2023-02-14 06:25:46 +00:00
[ mentions . "src/tools/x" ]
message = "`src/tools/x` was changed. Bump version of Cargo.toml in `src/tools/x` so tidy will suggest installing the new version."
2023-02-14 05:56:19 +00:00
2023-08-22 15:15:00 +00:00
[ mentions . "src/tools/tidy/src/deps.rs" ]
2023-11-08 10:19:32 +00:00
message = "The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging."
2023-08-22 15:15:00 +00:00
cc = [ "@davidtwco" , "@wesleywiser" ]
2023-10-19 05:39:28 +00:00
[ mentions . "src/bootstrap/src/core/config" ]
2023-11-23 21:18:57 +00:00
message = "" "
This PR modifies ` src / bootstrap / src / core / config ` .
2023-12-18 12:54:10 +00:00
If appropriate , please update ` CONFIG_CHANGE_HISTORY ` in ` src / bootstrap / src / utils / change_tracker . rs ` .
2023-11-23 21:18:57 +00:00
"" "
2023-10-19 05:39:55 +00:00
[ mentions . "src/bootstrap/defaults" ]
2023-11-23 21:18:57 +00:00
message = "" "
This PR modifies ` src / bootstrap / defaults ` .
2023-12-18 12:54:10 +00:00
If appropriate , please update ` CONFIG_CHANGE_HISTORY ` in ` src / bootstrap / src / utils / change_tracker . rs ` .
2023-11-23 21:18:57 +00:00
"" "
2023-10-01 13:55:46 +00:00
[ mentions . "config.example.toml" ]
2023-11-23 21:18:57 +00:00
message = "" "
This PR modifies ` config . example . toml ` .
2023-12-18 12:54:10 +00:00
If appropriate , please update ` CONFIG_CHANGE_HISTORY ` in ` src / bootstrap / src / utils / change_tracker . rs ` .
2023-11-23 21:18:57 +00:00
"" "
2023-10-01 13:55:46 +00:00
2023-10-19 05:39:28 +00:00
[ mentions . "src/bootstrap/src/core/build_steps/llvm.rs" ]
2023-06-14 14:01:19 +00:00
message = "This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp."
2023-05-02 22:22:05 +00:00
[ mentions . "tests/ui/deriving/deriving-all-codegen.stdout" ]
message = "Changes to the code generated for builtin derived traits."
cc = [ "@nnethercote" ]
[ mentions . "tests/ui/stats/hir-stats.stderr" ]
message = "Changes to the size of AST and/or HIR nodes."
cc = [ "@nnethercote" ]
2024-03-13 10:17:47 +00:00
[ mentions . "compiler/rustc_symbol_mangling/src/typeid" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/rustc/src/exploit-mitigations.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/unstable-book/src/compiler-flags/branch-protection.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/unstable-book/src/compiler-flags/cf-protection.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/unstable-book/src/compiler-flags/control-flow-guard.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/unstable-book/src/compiler-flags/sanitizer.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/unstable-book/src/language-features/cfg-sanitize.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/unstable-book/src/language-features/cfi-encoding.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "src/doc/unstable-book/src/language-features/no-sanitize.md" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
2024-03-16 22:40:49 +00:00
[ mentions . "src/doc/unstable-book/src/compiler-flags/check-cfg.md" ]
cc = [ "@Urgau" ]
2024-03-13 10:17:47 +00:00
[ mentions . "tests/codegen/sanitizer" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "tests/codegen/split-lto-unit.rs" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "tests/codegen/stack-probes-inline.rs" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "tests/codegen/stack-protector.rs" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "tests/ui/sanitizer" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
[ mentions . "tests/ui/stack-protector" ]
cc = [ "@rust-lang/project-exploit-mitigations" , "@rcvalle" ]
2024-03-16 22:40:49 +00:00
[ mentions . "tests/ui/check-cfg" ]
cc = [ "@Urgau" ]
2024-03-17 02:46:54 +00:00
[ mentions . "compiler/rustc_middle/src/mir/coverage.rs" ]
message = "Some changes occurred in coverage instrumentation."
cc = [ "@Zalathar" ]
[ mentions . "compiler/rustc_mir_build/src/build/coverageinfo.rs" ]
message = "Some changes occurred in coverage instrumentation."
cc = [ "@Zalathar" ]
[ mentions . "compiler/rustc_mir_transform/src/coverage" ]
message = "Some changes occurred in coverage instrumentation."
cc = [ "@Zalathar" ]
[ mentions . "compiler/rustc_codegen_llvm/src/coverageinfo" ]
message = "Some changes occurred in coverage instrumentation."
cc = [ "@Zalathar" ]
[ mentions . "compiler/rustc_codegen_ssa/src/mir/coverageinfo.rs" ]
message = "Some changes occurred in coverage instrumentation."
cc = [ "@Zalathar" ]
[ mentions . "tests/coverage" ]
message = "Some changes occurred in coverage tests."
cc = [ "@Zalathar" ]
2022-10-24 16:16:45 +00:00
[ assign ]
warn_non_default_branch = true
2023-03-30 17:36:40 +00:00
contributing_url = "https://rustc-dev-guide.rust-lang.org/getting-started.html"
2024-01-17 21:02:14 +00:00
users_on_vacation = [ "jyn514" ]
2022-10-24 16:16:45 +00:00
[ assign . adhoc_groups ]
compiler-team = [
"@cjgillot" ,
2023-11-05 15:09:51 +00:00
"@compiler-errors" ,
2022-10-24 16:16:45 +00:00
"@petrochenkov" ,
"@davidtwco" ,
2024-01-22 19:02:35 +00:00
"@estebank" ,
2024-02-13 17:51:47 +00:00
"@lcnr" ,
2022-10-24 16:16:45 +00:00
"@oli-obk" ,
2024-02-01 14:51:29 +00:00
"@pnkfelix" ,
2022-10-24 16:16:45 +00:00
"@wesleywiser" ,
2024-01-24 09:13:28 +00:00
"@michaelwoerister" ,
2022-10-24 16:16:45 +00:00
]
compiler-team-contributors = [
2023-10-26 02:52:45 +00:00
"@TaKO8Ki" ,
2024-02-16 17:31:13 +00:00
"@Nadrieril" ,
2024-01-21 22:52:34 +00:00
"@nnethercote" ,
2024-01-26 17:26:36 +00:00
"@fmease" ,
2024-02-29 13:38:53 +00:00
"@fee1-dead" ,
2022-10-24 16:16:45 +00:00
]
compiler = [
"compiler-team" ,
"compiler-team-contributors" ,
]
libs = [
2023-01-03 17:47:03 +00:00
"@cuviper" ,
2022-10-24 16:16:45 +00:00
"@Mark-Simulacrum" ,
2024-02-28 16:13:28 +00:00
"@m-ou-se" ,
"@Amanieu" ,
"@Nilstrieb" ,
"@workingjubilee" ,
"@joboet" ,
"@jhpratt" ,
2022-10-24 16:16:45 +00:00
]
bootstrap = [
"@Mark-Simulacrum" ,
2023-01-19 08:15:57 +00:00
"@albertlarsan68" ,
2023-08-27 03:26:02 +00:00
"@onur-ozkan" ,
2023-05-15 16:48:15 +00:00
"@clubby789" ,
2022-10-24 16:16:45 +00:00
]
infra-ci = [
"@Mark-Simulacrum" ,
2023-09-18 14:13:49 +00:00
"@Kobzol" ,
2022-10-24 16:16:45 +00:00
]
rustdoc = [
"@GuillaumeGomez" ,
"@notriddle" ,
2023-08-29 13:30:15 +00:00
"@fmease" ,
2022-10-24 16:16:45 +00:00
]
docs = [
"@ehuss" ,
"@GuillaumeGomez" ,
"@JohnTitor" ,
]
query-system = [
"@cjgillot" ,
]
incremental = [
"@michaelwoerister" ,
"@wesleywiser" ,
]
diagnostics = [
"@compiler-errors" ,
"@davidtwco" ,
2024-01-22 19:02:35 +00:00
"@estebank" ,
2022-10-24 16:16:45 +00:00
"@oli-obk" ,
2023-10-26 02:52:45 +00:00
"@TaKO8Ki" ,
2022-10-24 16:16:45 +00:00
]
parser = [
2023-02-16 22:52:41 +00:00
"@compiler-errors" ,
2022-10-24 16:16:45 +00:00
"@davidtwco" ,
2024-01-22 19:02:35 +00:00
"@estebank" ,
2022-10-24 16:16:45 +00:00
"@nnethercote" ,
"@petrochenkov" ,
2024-03-22 15:28:34 +00:00
"@spastorino" ,
2022-10-24 16:16:45 +00:00
]
lexer = [
"@nnethercote" ,
"@petrochenkov" ,
2024-01-22 19:02:35 +00:00
"@estebank" ,
2022-10-24 16:16:45 +00:00
]
2024-01-21 22:51:12 +00:00
arena = [
"@nnethercote" ,
2024-03-22 15:28:34 +00:00
"@spastorino" ,
2024-01-21 22:51:12 +00:00
]
2022-10-24 16:16:45 +00:00
mir = [
"@davidtwco" ,
"@oli-obk" ,
2024-01-29 10:02:59 +00:00
"@matthewjasper"
2022-10-24 16:16:45 +00:00
]
mir-opt = [
"@oli-obk" ,
"@wesleywiser" ,
]
types = [
"@compiler-errors" ,
"@jackh726" ,
"@lcnr" ,
"@oli-obk" ,
"@spastorino" ,
2023-06-27 22:52:10 +00:00
"@BoxyUwU" ,
2022-10-24 16:16:45 +00:00
]
borrowck = [
"@davidtwco" ,
"@pnkfelix" ,
2024-01-29 10:02:59 +00:00
"@matthewjasper"
2022-10-24 16:16:45 +00:00
]
ast_lowering = [
2023-02-16 22:52:41 +00:00
"@compiler-errors" ,
2024-01-22 19:02:35 +00:00
"@estebank" ,
2022-10-24 16:16:45 +00:00
"@spastorino" ,
]
2024-01-24 09:13:28 +00:00
debuginfo = [
"@michaelwoerister" ,
2024-01-24 09:40:35 +00:00
"@davidtwco"
2024-01-24 09:13:28 +00:00
]
2022-10-24 16:16:45 +00:00
fallback = [
"@Mark-Simulacrum"
]
2023-01-26 01:58:22 +00:00
style-team = [
"@calebcartwright" ,
"@compiler-errors" ,
"@joshtriplett" ,
"@yaahc" ,
]
2024-01-10 19:09:27 +00:00
project-const-traits = [
"@compiler-errors" ,
"@fee1-dead" ,
"@fmease" ,
"@oli-obk" ,
]
2023-11-17 19:46:39 +00:00
project-stable-mir = [
"@celinval" ,
"@oli-obk" ,
"@spastorino" ,
"@ouz-a" ,
]
2024-03-13 10:17:47 +00:00
project-exploit-mitigations = [
"@cuviper" ,
"@rcvalle" ,
]
2022-10-24 16:16:45 +00:00
[ assign . owners ]
2024-01-24 09:13:28 +00:00
"/.github/workflows" = [ "infra-ci" ]
"/Cargo.lock" = [ "@Mark-Simulacrum" ]
"/Cargo.toml" = [ "@Mark-Simulacrum" ]
"/compiler" = [ "compiler" ]
"/compiler/rustc_arena" = [ "compiler" , "arena" ]
"/compiler/rustc_ast" = [ "compiler" , "parser" ]
"/compiler/rustc_ast_lowering" = [ "compiler" , "ast_lowering" ]
"/compiler/rustc_data_structures/src/stable_hasher.rs" = [ "compiler" , "incremental" ]
"/compiler/rustc_hir_analysis" = [ "compiler" , "types" ]
"/compiler/rustc_incremental" = [ "compiler" , "incremental" ]
2024-01-29 10:02:59 +00:00
"/compiler/rustc_borrowck" = [ "compiler" , "borrowck" ]
2024-01-24 09:13:28 +00:00
"/compiler/rustc_lexer" = [ "compiler" , "lexer" ]
"/compiler/rustc_llvm" = [ "@cuviper" ]
"/compiler/rustc_codegen_llvm/src/debuginfo" = [ "compiler" , "debuginfo" ]
"/compiler/rustc_middle/src/mir" = [ "compiler" , "mir" ]
"/compiler/rustc_middle/src/traits" = [ "compiler" , "types" ]
"/compiler/rustc_middle/src/ty" = [ "compiler" , "types" ]
"/compiler/rustc_const_eval/src/interpret" = [ "compiler" , "mir" ]
"/compiler/rustc_const_eval/src/transform" = [ "compiler" , "mir-opt" ]
"/compiler/rustc_mir_build/src/build" = [ "compiler" , "mir" ]
2024-01-29 10:02:59 +00:00
"/compiler/rustc_mir_transform" = [ "compiler" , "mir" , "mir-opt" ]
2024-01-24 09:13:28 +00:00
"/compiler/rustc_smir" = [ "project-stable-mir" ]
"/compiler/rustc_parse" = [ "compiler" , "parser" ]
"/compiler/rustc_parse/src/lexer" = [ "compiler" , "lexer" ]
"/compiler/rustc_query_impl" = [ "compiler" , "query-system" ]
"/compiler/rustc_query_system" = [ "compiler" , "query-system" ]
"/compiler/rustc_query_system/src/dep_graph" = [ "compiler" , "incremental" , "query-system" ]
"/compiler/rustc_query_system/src/ich" = [ "compiler" , "incremental" , "query-system" ]
"/compiler/rustc_trait_selection" = [ "compiler" , "types" ]
"/compiler/rustc_traits" = [ "compiler" , "types" ]
"/compiler/rustc_type_ir" = [ "compiler" , "types" ]
"/compiler/stable_mir" = [ "project-stable-mir" ]
"/library/alloc" = [ "libs" ]
2024-02-28 16:13:28 +00:00
"/library/core" = [ "libs" , "@scottmcm" ]
2024-01-24 09:13:28 +00:00
"/library/panic_abort" = [ "libs" ]
"/library/panic_unwind" = [ "libs" ]
"/library/proc_macro" = [ "@petrochenkov" ]
2024-02-11 12:12:35 +00:00
"/library/std" = [ "libs" , "@ChrisDenton" ]
2024-01-26 20:31:46 +00:00
"/library/std/src/sys/pal/windows" = [ "@ChrisDenton" ]
2024-01-24 09:13:28 +00:00
"/library/stdarch" = [ "libs" ]
"/library/test" = [ "libs" ]
"/src/bootstrap" = [ "bootstrap" ]
"/src/ci" = [ "infra-ci" ]
"/src/doc" = [ "docs" ]
"/src/doc/book" = [ "@ehuss" ]
"/src/doc/edition-guide" = [ "@ehuss" ]
"/src/doc/embedded-book" = [ "@ehuss" ]
"/src/doc/nomicon" = [ "@ehuss" ]
"/src/doc/reference" = [ "@ehuss" ]
"/src/doc/rust-by-example" = [ "@ehuss" ]
"/src/doc/rustc-dev-guide" = [ "@ehuss" ]
"/src/doc/rustdoc" = [ "rustdoc" ]
"/src/doc/style-guide" = [ "style-team" ]
"/src/etc" = [ "@Mark-Simulacrum" ]
"/src/librustdoc" = [ "rustdoc" ]
"/src/llvm-project" = [ "@cuviper" ]
"/src/rustdoc-json-types" = [ "rustdoc" ]
"/src/stage0.json" = [ "bootstrap" ]
"/tests/ui" = [ "compiler" ]
2024-02-11 01:56:47 +00:00
"/src/tools/cargo" = [ "@ehuss" ]
2024-01-24 09:13:28 +00:00
"/src/tools/compiletest" = [ "bootstrap" , "@wesleywiser" , "@oli-obk" , "@compiler-errors" ]
"/src/tools/linkchecker" = [ "@ehuss" ]
"/src/tools/rust-installer" = [ "bootstrap" ]
"/src/tools/rustbook" = [ "@ehuss" ]
"/src/tools/rustdoc" = [ "rustdoc" ]
"/src/tools/rustdoc-js" = [ "rustdoc" ]
"/src/tools/rustdoc-themes" = [ "rustdoc" ]
"/src/tools/tidy" = [ "bootstrap" ]
"/src/tools/x" = [ "bootstrap" ]
"/src/tools/rustdoc-gui-test" = [ "bootstrap" , "@onur-ozkan" ]
2024-03-12 12:59:19 +00:00
# Enable tracking of PR review assignment
# Documentation at: https://forge.rust-lang.org/triagebot/pr-assignment-tracking.html
[ pr-tracking ]