2013-08-08 18:38:10 +00:00
|
|
|
//! A pass that checks to make sure private fields and methods aren't used
|
2013-08-07 07:11:34 +00:00
|
|
|
//! outside their scopes. This pass will also generate a set of exported items
|
|
|
|
//! which are available for use externally when compiled as a library.
|
2022-11-04 13:44:40 +00:00
|
|
|
use crate::ty::{DefIdTree, TyCtxt, Visibility};
|
2019-12-24 04:02:53 +00:00
|
|
|
use rustc_data_structures::fx::FxHashMap;
|
2020-11-14 15:35:31 +00:00
|
|
|
use rustc_data_structures::stable_hasher::{HashStable, StableHasher};
|
2018-12-03 00:14:35 +00:00
|
|
|
use rustc_macros::HashStable;
|
2022-04-04 20:19:25 +00:00
|
|
|
use rustc_query_system::ich::StableHashingContext;
|
2022-10-29 10:58:37 +00:00
|
|
|
use rustc_span::def_id::LocalDefId;
|
2022-10-28 10:58:21 +00:00
|
|
|
use std::hash::Hash;
|
2015-11-19 11:16:35 +00:00
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
/// Represents the levels of effective visibility an item can have.
|
2020-12-22 04:00:18 +00:00
|
|
|
///
|
2022-09-22 13:19:53 +00:00
|
|
|
/// The variants are sorted in ascending order of directness.
|
2018-12-03 00:14:35 +00:00
|
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, HashStable)]
|
2022-09-22 13:19:53 +00:00
|
|
|
pub enum Level {
|
|
|
|
/// Superset of `Reachable` including items leaked through return position `impl Trait`.
|
|
|
|
ReachableThroughImplTrait,
|
|
|
|
/// Item is either reexported, or leaked through any kind of interface.
|
|
|
|
/// For example, if function `fn f() -> T {...}` is directly public, then type `T` is publicly
|
|
|
|
/// reachable and its values can be obtained by other crates even if the type itself is not
|
|
|
|
/// nameable.
|
2015-11-19 11:16:35 +00:00
|
|
|
Reachable,
|
2022-09-22 13:19:53 +00:00
|
|
|
/// Item is accessible either directly, or with help of `use` reexports.
|
|
|
|
Reexported,
|
|
|
|
/// Item is directly accessible, without help of reexports.
|
|
|
|
Direct,
|
2015-11-19 11:16:35 +00:00
|
|
|
}
|
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
impl Level {
|
|
|
|
pub fn all_levels() -> [Level; 4] {
|
|
|
|
[Level::Direct, Level::Reexported, Level::Reachable, Level::ReachableThroughImplTrait]
|
2022-09-25 11:25:02 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Clone, Copy, PartialEq, Eq, Debug, HashStable)]
|
2022-09-12 07:57:34 +00:00
|
|
|
pub struct EffectiveVisibility {
|
2022-09-22 13:19:53 +00:00
|
|
|
direct: Visibility,
|
|
|
|
reexported: Visibility,
|
2022-09-25 11:25:02 +00:00
|
|
|
reachable: Visibility,
|
2022-09-22 13:19:53 +00:00
|
|
|
reachable_through_impl_trait: Visibility,
|
2022-09-12 07:57:34 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
impl EffectiveVisibility {
|
2022-09-22 13:19:53 +00:00
|
|
|
pub fn at_level(&self, level: Level) -> &Visibility {
|
|
|
|
match level {
|
|
|
|
Level::Direct => &self.direct,
|
|
|
|
Level::Reexported => &self.reexported,
|
|
|
|
Level::Reachable => &self.reachable,
|
|
|
|
Level::ReachableThroughImplTrait => &self.reachable_through_impl_trait,
|
2022-09-12 07:57:34 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
fn at_level_mut(&mut self, level: Level) -> &mut Visibility {
|
|
|
|
match level {
|
|
|
|
Level::Direct => &mut self.direct,
|
|
|
|
Level::Reexported => &mut self.reexported,
|
|
|
|
Level::Reachable => &mut self.reachable,
|
|
|
|
Level::ReachableThroughImplTrait => &mut self.reachable_through_impl_trait,
|
2022-09-12 07:57:34 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
pub fn is_public_at_level(&self, level: Level) -> bool {
|
|
|
|
self.at_level(level).is_public()
|
2022-09-25 11:25:02 +00:00
|
|
|
}
|
|
|
|
|
2022-10-17 17:09:03 +00:00
|
|
|
pub fn from_vis(vis: Visibility) -> EffectiveVisibility {
|
2022-09-25 11:25:02 +00:00
|
|
|
EffectiveVisibility {
|
2022-09-22 13:19:53 +00:00
|
|
|
direct: vis,
|
|
|
|
reexported: vis,
|
2022-09-25 11:25:02 +00:00
|
|
|
reachable: vis,
|
2022-09-22 13:19:53 +00:00
|
|
|
reachable_through_impl_trait: vis,
|
2022-09-25 11:25:02 +00:00
|
|
|
}
|
2022-09-12 07:57:34 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
/// Holds a map of effective visibilities for reachable HIR nodes.
|
2022-10-28 10:58:21 +00:00
|
|
|
#[derive(Clone, Debug)]
|
|
|
|
pub struct EffectiveVisibilities<Id = LocalDefId> {
|
|
|
|
map: FxHashMap<Id, EffectiveVisibility>,
|
2015-11-19 11:16:35 +00:00
|
|
|
}
|
|
|
|
|
2022-10-29 10:58:37 +00:00
|
|
|
impl EffectiveVisibilities {
|
|
|
|
pub fn is_public_at_level(&self, id: LocalDefId, level: Level) -> bool {
|
2022-09-22 13:19:53 +00:00
|
|
|
self.effective_vis(id)
|
|
|
|
.map_or(false, |effective_vis| effective_vis.is_public_at_level(level))
|
2022-09-12 07:57:34 +00:00
|
|
|
}
|
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
/// See `Level::Reachable`.
|
2022-10-29 10:58:37 +00:00
|
|
|
pub fn is_reachable(&self, id: LocalDefId) -> bool {
|
2022-09-22 13:19:53 +00:00
|
|
|
self.is_public_at_level(id, Level::Reachable)
|
2015-11-19 11:16:35 +00:00
|
|
|
}
|
2019-01-26 19:30:52 +00:00
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
/// See `Level::Reexported`.
|
2022-10-29 10:58:37 +00:00
|
|
|
pub fn is_exported(&self, id: LocalDefId) -> bool {
|
2022-09-22 13:19:53 +00:00
|
|
|
self.is_public_at_level(id, Level::Reexported)
|
2015-11-19 11:16:35 +00:00
|
|
|
}
|
2019-01-26 19:30:52 +00:00
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
/// See `Level::Direct`.
|
2022-10-29 10:58:37 +00:00
|
|
|
pub fn is_directly_public(&self, id: LocalDefId) -> bool {
|
2022-09-22 13:19:53 +00:00
|
|
|
self.is_public_at_level(id, Level::Direct)
|
2022-09-12 07:57:34 +00:00
|
|
|
}
|
|
|
|
|
2022-10-29 10:58:37 +00:00
|
|
|
pub fn public_at_level(&self, id: LocalDefId) -> Option<Level> {
|
2022-09-22 13:19:53 +00:00
|
|
|
self.effective_vis(id).and_then(|effective_vis| {
|
2022-12-18 11:45:56 +00:00
|
|
|
Level::all_levels().into_iter().find(|&level| effective_vis.is_public_at_level(level))
|
2022-09-12 07:57:34 +00:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2022-11-05 12:54:45 +00:00
|
|
|
// FIXME: Share code with `fn update`.
|
|
|
|
pub fn update_eff_vis(
|
|
|
|
&mut self,
|
|
|
|
def_id: LocalDefId,
|
|
|
|
eff_vis: &EffectiveVisibility,
|
|
|
|
tree: impl DefIdTree,
|
|
|
|
) {
|
|
|
|
use std::collections::hash_map::Entry;
|
|
|
|
match self.map.entry(def_id) {
|
|
|
|
Entry::Occupied(mut occupied) => {
|
|
|
|
let old_eff_vis = occupied.get_mut();
|
|
|
|
for l in Level::all_levels() {
|
|
|
|
let vis_at_level = eff_vis.at_level(l);
|
|
|
|
let old_vis_at_level = old_eff_vis.at_level_mut(l);
|
|
|
|
if vis_at_level != old_vis_at_level
|
|
|
|
&& vis_at_level.is_at_least(*old_vis_at_level, tree)
|
|
|
|
{
|
|
|
|
*old_vis_at_level = *vis_at_level
|
|
|
|
}
|
|
|
|
}
|
|
|
|
old_eff_vis
|
|
|
|
}
|
|
|
|
Entry::Vacant(vacant) => vacant.insert(*eff_vis),
|
|
|
|
};
|
2022-09-12 07:57:34 +00:00
|
|
|
}
|
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
pub fn set_public_at_level(
|
2022-09-25 11:25:02 +00:00
|
|
|
&mut self,
|
2022-10-29 10:58:37 +00:00
|
|
|
id: LocalDefId,
|
2022-11-18 22:52:49 +00:00
|
|
|
lazy_private_vis: impl FnOnce() -> Visibility,
|
2022-09-22 13:19:53 +00:00
|
|
|
level: Level,
|
2022-09-25 11:25:02 +00:00
|
|
|
) {
|
|
|
|
let mut effective_vis = self
|
2022-09-22 13:19:53 +00:00
|
|
|
.effective_vis(id)
|
2022-09-25 11:25:02 +00:00
|
|
|
.copied()
|
2022-11-18 22:52:49 +00:00
|
|
|
.unwrap_or_else(|| EffectiveVisibility::from_vis(lazy_private_vis()));
|
2022-09-22 13:19:53 +00:00
|
|
|
for l in Level::all_levels() {
|
|
|
|
if l <= level {
|
|
|
|
*effective_vis.at_level_mut(l) = Visibility::Public;
|
2022-09-25 11:25:02 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
self.map.insert(id, effective_vis);
|
|
|
|
}
|
2022-11-04 13:44:40 +00:00
|
|
|
|
|
|
|
pub fn check_invariants(&self, tcx: TyCtxt<'_>, early: bool) {
|
|
|
|
if !cfg!(debug_assertions) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
for (&def_id, ev) in &self.map {
|
|
|
|
// More direct visibility levels can never go farther than less direct ones,
|
|
|
|
// neither of effective visibilities can go farther than nominal visibility,
|
|
|
|
// and all effective visibilities are larger or equal than private visibility.
|
|
|
|
let private_vis = Visibility::Restricted(tcx.parent_module_from_def_id(def_id));
|
|
|
|
let span = tcx.def_span(def_id.to_def_id());
|
|
|
|
if !ev.direct.is_at_least(private_vis, tcx) {
|
|
|
|
span_bug!(span, "private {:?} > direct {:?}", private_vis, ev.direct);
|
|
|
|
}
|
|
|
|
if !ev.reexported.is_at_least(ev.direct, tcx) {
|
|
|
|
span_bug!(span, "direct {:?} > reexported {:?}", ev.direct, ev.reexported);
|
|
|
|
}
|
|
|
|
if !ev.reachable.is_at_least(ev.reexported, tcx) {
|
|
|
|
span_bug!(span, "reexported {:?} > reachable {:?}", ev.reexported, ev.reachable);
|
|
|
|
}
|
|
|
|
if !ev.reachable_through_impl_trait.is_at_least(ev.reachable, tcx) {
|
|
|
|
span_bug!(
|
|
|
|
span,
|
|
|
|
"reachable {:?} > reachable_through_impl_trait {:?}",
|
|
|
|
ev.reachable,
|
|
|
|
ev.reachable_through_impl_trait
|
|
|
|
);
|
|
|
|
}
|
|
|
|
let nominal_vis = tcx.visibility(def_id);
|
|
|
|
// FIXME: `rustc_privacy` is not yet updated for the new logic and can set
|
|
|
|
// effective visibilities that are larger than the nominal one.
|
|
|
|
if !nominal_vis.is_at_least(ev.reachable_through_impl_trait, tcx) && early {
|
|
|
|
span_bug!(
|
|
|
|
span,
|
|
|
|
"{:?}: reachable_through_impl_trait {:?} > nominal {:?}",
|
|
|
|
def_id,
|
|
|
|
ev.reachable_through_impl_trait,
|
|
|
|
nominal_vis
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2022-10-28 10:58:21 +00:00
|
|
|
}
|
|
|
|
|
2022-11-18 22:52:49 +00:00
|
|
|
pub trait IntoDefIdTree {
|
|
|
|
type Tree: DefIdTree;
|
|
|
|
fn tree(self) -> Self::Tree;
|
|
|
|
}
|
|
|
|
|
2022-10-28 10:58:21 +00:00
|
|
|
impl<Id: Eq + Hash> EffectiveVisibilities<Id> {
|
2022-11-05 12:54:45 +00:00
|
|
|
pub fn iter(&self) -> impl Iterator<Item = (&Id, &EffectiveVisibility)> {
|
|
|
|
self.map.iter()
|
|
|
|
}
|
|
|
|
|
2022-10-28 10:58:21 +00:00
|
|
|
pub fn effective_vis(&self, id: Id) -> Option<&EffectiveVisibility> {
|
|
|
|
self.map.get(&id)
|
|
|
|
}
|
2022-09-25 11:25:02 +00:00
|
|
|
|
2022-11-23 17:31:35 +00:00
|
|
|
// FIXME: Share code with `fn update`.
|
|
|
|
pub fn effective_vis_or_private(
|
|
|
|
&mut self,
|
|
|
|
id: Id,
|
|
|
|
lazy_private_vis: impl FnOnce() -> Visibility,
|
|
|
|
) -> &EffectiveVisibility {
|
|
|
|
self.map.entry(id).or_insert_with(|| EffectiveVisibility::from_vis(lazy_private_vis()))
|
|
|
|
}
|
|
|
|
|
2022-11-18 22:52:49 +00:00
|
|
|
pub fn update<T: IntoDefIdTree>(
|
2022-09-25 11:25:02 +00:00
|
|
|
&mut self,
|
2022-10-28 10:58:21 +00:00
|
|
|
id: Id,
|
2022-09-25 11:25:02 +00:00
|
|
|
nominal_vis: Visibility,
|
2022-11-18 22:52:49 +00:00
|
|
|
lazy_private_vis: impl FnOnce(T) -> (Visibility, T),
|
2022-11-23 17:31:35 +00:00
|
|
|
inherited_effective_vis: EffectiveVisibility,
|
2022-09-22 13:19:53 +00:00
|
|
|
level: Level,
|
2022-11-18 22:52:49 +00:00
|
|
|
mut into_tree: T,
|
2022-10-17 17:09:03 +00:00
|
|
|
) -> bool {
|
2022-09-25 11:25:02 +00:00
|
|
|
let mut changed = false;
|
2022-11-18 22:52:49 +00:00
|
|
|
let mut current_effective_vis = match self.map.get(&id).copied() {
|
|
|
|
Some(eff_vis) => eff_vis,
|
|
|
|
None => {
|
|
|
|
let private_vis;
|
|
|
|
(private_vis, into_tree) = lazy_private_vis(into_tree);
|
|
|
|
EffectiveVisibility::from_vis(private_vis)
|
|
|
|
}
|
|
|
|
};
|
|
|
|
let tree = into_tree.tree();
|
|
|
|
|
2022-11-23 17:31:35 +00:00
|
|
|
let mut inherited_effective_vis_at_prev_level = *inherited_effective_vis.at_level(level);
|
|
|
|
let mut calculated_effective_vis = inherited_effective_vis_at_prev_level;
|
|
|
|
for l in Level::all_levels() {
|
|
|
|
if level >= l {
|
|
|
|
let inherited_effective_vis_at_level = *inherited_effective_vis.at_level(l);
|
|
|
|
let current_effective_vis_at_level = current_effective_vis.at_level_mut(l);
|
|
|
|
// effective visibility for id shouldn't be recalculated if
|
|
|
|
// inherited from parent_id effective visibility isn't changed at next level
|
|
|
|
if !(inherited_effective_vis_at_prev_level == inherited_effective_vis_at_level
|
|
|
|
&& level != l)
|
|
|
|
{
|
|
|
|
calculated_effective_vis =
|
|
|
|
if nominal_vis.is_at_least(inherited_effective_vis_at_level, tree) {
|
|
|
|
inherited_effective_vis_at_level
|
|
|
|
} else {
|
|
|
|
nominal_vis
|
|
|
|
};
|
|
|
|
}
|
|
|
|
// effective visibility can't be decreased at next update call for the
|
|
|
|
// same id
|
|
|
|
if *current_effective_vis_at_level != calculated_effective_vis
|
|
|
|
&& calculated_effective_vis.is_at_least(*current_effective_vis_at_level, tree)
|
|
|
|
{
|
|
|
|
changed = true;
|
|
|
|
*current_effective_vis_at_level = calculated_effective_vis;
|
2022-09-25 11:25:02 +00:00
|
|
|
}
|
2022-11-23 17:31:35 +00:00
|
|
|
inherited_effective_vis_at_prev_level = inherited_effective_vis_at_level;
|
2022-09-25 11:25:02 +00:00
|
|
|
}
|
|
|
|
}
|
2022-11-23 17:31:35 +00:00
|
|
|
|
2022-09-25 11:25:02 +00:00
|
|
|
self.map.insert(id, current_effective_vis);
|
2022-10-17 17:09:03 +00:00
|
|
|
changed
|
2022-09-25 11:25:02 +00:00
|
|
|
}
|
2015-11-19 11:16:35 +00:00
|
|
|
}
|
|
|
|
|
2022-10-28 10:58:21 +00:00
|
|
|
impl<Id> Default for EffectiveVisibilities<Id> {
|
|
|
|
fn default() -> Self {
|
|
|
|
EffectiveVisibilities { map: Default::default() }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-22 13:19:53 +00:00
|
|
|
impl<'a> HashStable<StableHashingContext<'a>> for EffectiveVisibilities {
|
2020-11-14 15:35:31 +00:00
|
|
|
fn hash_stable(&self, hcx: &mut StableHashingContext<'a>, hasher: &mut StableHasher) {
|
2022-09-22 13:19:53 +00:00
|
|
|
let EffectiveVisibilities { ref map } = *self;
|
2022-04-04 20:19:25 +00:00
|
|
|
map.hash_stable(hcx, hasher);
|
2020-11-14 15:35:31 +00:00
|
|
|
}
|
|
|
|
}
|