rust/tests/ui/privacy/effective_visibilities_invariants.rs

// Invariant checking doesn't ICE in some cases with errors (issue #104249).

#![feature(staged_api)] //~ ERROR module has missing stability attribute

pub mod m {} //~ ERROR module has missing stability attribute

pub mod m { //~ ERROR the name `m` is defined multiple times
    mod inner {}
    type Inner = u8;
}

fn main() {}
effective visibility: Remove questionable optimizations First, they require eagerly calculating private visibility (current normal module), which is somewhat expensive. Private visibilities are also lost once calculated, instead of being cached in the table. Second, I cannot prove that the optimizations are correct. Maybe they can be partially reinstated in the future in cases when it's cheap and provably correct to do them. They will also probably be merged into `fn update` in that case. Partially fixes https://github.com/rust-lang/rust/issues/104249 Fixes https://github.com/rust-lang/rust/issues/104539 2022-11-23 16:19:06 +00:00			`// Invariant checking doesn't ICE in some cases with errors (issue #104249).`

			`#![feature(staged_api)] //~ ERROR module has missing stability attribute`

			`pub mod m {} //~ ERROR module has missing stability attribute`

			pub mod m { //~ ERROR the name `m` is defined multiple times
effective visibility: Fix private visibility calculation for modules Optimizations removed in the previous commit required this function to behave incorrectly, but now those optimizations are gone so we can fix the bug. Fixes https://github.com/rust-lang/rust/issues/104249 2022-11-23 17:13:44 +00:00			`mod inner {}`
effective visibility: Remove questionable optimizations First, they require eagerly calculating private visibility (current normal module), which is somewhat expensive. Private visibilities are also lost once calculated, instead of being cached in the table. Second, I cannot prove that the optimizations are correct. Maybe they can be partially reinstated in the future in cases when it's cheap and provably correct to do them. They will also probably be merged into `fn update` in that case. Partially fixes https://github.com/rust-lang/rust/issues/104249 Fixes https://github.com/rust-lang/rust/issues/104539 2022-11-23 16:19:06 +00:00			`type Inner = u8;`
			`}`

			`fn main() {}`