nordic-dev.net/rust-gpu
2
0
Fork 0
mirror of https://github.com/EmbarkStudios/rust-gpu.git synced 2025-02-19 18:35:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reenable clippy's use_self lint (disabled during last rustup) and remove now-unneeded #[allow]s for it. (#470)

Browse Source 
* Reenable clippy's `use_self` lint (was disabled during last rustup).

* Remove now-unneeded `#[allow(clippy::use_self)]`.
This commit is contained in:
Eduard-Mihai Burtescu 2021-03-04 18:03:21 +02:00 committed by GitHub
parent 7723f5db6b
commit d574fa3737
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/rustc_codegen_spirv/src/decorations.rs
View File

@ -1,6 +1,10 @@
//! SPIR-V decorations specific to `rustc_codegen_spirv`, produced during
//! the original codegen of a crate, and consumed by the `linker`.
// FIXME(eddyb) Remove when a fix for clippy warning in `serde` derives
// (https://github.com/rust-lang/rust-clippy/issues/6818) lands in nightly.
#![allow(clippy::use_self)]
use rspirv::dr::{Instruction, Module, Operand};
use rspirv::spirv::{Decoration, Op, Word};
use rustc_span::{source_map::SourceMap, FileName, Pos, Span};

3
crates/rustc_codegen_spirv/src/lib.rs
View File

@ -28,8 +28,7 @@
//clippy::enum_glob_use,
clippy::pub_enum_variant_names,
clippy::mem_forget,
// See: https://github.com/EmbarkStudios/rust-gpu/issues/459
// clippy::use_self,
clippy::use_self,
clippy::filter_map_next,
clippy::needless_continue,
clippy::needless_borrow,

6
crates/rustc_codegen_spirv/src/linker/specializer.rs
View File

@ -290,7 +290,7 @@ impl TryFrom<&Operand> for CopyOperand {
}
impl From<CopyOperand> for Operand {
fn from(op: CopyOperand) -> Operand {
fn from(op: CopyOperand) -> Self {
match op {
CopyOperand::IdRef(id) => Self::IdRef(id),
CopyOperand::StorageClass(s) => Self::StorageClass(s),
@ -325,8 +325,6 @@ enum Value<T> {
SameAs(T),
}
// FIXME(eddyb) clippy bug suggests `Self` even when it'd be a type mismatch.
#[allow(clippy::use_self)]
impl<T> Value<T> {
fn map_var<U>(self, f: impl FnOnce(T) -> U) -> Value<U> {
match self {
@ -363,8 +361,6 @@ struct Instance<GA> {
generic_args: GA,
}
// FIXME(eddyb) clippy bug suggests `Self` even when it'd be a type mismatch.
#[allow(clippy::use_self)]
impl<GA> Instance<GA> {
fn as_ref(&self) -> Instance<&GA> {
Instance {

2
crates/rustc_codegen_spirv/src/symbols.rs
View File

@ -323,8 +323,6 @@ const EXECUTION_MODES: &[(&str, ExecutionMode, ExecutionModeExtraDim)] = {
]
};
// FIXME(eddyb) clippy bug suggests `Self` even when it couldn't possibly work.
#[allow(clippy::use_self)]
impl Symbols {
fn new() -> Self {
let builtins = BUILTINS