nordic-dev.net/rust-gpu
2
0
Fork 0
mirror of https://github.com/EmbarkStudios/rust-gpu.git synced 2024-11-21 22:34:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid leaking file metadata (mtime/UID/GID) in rlibs through the ar crate.

Browse Source
This commit is contained in:
Eduard-Mihai Burtescu 2022-08-17 13:17:55 +03:00 committed by Eduard-Mihai Burtescu
parent 3cd665a873
commit a99fd432ad
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crates/rustc_codegen_spirv/src/link.rs
View File

@ -491,7 +491,16 @@ fn create_archive(files: &[&Path], metadata: &[u8], out_filename: &Path) {
"Duplicate filename in archive: {:?}",
file.file_name().unwrap()
);
builder.append_path(file).unwrap();
// NOTE(eddyb) we can't use `append_path` or `append_file`, as they
// record too much metadata by default (mtime/UID/GID, at least),
// which is determintal to reproducible build artifacts, but also
// can misbehave in environments with high UIDs/GIDs (see #889).
let file = File::open(file).unwrap();
let header = Header::new(name.as_bytes().to_vec(), file.metadata().unwrap().len());
// NOTE(eddyb) either `fs::File`, or the result of `fs::read`, could fit
// here, but `fs::File` has specialized file->file copying on some OSes.
builder.append(&header, file).unwrap();
}
builder.into_inner().unwrap();
}