mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-01-20 03:43:45 +00:00
fb079c3110
generate-config.pl's auto modules feature answers "m" to any Kconfig question it thinks supports being a module. It detected this by seeing if the help shown by make config (called "alts" by the script) contained the string "/m", which it would in the case of e.g a tristate option, where alts would be "N/m/y/?". But then along came CONFIG_MODPROBE_PATH in Linux 5.13, with a default value, shown in the make config help, of "/sbin/modprobe". generate-config.pl would see the "/m" substring, and answer "m" to the question, meaning (I think) that the built kernel would expect the modprobe binary to be at /m. This broke the (non-NixOS) VM images I build with Nix. NixOS was unaffected because it uses a different mechanism to set the modprobe path. With the current architecture, we can't 100% determine whether a Kconfig option is a string or a tristate, but we can get a lot closer by using a better regex. My new regex only accepts single word characters, separated by slashes, with a "/?" at the end. This is much less likely to ever end up as the default value of a string option. Tested by building linux_latest.configfile before and after my changes, and checking the only difference is the correct default for CONFIG_MODPROBE_PATH. |
||
|---|---|---|
| .. | ||
| cpu-cgroup-v2-patches | ||
| hardened | ||
| bridge-stp-helper.patch | ||
| common-config.nix | ||
| export-rt-sched-migrate.patch | ||
| gen-kheaders-metadata.patch | ||
| generate-config.pl | ||
| generic.nix | ||
| genksyms-fix-segfault.patch | ||
| gpio-utils.nix | ||
| linux-4.9.nix | ||
| linux-4.14.nix | ||
| linux-4.19.nix | ||
| linux-5.4.nix | ||
| linux-5.10.nix | ||
| linux-5.15.nix | ||
| linux-5.16.nix | ||
| linux-hardkernel-4.14.nix | ||
| linux-libre.nix | ||
| linux-lqx.nix | ||
| linux-mptcp-95.nix | ||
| linux-rpi.nix | ||
| linux-rt-5.4.nix | ||
| linux-rt-5.10.nix | ||
| linux-testing-bcachefs.nix | ||
| linux-testing.nix | ||
| linux-xanmod.nix | ||
| linux-zen.nix | ||
| mac-nvme-t2.patch | ||
| manual-config.nix | ||
| modinst-arg-list-too-long.patch | ||
| mptcp-config.nix | ||
| p9-fixes.patch | ||
| patches.nix | ||
| perf.nix | ||
| randstruct-provide-seed.patch | ||
| request-key-helper-updated.patch | ||
| request-key-helper.patch | ||
| rtl8761b-support.patch | ||
| update-libre.sh | ||
| update-rt.sh | ||
| update-zen.sh | ||
| update.sh | ||