mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-04 21:03:15 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
152 lines
3.6 KiB
Nix
152 lines
3.6 KiB
Nix
{ stdenv
|
|
, lib
|
|
, fetchFromGitHub
|
|
, fetchpatch
|
|
, imagemagickBig
|
|
, pkg-config
|
|
, withXorg ? true
|
|
, libX11
|
|
, libv4l
|
|
, qtbase
|
|
, qtx11extras
|
|
, wrapQtAppsHook
|
|
, wrapGAppsHook3
|
|
, gtk3
|
|
, xmlto
|
|
, docbook_xsl
|
|
, autoreconfHook
|
|
, dbus
|
|
, enableVideo ? stdenv.hostPlatform.isLinux
|
|
# The implementation is buggy and produces an error like
|
|
# Name Error (Connection ":1.4380" is not allowed to own the service "org.linuxtv.Zbar" due to security policies in the configuration file)
|
|
# for every scanned code.
|
|
# see https://github.com/mchehab/zbar/issues/104
|
|
, enableDbus ? false
|
|
, libintl
|
|
, libiconv
|
|
, Foundation
|
|
, bash
|
|
, python3
|
|
, argp-standalone
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "zbar";
|
|
version = "0.23.92";
|
|
|
|
outputs = [ "out" "lib" "dev" "doc" "man" ];
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "mchehab";
|
|
repo = "zbar";
|
|
rev = version;
|
|
sha256 = "sha256-VhVrngAX7pXZp+szqv95R6RGAJojp3svdbaRKigGb0w=";
|
|
};
|
|
|
|
patches = [
|
|
(fetchpatch {
|
|
name = "CVE-2023-40889.patch";
|
|
url = "https://salsa.debian.org/debian/zbar/-/raw/debian/0.23.92-9/debian/patches/0003-CVE-2023-40889-qrdec.c-Fix-array-out-of-bounds-acces.patch";
|
|
hash = "sha256-z0IADJwUt9PBoox5xJJN//5vrcRbIrWB9H7wtxNVUZU=";
|
|
})
|
|
(fetchpatch {
|
|
name = "CVE-2023-40890.patch";
|
|
url = "https://salsa.debian.org/debian/zbar/-/raw/debian/0.23.92-9/debian/patches/0004-Add-bounds-check-for-CVE-2023-40890.patch";
|
|
hash = "sha256-YgiptwXpRpz0qIcXBpARfIzSB8KYmksZR58o5yFPahs=";
|
|
})
|
|
];
|
|
|
|
nativeBuildInputs = [
|
|
pkg-config
|
|
xmlto
|
|
autoreconfHook
|
|
docbook_xsl
|
|
] ++ lib.optionals enableVideo [
|
|
wrapGAppsHook3
|
|
wrapQtAppsHook
|
|
qtbase
|
|
];
|
|
|
|
buildInputs = [
|
|
imagemagickBig
|
|
libintl
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
libiconv
|
|
Foundation
|
|
] ++ lib.optionals enableDbus [
|
|
dbus
|
|
] ++ lib.optionals withXorg [
|
|
libX11
|
|
] ++ lib.optionals enableVideo [
|
|
libv4l
|
|
gtk3
|
|
qtbase
|
|
qtx11extras
|
|
];
|
|
|
|
nativeCheckInputs = [
|
|
bash
|
|
python3
|
|
];
|
|
|
|
checkInputs = lib.optionals stdenv.hostPlatform.isDarwin [
|
|
argp-standalone
|
|
];
|
|
|
|
# Note: postConfigure instead of postPatch in order to include some
|
|
# autoconf-generated files. The template files for the autogen'd scripts are
|
|
# not chmod +x, so patchShebangs misses them.
|
|
postConfigure = ''
|
|
patchShebangs test
|
|
'';
|
|
|
|
# Disable assertions which include -dev QtBase file paths.
|
|
env.NIX_CFLAGS_COMPILE = "-DQT_NO_DEBUG";
|
|
|
|
configureFlags = [
|
|
"--without-python"
|
|
] ++ (if enableDbus then [
|
|
"--with-dbusconfdir=${placeholder "out"}/share"
|
|
] else [
|
|
"--without-dbus"
|
|
]) ++ (if enableVideo then [
|
|
"--with-gtk=gtk3"
|
|
] else [
|
|
"--disable-video"
|
|
"--without-gtk"
|
|
"--without-qt"
|
|
]);
|
|
|
|
doCheck = true;
|
|
|
|
preCheck = lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
export NIX_LDFLAGS="$NIX_LDFLAGS -largp"
|
|
'';
|
|
|
|
dontWrapQtApps = true;
|
|
dontWrapGApps = true;
|
|
|
|
postFixup = lib.optionalString enableVideo ''
|
|
wrapGApp "$out/bin/zbarcam-gtk"
|
|
wrapQtApp "$out/bin/zbarcam-qt"
|
|
'';
|
|
|
|
enableParallelBuilding = true;
|
|
|
|
meta = with lib; {
|
|
description = "Bar code reader";
|
|
longDescription = ''
|
|
ZBar is an open source software suite for reading bar codes from various
|
|
sources, such as video streams, image files and raw intensity sensors. It
|
|
supports many popular symbologies (types of bar codes) including
|
|
EAN-13/UPC-A, UPC-E, EAN-8, Code 128, Code 39, Interleaved 2 of 5 and QR
|
|
Code.
|
|
'';
|
|
maintainers = with maintainers; [ raskin ];
|
|
platforms = platforms.unix;
|
|
license = licenses.lgpl21;
|
|
homepage = "https://github.com/mchehab/zbar";
|
|
mainProgram = "zbarimg";
|
|
};
|
|
}
|