mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-23 07:23:20 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
30 lines
768 B
Nix
30 lines
768 B
Nix
{ lib, stdenv, fetchFromGitHub, rustPlatform, Security }:
|
|
|
|
rustPlatform.buildRustPackage rec {
|
|
pname = "diffr";
|
|
version = "0.1.5";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "mookid";
|
|
repo = pname;
|
|
rev = "v${version}";
|
|
sha256 = "sha256-ylZE2NtTXbGqsxE72ylEQCacTyxBO+/WgvEpoXd5OZI=";
|
|
};
|
|
|
|
cargoHash = "sha256-RmQu55OnKfeuDGcJrfjhMKnxDatdowkvh3Kh4N8I8Sg=";
|
|
|
|
buildInputs = (lib.optional stdenv.hostPlatform.isDarwin Security);
|
|
|
|
preCheck = ''
|
|
export DIFFR_TESTS_BINARY_PATH=$releaseDir/diffr
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "Yet another diff highlighting tool";
|
|
mainProgram = "diffr";
|
|
homepage = "https://github.com/mookid/diffr";
|
|
license = with licenses; [ mit ];
|
|
maintainers = with maintainers; [ davidtwco ];
|
|
};
|
|
}
|