mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-02-24 21:14:52 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
38 lines
944 B
Nix
38 lines
944 B
Nix
{ stdenv, libsForQt5, makeWrapper, neovim, neovim-qt-unwrapped }:
|
|
|
|
let
|
|
unwrapped = neovim-qt-unwrapped;
|
|
in
|
|
libsForQt5.mkDerivation {
|
|
pname = "neovim-qt";
|
|
version = unwrapped.version;
|
|
buildCommand = if stdenv.hostPlatform.isDarwin then ''
|
|
mkdir -p $out/Applications
|
|
cp -r ${unwrapped}/bin/nvim-qt.app $out/Applications
|
|
|
|
chmod -R a+w $out/Applications/nvim-qt.app/Contents/MacOS
|
|
wrapProgram $out/Applications/nvim-qt.app/Contents/MacOS/nvim-qt \
|
|
--prefix PATH : ${neovim}/bin
|
|
'' else ''
|
|
makeWrapper ${unwrapped}/bin/nvim-qt $out/bin/nvim-qt \
|
|
--prefix PATH : ${neovim}/bin
|
|
|
|
# link .desktop file
|
|
mkdir -p $out/share/pixmaps
|
|
ln -s ${unwrapped}/share/applications $out/share/applications
|
|
ln -s ${unwrapped}/share/icons $out/share/icons
|
|
'';
|
|
|
|
preferLocalBuild = true;
|
|
|
|
nativeBuildInputs = [
|
|
makeWrapper
|
|
];
|
|
|
|
passthru = {
|
|
inherit unwrapped;
|
|
};
|
|
|
|
inherit (unwrapped) meta;
|
|
}
|