nixpkgs/shell.nix at d835701e54307580773608cff4613feb68c460a0 - nixpkgs - nordic-dev.net

nordic-dev.net/nixpkgs

mirror of https://github.com/NixOS/nixpkgs.git synced 2024-12-28 08:33:54 +00:00

Artturin e0464e4788 treewide: replace stdenv.is with stdenv.hostPlatform.is

In preparation for the deprecation of `stdenv.isX`.

These shorthands are not conducive to cross-compilation because they
hide the platforms.

Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way

One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059

There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.

```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```

2024-09-25 00:04:37 +03:00

18 lines

246 B

Nix

Raw Blame History

 {
   pkgs ? import ../../.. { },
 }:
 let
   inherit (pkgs) lib stdenv mkShell;
 in
 mkShell {
   packages =
     with pkgs;
     [
       rustc
       cargo
       clippy
       rustfmt
     ]
     ++ lib.optional stdenv.hostPlatform.isDarwin pkgs.libiconv;
 }