mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-02-04 03:03:42 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
81 lines
2.3 KiB
Nix
81 lines
2.3 KiB
Nix
{ lib
|
|
, stdenv
|
|
, rustPlatform
|
|
, fetchFromGitHub
|
|
, pkg-config
|
|
, less
|
|
, libiconv
|
|
, installShellFiles
|
|
, makeWrapper
|
|
, darwin
|
|
}:
|
|
|
|
rustPlatform.buildRustPackage rec {
|
|
pname = "bat";
|
|
version = "0.24.0";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "sharkdp";
|
|
repo = "bat";
|
|
rev = "v${version}";
|
|
hash = "sha256-1RjlJEmY/jMf0IYQbrWrT1CHFyiqgarOl72u9xjjQiQ=";
|
|
};
|
|
cargoHash = "sha256-b7wNWdKQ4QLeCf7bNZRfzT9hD/D/oDglU7Xyb65IrGY=";
|
|
|
|
nativeBuildInputs = [ pkg-config installShellFiles makeWrapper ];
|
|
|
|
buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [ libiconv darwin.apple_sdk.frameworks.Security ];
|
|
|
|
postInstall = ''
|
|
installManPage $releaseDir/build/bat-*/out/assets/manual/bat.1
|
|
installShellCompletion $releaseDir/build/bat-*/out/assets/completions/bat.{bash,fish,zsh}
|
|
'';
|
|
|
|
# Insert Nix-built `less` into PATH because the system-provided one may be too old to behave as
|
|
# expected with certain flag combinations.
|
|
postFixup = ''
|
|
wrapProgram "$out/bin/bat" \
|
|
--prefix PATH : "${lib.makeBinPath [ less ]}"
|
|
'';
|
|
|
|
# Skip test cases which depends on `more`
|
|
checkFlags = [
|
|
"--skip=alias_pager_disable_long_overrides_short"
|
|
"--skip=config_read_arguments_from_file"
|
|
"--skip=env_var_bat_paging"
|
|
"--skip=pager_arg_override_env_noconfig"
|
|
"--skip=pager_arg_override_env_withconfig"
|
|
"--skip=pager_basic"
|
|
"--skip=pager_basic_arg"
|
|
"--skip=pager_env_bat_pager_override_config"
|
|
"--skip=pager_env_pager_nooverride_config"
|
|
"--skip=pager_more"
|
|
"--skip=pager_most"
|
|
"--skip=pager_overwrite"
|
|
# Fails if the filesystem performs UTF-8 validation (such as ZFS with utf8only=on)
|
|
"--skip=file_with_invalid_utf8_filename"
|
|
];
|
|
|
|
doInstallCheck = true;
|
|
installCheckPhase = ''
|
|
runHook preInstallCheck
|
|
|
|
testFile=$(mktemp /tmp/bat-test.XXXX)
|
|
echo -ne 'Foobar\n\n\n42' > $testFile
|
|
$out/bin/bat -p $testFile | grep "Foobar"
|
|
$out/bin/bat -p $testFile -r 4:4 | grep 42
|
|
rm $testFile
|
|
|
|
runHook postInstallCheck
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "Cat(1) clone with syntax highlighting and Git integration";
|
|
homepage = "https://github.com/sharkdp/bat";
|
|
changelog = "https://github.com/sharkdp/bat/raw/v${version}/CHANGELOG.md";
|
|
license = with licenses; [ asl20 /* or */ mit ];
|
|
mainProgram = "bat";
|
|
maintainers = with maintainers; [ dywedir zowoq SuperSandro2000 ];
|
|
};
|
|
}
|