mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-01-01 02:23:54 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
35 lines
1.1 KiB
Nix
35 lines
1.1 KiB
Nix
{ lib, stdenv, bsdbuild, libagar, perl, libjpeg, libpng, openssl }:
|
|
|
|
stdenv.mkDerivation {
|
|
pname = "libagar-test";
|
|
inherit (libagar) version src;
|
|
|
|
sourceRoot = "agar-${libagar.version}/tests";
|
|
|
|
# Workaround build failure on -fno-common toolchains:
|
|
# ld: textdlg.o:(.bss+0x0): multiple definition of `someString';
|
|
# configsettings.o:(.bss+0x0): first defined here
|
|
# TODO: the workaround can be removed once nixpkgs updates to 1.6.0.
|
|
env.NIX_CFLAGS_COMPILE = "-fcommon";
|
|
|
|
preConfigure = ''
|
|
substituteInPlace configure.in \
|
|
--replace '_BSD_SOURCE' '_DEFAULT_SOURCE'
|
|
cat configure.in | ${bsdbuild}/bin/mkconfigure > configure
|
|
'';
|
|
|
|
configureFlags = [ "--with-agar=${libagar}" ];
|
|
|
|
buildInputs = [ perl bsdbuild libagar libjpeg libpng openssl ];
|
|
|
|
meta = with lib; {
|
|
broken = (stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isAarch64);
|
|
description = "Tests for libagar";
|
|
mainProgram = "agartest";
|
|
homepage = "http://libagar.org/index.html";
|
|
license = with licenses; bsd3;
|
|
maintainers = with maintainers; [ ramkromberg ];
|
|
platforms = with platforms; linux;
|
|
};
|
|
}
|