mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-26 23:54:01 +00:00
69cf5181c3
The primary motivating example is openssl: Before the change full package build took 1m54s minutes. After the change full package build takes 59s. About a 2x speedup. The difference is visible because openssl builds hundreds of manpages spawning a perl process per manual in `install` phase. Such a workload is very easy to parallelize. Another example would be `autotools`+`libtool` based build system where install step requires relinking. The more binaries there are to relink the more gain it will be to do it in parallel. The change enables parallel installs by default only for buiilds that already have parallel builds enabled. There is a high chance those build systems already handle parallelism well but some packages will fail. Consistently propagated the enableParallelBuilding to: - cmake (enabled by default, similar to builds) - ninja (set parallelism explicitly, don't rely on default) - bmake (enable when requested) - scons (enable when requested) - meson (set parallelism explicitly, don't rely on default) - waf (set parallelism explicitly, don't rely on default) - qmake-4/5/6 (enable by default, similar to builds) - xorg (always enable, similar to builds)
86 lines
1.9 KiB
Bash
86 lines
1.9 KiB
Bash
sconsBuildPhase() {
|
|
runHook preBuild
|
|
|
|
if [ -n "$prefix" ]; then
|
|
mkdir -p "$prefix"
|
|
fi
|
|
|
|
if [ -z "${dontAddPrefix:-}" ] && [ -n "$prefix" ]; then
|
|
buildFlags="${prefixKey:-prefix=}$prefix $buildFlags"
|
|
fi
|
|
|
|
local flagsArray=(
|
|
${enableParallelBuilding:+-j${NIX_BUILD_CORES}}
|
|
$sconsFlags ${sconsFlagsArray[@]}
|
|
$buildFlags ${buildFlagsArray[@]}
|
|
)
|
|
|
|
echoCmd 'build flags' "${flagsArray[@]}"
|
|
scons "${flagsArray[@]}"
|
|
|
|
runHook postBuild
|
|
}
|
|
|
|
sconsInstallPhase() {
|
|
runHook preInstall
|
|
|
|
if [ -n "$prefix" ]; then
|
|
mkdir -p "$prefix"
|
|
fi
|
|
|
|
if [ -z "${dontAddPrefix:-}" ] && [ -n "$prefix" ]; then
|
|
installFlags="${prefixKey:-prefix=}$prefix $installFlags"
|
|
fi
|
|
|
|
local flagsArray=(
|
|
${enableParallelInstalling:+-j${NIX_BUILD_CORES}}
|
|
$sconsFlags ${sconsFlagsArray[@]}
|
|
$installFlags ${installFlagsArray[@]}
|
|
${installTargets:-install}
|
|
)
|
|
|
|
echoCmd 'install flags' "${flagsArray[@]}"
|
|
scons "${flagsArray[@]}"
|
|
|
|
runHook postInstall
|
|
}
|
|
|
|
sconsCheckPhase() {
|
|
runHook preCheck
|
|
|
|
if [ -z "${checkTarget:-}" ]; then
|
|
if scons -n check >/dev/null 2>&1; then
|
|
checkTarget=check
|
|
elif scons -n test >/dev/null 2>&1; then
|
|
checkTarget=test
|
|
fi
|
|
fi
|
|
|
|
if [ -z "${checkTarget:-}" ]; then
|
|
echo "no check/test target found, doing nothing"
|
|
else
|
|
local flagsArray=(
|
|
${enableParallelChecking:+-j${NIX_BUILD_CORES}}
|
|
$sconsFlags ${sconsFlagsArray[@]}
|
|
${checkFlagsArray[@]}
|
|
)
|
|
|
|
echoCmd 'check flags' "${flagsArray[@]}"
|
|
scons "${flagsArray[@]}"
|
|
fi
|
|
|
|
runHook postCheck
|
|
}
|
|
|
|
if [ -z "${buildPhase-}" ]; then
|
|
buildPhase=sconsBuildPhase
|
|
fi
|
|
|
|
if [ -z "${dontUseSconsInstall-}" -a -z "${installPhase-}" ]; then
|
|
installPhase=sconsInstallPhase
|
|
fi
|
|
|
|
if [ -z "${checkPhase-}" ]; then
|
|
checkPhase=sconsCheckPhase
|
|
fi
|