mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-23 15:33:13 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
93 lines
2.0 KiB
Nix
93 lines
2.0 KiB
Nix
{ stdenv
|
|
, lib
|
|
, perl
|
|
, pkg-config
|
|
, curl
|
|
, nix
|
|
, libsodium
|
|
, boost
|
|
, autoreconfHook
|
|
, autoconf-archive
|
|
, xz
|
|
, Security
|
|
, meson
|
|
, ninja
|
|
, bzip2
|
|
}:
|
|
|
|
let
|
|
atLeast223 = lib.versionAtLeast nix.version "2.23";
|
|
atLeast224 = lib.versionAtLeast nix.version "2.24";
|
|
|
|
mkConfigureOption = { mesonOption, autoconfOption, value }:
|
|
let
|
|
setFlagTo = if atLeast223
|
|
then lib.mesonOption mesonOption
|
|
else lib.withFeatureAs true autoconfOption;
|
|
in
|
|
setFlagTo value;
|
|
in stdenv.mkDerivation (finalAttrs: {
|
|
pname = "nix-perl";
|
|
inherit (nix) version src;
|
|
|
|
postUnpack = "sourceRoot=$sourceRoot/${lib.optionalString atLeast224 "src"}/perl";
|
|
|
|
# TODO: Remove this once the nix build also uses meson
|
|
postPatch = lib.optionalString atLeast224 ''
|
|
substituteInPlace lib/Nix/Store.xs \
|
|
--replace-fail 'config-util.hh' 'nix/config.h' \
|
|
--replace-fail 'config-store.hh' 'nix/config.h'
|
|
'';
|
|
|
|
buildInputs = [
|
|
boost
|
|
bzip2
|
|
curl
|
|
libsodium
|
|
nix
|
|
perl
|
|
xz
|
|
] ++ lib.optional (stdenv.hostPlatform.isDarwin) Security;
|
|
|
|
# Not cross-safe since Nix checks for curl/perl via
|
|
# NEED_PROG/find_program, but both seem to be needed at runtime
|
|
# as well.
|
|
nativeBuildInputs = [
|
|
pkg-config
|
|
perl
|
|
curl
|
|
] ++ (if atLeast223 then [
|
|
meson
|
|
ninja
|
|
] else [
|
|
autoconf-archive
|
|
autoreconfHook
|
|
]);
|
|
|
|
# `perlPackages.Test2Harness` is marked broken for Darwin
|
|
doCheck = !stdenv.hostPlatform.isDarwin;
|
|
|
|
nativeCheckInputs = [
|
|
perl.pkgs.Test2Harness
|
|
];
|
|
|
|
${if atLeast223 then "mesonFlags" else "configureFlags"} = [
|
|
(mkConfigureOption {
|
|
mesonOption = "dbi_path";
|
|
autoconfOption = "dbi";
|
|
value = "${perl.pkgs.DBI}/${perl.libPrefix}";
|
|
})
|
|
(mkConfigureOption {
|
|
mesonOption = "dbd_sqlite_path";
|
|
autoconfOption = "dbd-sqlite";
|
|
value = "${perl.pkgs.DBDSQLite}/${perl.libPrefix}";
|
|
})
|
|
] ++ lib.optionals atLeast223 [
|
|
(lib.mesonEnable "tests" finalAttrs.finalPackage.doCheck)
|
|
];
|
|
|
|
preConfigure = "export NIX_STATE_DIR=$TMPDIR";
|
|
|
|
passthru = { inherit perl; };
|
|
})
|