mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-11 08:13:04 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
45 lines
1.1 KiB
Nix
45 lines
1.1 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
fetchFromGitLab,
|
|
autoreconfHook,
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "a52dec";
|
|
version = "0.8.0";
|
|
|
|
src = fetchFromGitLab {
|
|
domain = "git.adelielinux.org";
|
|
owner = "community";
|
|
repo = "a52dec";
|
|
rev = "v${version}";
|
|
hash = "sha256-Z4riiwetJkhQYa+AD8qOiwB1+cuLbOyN/g7D8HM8Pkw=";
|
|
};
|
|
|
|
nativeBuildInputs = [ autoreconfHook ];
|
|
|
|
configureFlags = [
|
|
"--enable-shared"
|
|
# Define inline as __attribute__ ((__always_inline__))
|
|
"ac_cv_c_inline=yes"
|
|
];
|
|
|
|
makeFlags = [ "AR=${stdenv.cc.targetPrefix}ar" ];
|
|
|
|
# fails 1 out of 1 tests with "BAD GLOBAL SYMBOLS" on i686
|
|
# which can also be fixed with
|
|
# hardeningDisable = lib.optional stdenv.hostPlatform.isi686 "pic";
|
|
# but it's better to disable tests than loose ASLR on i686
|
|
doCheck = !stdenv.hostPlatform.isi686;
|
|
|
|
meta = with lib; {
|
|
description = "ATSC A/52 stream decoder";
|
|
homepage = "https://liba52.sourceforge.io/";
|
|
license = licenses.gpl2Plus;
|
|
maintainers = with maintainers; [ wegank ];
|
|
mainProgram = "a52dec";
|
|
platforms = platforms.unix;
|
|
};
|
|
}
|