mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-02-03 02:33:15 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
63 lines
1.8 KiB
Nix
63 lines
1.8 KiB
Nix
{ lib
|
|
, stdenv
|
|
, buildGoModule
|
|
, fetchFromGitHub
|
|
, installShellFiles
|
|
}:
|
|
|
|
buildGoModule rec {
|
|
pname = "nsc";
|
|
version = "2.8.9";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "nats-io";
|
|
repo = pname;
|
|
rev = "v${version}";
|
|
hash = "sha256-KNW9meeThHT9ZZJFXsb9RAzLsvgnaXWbuMR4tei/s2U=";
|
|
};
|
|
|
|
ldflags = [
|
|
"-s"
|
|
"-w"
|
|
"-X main.version=v${version}"
|
|
"-X main.builtBy=nixpkgs"
|
|
];
|
|
|
|
vendorHash = "sha256-3qUgzvb7VkYrlYb+W0ZycJ0S7CQAHSUFNQSfwiKqMdI=";
|
|
|
|
nativeBuildInputs = [ installShellFiles ];
|
|
|
|
postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) ''
|
|
installShellCompletion --cmd nsc \
|
|
--bash <($out/bin/nsc completion bash) \
|
|
--fish <($out/bin/nsc completion fish) \
|
|
--zsh <($out/bin/nsc completion zsh)
|
|
'';
|
|
|
|
preInstall = ''
|
|
# asc attempt to write to the home directory.
|
|
export HOME=$(mktemp -d)
|
|
'';
|
|
|
|
preCheck = preInstall;
|
|
|
|
# Tests currently fail on darwin because of a test in nsc which
|
|
# expects command output to contain a specific path. However
|
|
# the test strips table formatting from the command output in a naive way
|
|
# that removes all the table characters, including '-'.
|
|
# The nix build directory looks something like:
|
|
# /private/tmp/nix-build-nsc-2.8.9.drv-0/nsc_test2000598938/keys
|
|
# Then the `-` are removed from the path unintentionally and the test fails.
|
|
# This should be fixed upstream to avoid mangling the path when
|
|
# removing the table decorations from the command output.
|
|
doCheck = !stdenv.hostPlatform.isDarwin;
|
|
|
|
meta = {
|
|
description = "Tool for creating NATS account and user access configurations";
|
|
homepage = "https://github.com/nats-io/nsc";
|
|
license = with lib.licenses; [ asl20 ];
|
|
maintainers = with lib.maintainers; [ cbrewster ];
|
|
mainProgram = "nsc";
|
|
};
|
|
}
|