mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-30 17:43:42 +00:00
55b8958f7d
This commit does the following two things:
1. Changes the Haskell package used in the extraDependencies test from
releaser to conduit. The reason for this is that conduit is more
of a "core" package in Haskell, and it is more likely to always be
working. (If conduit is not compiling, then large chunks of Hackage
won't be working.)
2. Tighten up the GHCi test to actually use the package from
extraDependencies. It appears that GHCi can fail to import the
package from extraDependencies, and that doesn't cause GHCi to
return an error code, which means the test isn't actually testing
anything.
This new change makes it so that if the package from
extraDependencies is actually not included for some reason, then
this shellFor test should fail.
58 lines
2.0 KiB
Nix
58 lines
2.0 KiB
Nix
{ lib, writeText, haskellPackages, cabal-install }:
|
|
|
|
(haskellPackages.shellFor {
|
|
packages = p: [ p.constraints p.linear ];
|
|
# WARNING: When updating this, make sure that the libraries passed to
|
|
# `extraDependencies` are not actually transitive dependencies of libraries in
|
|
# `packages` above. We explicitly want to test that it is possible to specify
|
|
# `extraDependencies` that are not in the closure of `packages`.
|
|
extraDependencies = p: { libraryHaskellDepends = [ p.conduit ]; };
|
|
nativeBuildInputs = [ cabal-install ];
|
|
phases = [ "unpackPhase" "buildPhase" "installPhase" ];
|
|
unpackPhase = ''
|
|
sourceRoot=$(pwd)/scratch
|
|
mkdir -p "$sourceRoot"
|
|
cd "$sourceRoot"
|
|
tar -xf ${haskellPackages.constraints.src}
|
|
tar -xf ${haskellPackages.linear.src}
|
|
cp ${writeText "cabal.project" "packages: constraints* linear*"} cabal.project
|
|
'';
|
|
buildPhase = ''
|
|
export HOME=$(mktemp -d)
|
|
mkdir -p $HOME/.cabal
|
|
touch $HOME/.cabal/config
|
|
|
|
# Check that the extraDependencies.libraryHaskellDepends arg is correctly
|
|
# picked up. This uses ghci to interpret a small Haskell program that uses
|
|
# a package from extraDependencies.
|
|
ghci <<EOF
|
|
:set -XOverloadedStrings
|
|
:m + Conduit
|
|
runResourceT $ connect (yield "done") (sinkFile "outfile")
|
|
EOF
|
|
|
|
if [[ "done" != "$(cat outfile)" ]]; then
|
|
echo "ERROR: extraDependencies appear not to be available in the environment"
|
|
exit 1
|
|
fi
|
|
|
|
# Check packages arg
|
|
cabal v2-build --offline --verbose constraints linear --ghc-options="-O0 -j$NIX_BUILD_CORES"
|
|
'';
|
|
installPhase = ''
|
|
touch $out
|
|
'';
|
|
}).overrideAttrs (oldAttrs: {
|
|
meta =
|
|
let
|
|
oldMeta = oldAttrs.meta or {};
|
|
oldMaintainers = oldMeta.maintainers or [];
|
|
additionalMaintainers = with lib.maintainers; [ cdepillabout ];
|
|
allMaintainers = oldMaintainers ++ additionalMaintainers;
|
|
in
|
|
oldMeta // {
|
|
maintainers = allMaintainers;
|
|
inherit (cabal-install.meta) platforms;
|
|
};
|
|
})
|