mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-03 20:33:21 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
132 lines
2.6 KiB
Nix
132 lines
2.6 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
buildPythonPackage,
|
|
fetchFromGitHub,
|
|
cmake,
|
|
opencv4,
|
|
ceres-solver,
|
|
suitesparse,
|
|
metis,
|
|
eigen,
|
|
pkg-config,
|
|
pybind11,
|
|
numpy,
|
|
pyyaml,
|
|
lapack,
|
|
gtest,
|
|
gflags,
|
|
glog,
|
|
pytestCheckHook,
|
|
networkx,
|
|
pillow,
|
|
exifread,
|
|
gpxpy,
|
|
pyproj,
|
|
python-dateutil,
|
|
joblib,
|
|
repoze-lru,
|
|
xmltodict,
|
|
cloudpickle,
|
|
scipy,
|
|
sphinx,
|
|
matplotlib,
|
|
fpdf,
|
|
}:
|
|
|
|
let
|
|
ceresSplit = (builtins.length ceres-solver.outputs) > 1;
|
|
ceres' = if ceresSplit then ceres-solver.dev else ceres-solver;
|
|
in
|
|
buildPythonPackage rec {
|
|
pname = "opensfm";
|
|
version = "unstable-2023-12-09";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "mapillary";
|
|
repo = "OpenSfM";
|
|
rev = "7f170d0dc352340295ff480378e3ac37d0179f8e";
|
|
sha256 = "sha256-l/HTVenC+L+GpMNnDgnSGZ7+Qd2j8b8cuTs3SmORqrg=";
|
|
};
|
|
patches = [
|
|
./0002-cmake-find-system-distributed-gtest.patch
|
|
./0003-cmake-use-system-pybind11.patch
|
|
./0004-pybind_utils.h-conflicts-with-nixpkgs-pybind.patch
|
|
./fix-scripts.patch
|
|
];
|
|
postPatch = ''
|
|
rm opensfm/src/cmake/FindGlog.cmake
|
|
rm opensfm/src/cmake/FindGflags.cmake
|
|
|
|
# HAHOG is the default descriptor.
|
|
# We'll test both HAHOG and SIFT because this is
|
|
# where segfaults might be introduced in future
|
|
echo 'feature_type: SIFT' >> data/berlin/config.yaml
|
|
echo 'feature_type: HAHOG' >> data/lund/config.yaml
|
|
|
|
sed -i -e 's/^.*BuildDoc.*$//' setup.py
|
|
'';
|
|
|
|
nativeBuildInputs = [
|
|
cmake
|
|
pkg-config
|
|
sphinx
|
|
];
|
|
buildInputs = [
|
|
ceres'
|
|
suitesparse
|
|
metis
|
|
eigen
|
|
lapack
|
|
gflags
|
|
gtest
|
|
glog
|
|
pybind11
|
|
];
|
|
propagatedBuildInputs = [
|
|
numpy
|
|
scipy
|
|
pyyaml
|
|
opencv4.cxxdev
|
|
networkx
|
|
pillow
|
|
matplotlib
|
|
fpdf
|
|
exifread
|
|
gpxpy
|
|
pyproj
|
|
python-dateutil
|
|
joblib
|
|
repoze-lru
|
|
xmltodict
|
|
cloudpickle
|
|
];
|
|
nativeCheckInputs = [ pytestCheckHook ];
|
|
|
|
dontUseCmakeBuildDir = true;
|
|
cmakeFlags = [
|
|
"-Bcmake_build"
|
|
"-Sopensfm/src"
|
|
];
|
|
|
|
disabledTests =
|
|
[
|
|
"test_run_all" # Matplotlib issues. Broken integration is less useless than a broken build
|
|
]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
"test_reconstruction_incremental"
|
|
"test_reconstruction_triangulation"
|
|
];
|
|
|
|
pythonImportsCheck = [ "opensfm" ];
|
|
|
|
meta = {
|
|
broken = stdenv.hostPlatform.isDarwin;
|
|
maintainers = [ lib.maintainers.SomeoneSerge ];
|
|
license = lib.licenses.bsd2;
|
|
changelog = "https://github.com/mapillary/OpenSfM/blob/${src.rev}/CHANGELOG.md";
|
|
description = "Open source Structure-from-Motion pipeline from Mapillary";
|
|
homepage = "https://opensfm.org/";
|
|
};
|
|
}
|