mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-02-19 10:34:54 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
66 lines
1.8 KiB
Nix
66 lines
1.8 KiB
Nix
{ buildNpmPackage
|
|
, cctools
|
|
, darwin
|
|
, fetchFromGitHub
|
|
, lib
|
|
, node-gyp
|
|
, nodejs
|
|
, python3
|
|
, stdenv
|
|
}:
|
|
|
|
buildNpmPackage {
|
|
pname = "nodehun";
|
|
version = "3.0.2";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "Wulf";
|
|
repo = "nodehun";
|
|
rev = "03c9dcf1fcd965031a68553ccaf6487d1fe87f79";
|
|
hash = "sha256-MoY95lSIQK1K4aIlMdPm93YxJuez9HYx2zlUhHvDao0=";
|
|
};
|
|
|
|
patches = [
|
|
# fsevents is needed on Darwin, but its dependency "nan" in the upstream package-lock.json
|
|
# is too old for the Node 18.x in Nixpkgs.
|
|
# This patch is generated by checking out the upstream source and running
|
|
# npm update nan --lockfile-version 1
|
|
./update-nan.patch
|
|
];
|
|
|
|
npmDepsHash = "sha256-mV6rWNf2p2w4H0ESUT0/Ybtx9YEdvO5l2gCvlWFXK+U=";
|
|
|
|
buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [ darwin.apple_sdk.frameworks.CoreServices ];
|
|
nativeBuildInputs = [ node-gyp python3 ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ cctools ];
|
|
|
|
postInstall = ''
|
|
# Only keep the necessary parts of build/Release to reduce closure size
|
|
cd $out/lib/node_modules/nodehun
|
|
mv build build_old
|
|
mkdir build
|
|
cp -r build_old/Release build/
|
|
rm -rf build_old
|
|
rm -rf build/Release/.deps
|
|
# Remove a development script to eliminate runtime dependency on node
|
|
rm node_modules/node-addon-api/tools/conversion.js
|
|
'';
|
|
|
|
doInstallCheck = true;
|
|
nativeCheckInputs = [ nodejs ];
|
|
postInstallCheck = ''
|
|
# Smoke check: require() works
|
|
export NODE_PATH=$out/lib/node_modules
|
|
echo 'require("nodehun")' | node -
|
|
'';
|
|
|
|
disallowedReferences = [ nodejs ];
|
|
|
|
meta = with lib; {
|
|
description = "Hunspell binding for NodeJS that exposes as much of Hunspell as possible and also adds new features";
|
|
homepage = "https://github.com/Wulf/nodehun";
|
|
license = licenses.mit;
|
|
maintainers = [ maintainers.thomasjm ];
|
|
};
|
|
}
|