mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-01 19:33:03 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
92 lines
2.1 KiB
Nix
92 lines
2.1 KiB
Nix
{ lib, stdenv
|
|
, cairo
|
|
, elfutils
|
|
, fetchFromGitHub
|
|
, glib
|
|
, gobject-introspection
|
|
, gtksourceview3
|
|
, json-glib
|
|
, makeWrapper
|
|
, pango
|
|
, pkg-config
|
|
, polkit
|
|
, python3
|
|
, scons
|
|
, sphinx
|
|
, util-linux
|
|
, wrapGAppsHook3
|
|
, withGui ? false }:
|
|
|
|
assert withGui -> !stdenv.hostPlatform.isDarwin;
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "rmlint";
|
|
version = "2.10.2";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "sahib";
|
|
repo = "rmlint";
|
|
rev = "v${version}";
|
|
sha256 = "sha256-pOo1YfeqHUU6xyBRFbcj2lX1MHJ+a5Hi31BMC1nYZGo=";
|
|
};
|
|
|
|
patches = [
|
|
# pass through NIX_* environment variables to scons.
|
|
./scons-nix-env.patch
|
|
];
|
|
|
|
nativeBuildInputs = [
|
|
pkg-config
|
|
sphinx
|
|
scons
|
|
] ++ lib.optionals withGui [
|
|
makeWrapper
|
|
wrapGAppsHook3
|
|
gobject-introspection
|
|
];
|
|
|
|
buildInputs = [
|
|
glib
|
|
json-glib
|
|
util-linux
|
|
] ++ lib.optionals withGui [
|
|
cairo
|
|
gtksourceview3
|
|
pango
|
|
polkit
|
|
python3
|
|
python3.pkgs.pygobject3
|
|
] ++ lib.optionals (lib.meta.availableOn stdenv.hostPlatform elfutils) [
|
|
elfutils
|
|
];
|
|
|
|
prePatch = ''
|
|
# remove sources of nondeterminism
|
|
substituteInPlace lib/cmdline.c \
|
|
--replace "__DATE__" "\"Jan 1 1970\"" \
|
|
--replace "__TIME__" "\"00:00:00\""
|
|
substituteInPlace docs/SConscript \
|
|
--replace "gzip -c " "gzip -cn "
|
|
'';
|
|
|
|
# Otherwise tries to access /usr.
|
|
prefixKey = "--prefix=";
|
|
|
|
sconsFlags = lib.optionals (!withGui) [ "--without-gui" ];
|
|
|
|
# in GUI mode, this shells out to itself, and tries to import python modules
|
|
postInstall = lib.optionalString withGui ''
|
|
gappsWrapperArgs+=(--prefix PATH : "$out/bin")
|
|
gappsWrapperArgs+=(--prefix PYTHONPATH : "$(toPythonPath $out):$(toPythonPath ${python3.pkgs.pygobject3}):$(toPythonPath ${python3.pkgs.pycairo})")
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "Extremely fast tool to remove duplicates and other lint from your filesystem";
|
|
homepage = "https://rmlint.readthedocs.org";
|
|
platforms = platforms.unix;
|
|
license = licenses.gpl3;
|
|
maintainers = with maintainers; [ aaschmid koral ];
|
|
mainProgram = "rmlint";
|
|
};
|
|
}
|