mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-01-28 07:43:43 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
90 lines
2.0 KiB
Nix
90 lines
2.0 KiB
Nix
{
|
|
lib,
|
|
buildPythonPackage,
|
|
colorlog,
|
|
fetchPypi,
|
|
mock,
|
|
pyopenssl,
|
|
pytest-mock,
|
|
pytestCheckHook,
|
|
pythonAtLeast,
|
|
pyvmomi,
|
|
qemu,
|
|
requests,
|
|
setuptools,
|
|
stdenv,
|
|
verboselogs,
|
|
}:
|
|
|
|
buildPythonPackage rec {
|
|
pname = "cot";
|
|
version = "2.2.1";
|
|
format = "setuptools";
|
|
|
|
src = fetchPypi {
|
|
inherit pname version;
|
|
hash = "sha256-9LNVNBX5DarGVvidPoLnmz11F5Mjm7FzpoO0zAzrJjU=";
|
|
};
|
|
|
|
propagatedBuildInputs = [
|
|
colorlog
|
|
pyvmomi
|
|
requests
|
|
verboselogs
|
|
pyopenssl
|
|
setuptools
|
|
];
|
|
|
|
nativeCheckInputs = [
|
|
mock
|
|
pytestCheckHook
|
|
pytest-mock
|
|
qemu
|
|
];
|
|
|
|
prePatch = ''
|
|
# argparse is part of the standardlib
|
|
substituteInPlace setup.py \
|
|
--replace "'argparse'," ""
|
|
'';
|
|
|
|
disabledTests = [
|
|
# Many tests require network access and/or ovftool (https://code.vmware.com/web/tool/ovf)
|
|
# try enabling these tests with ovftool once/if it is added to nixpkgs
|
|
"HelperGenericTest"
|
|
"TestCOTAddDisk"
|
|
"TestCOTAddFile"
|
|
"TestCOTEditHardware"
|
|
"TestCOTEditProduct"
|
|
"TestCOTEditProperties"
|
|
"TestCOTInjectConfig"
|
|
"TestISO"
|
|
"TestOVFAPI"
|
|
"TestQCOW2"
|
|
"TestRAW"
|
|
"TestVMDKConversion"
|
|
# CLI test fails with AssertionError
|
|
"test_help"
|
|
# Failing TestCOTDeployESXi tests
|
|
"test_serial_fixup_stubbed"
|
|
"test_serial_fixup_stubbed_create"
|
|
"test_serial_fixup_stubbed_vm_not_found"
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [ "test_serial_fixup_invalid_host" ];
|
|
|
|
pythonImportsCheck = [ "COT" ];
|
|
|
|
meta = {
|
|
homepage = "https://github.com/glennmatthews/cot";
|
|
description = "Common OVF Tool";
|
|
mainProgram = "cot";
|
|
longDescription = ''
|
|
COT (the Common OVF Tool) is a tool for editing Open Virtualization Format
|
|
(.ovf, .ova) virtual appliances, with a focus on virtualized network
|
|
appliances such as the Cisco CSR 1000V and Cisco IOS XRv platforms.
|
|
'';
|
|
license = lib.licenses.mit;
|
|
maintainers = with lib.maintainers; [ evanjs ];
|
|
broken = pythonAtLeast "3.12"; # Because it requires packages removed from 3.12 onwards
|
|
};
|
|
}
|