mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-26 08:53:21 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
110 lines
3.1 KiB
Nix
110 lines
3.1 KiB
Nix
{ lib
|
|
, stdenv
|
|
, buildGoModule
|
|
, fetchFromGitHub
|
|
, php
|
|
, brotli
|
|
, testers
|
|
, frankenphp
|
|
, cctools
|
|
, darwin
|
|
, libiconv
|
|
, pkg-config
|
|
, makeBinaryWrapper
|
|
, runCommand
|
|
, writeText
|
|
}:
|
|
|
|
let
|
|
phpEmbedWithZts = php.override {
|
|
embedSupport = true;
|
|
ztsSupport = true;
|
|
staticSupport = stdenv.hostPlatform.isDarwin;
|
|
zendSignalsSupport = false;
|
|
zendMaxExecutionTimersSupport = stdenv.hostPlatform.isLinux;
|
|
};
|
|
phpUnwrapped = phpEmbedWithZts.unwrapped;
|
|
phpConfig = "${phpUnwrapped.dev}/bin/php-config";
|
|
pieBuild = stdenv.hostPlatform.isMusl;
|
|
in buildGoModule rec {
|
|
pname = "frankenphp";
|
|
version = "1.2.5";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "dunglas";
|
|
repo = "frankenphp";
|
|
rev = "v${version}";
|
|
hash = "sha256-X6lWbxgqj0wis/cljoNSh7AsH1zY30GTjSOAGXzUIek=";
|
|
};
|
|
|
|
sourceRoot = "${src.name}/caddy";
|
|
|
|
# frankenphp requires C code that would be removed with `go mod tidy`
|
|
# https://github.com/golang/go/issues/26366
|
|
proxyVendor = true;
|
|
vendorHash = "sha256-U2B0ok6TgqUPMwlnkzpPkJLG22S3VpoU80bWwZAeaJo=";
|
|
|
|
buildInputs = [ phpUnwrapped brotli ] ++ phpUnwrapped.buildInputs;
|
|
nativeBuildInputs = [ makeBinaryWrapper ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ pkg-config cctools darwin.autoSignDarwinBinariesHook ];
|
|
|
|
subPackages = [ "frankenphp" ];
|
|
|
|
tags = [ "cgo" "netgo" "ousergo" "static_build" ];
|
|
|
|
ldflags = [
|
|
"-s"
|
|
"-w"
|
|
"-X 'github.com/caddyserver/caddy/v2.CustomVersion=FrankenPHP ${version} PHP ${phpUnwrapped.version} Caddy'"
|
|
# pie mode is only available with pkgsMusl, it also automatically add -buildmode=pie to $GOFLAGS
|
|
] ++ (lib.optional pieBuild [ "-static-pie" ]);
|
|
|
|
preBuild = ''
|
|
export CGO_CFLAGS="$(${phpConfig} --includes)"
|
|
export CGO_LDFLAGS="-DFRANKENPHP_VERSION=${version} \
|
|
$(${phpConfig} --ldflags) \
|
|
$(${phpConfig} --libs)"
|
|
'' + lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
# replace hard-code homebrew path
|
|
substituteInPlace ../frankenphp.go \
|
|
--replace "-L/opt/homebrew/opt/libiconv/lib" "-L${libiconv}/lib"
|
|
'';
|
|
|
|
preFixup = ''
|
|
mkdir -p $out/lib
|
|
ln -s "${phpEmbedWithZts}/lib/php.ini" "$out/lib/frankenphp.ini"
|
|
|
|
wrapProgram $out/bin/frankenphp --set-default PHP_INI_SCAN_DIR $out/lib
|
|
'';
|
|
|
|
doCheck = false;
|
|
|
|
passthru = {
|
|
php = phpEmbedWithZts;
|
|
tests = {
|
|
# TODO: real NixOS test with Symfony application
|
|
version = testers.testVersion {
|
|
inherit version;
|
|
package = frankenphp;
|
|
command = "frankenphp version";
|
|
};
|
|
phpinfo = runCommand "php-cli-phpinfo" {
|
|
phpScript = writeText "phpinfo.php" ''
|
|
<?php phpinfo();
|
|
'';
|
|
} ''
|
|
${lib.getExe frankenphp} php-cli $phpScript > $out
|
|
'';
|
|
};
|
|
};
|
|
|
|
meta = {
|
|
changelog = "https://github.com/dunglas/frankenphp/releases/tag/v${version}";
|
|
description = "Modern PHP app server";
|
|
homepage = "https://github.com/dunglas/frankenphp";
|
|
license = lib.licenses.mit;
|
|
mainProgram = "frankenphp";
|
|
maintainers = with lib.maintainers; [ gaelreyrol shyim ];
|
|
platforms = lib.platforms.linux ++ lib.platforms.darwin;
|
|
};
|
|
}
|