mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-26 23:54:01 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
90 lines
3.0 KiB
Nix
90 lines
3.0 KiB
Nix
{ lib
|
||
, stdenv
|
||
, fetchurl
|
||
, removeReferencesTo
|
||
, autoreconfHook
|
||
, bison
|
||
, onigurumaSupport ? true
|
||
, oniguruma
|
||
}:
|
||
|
||
stdenv.mkDerivation rec {
|
||
pname = "jq";
|
||
version = "1.7.1";
|
||
|
||
# Note: do not use fetchpatch or fetchFromGitHub to keep this package available in __bootPackages
|
||
src = fetchurl {
|
||
url = "https://github.com/jqlang/jq/releases/download/jq-${version}/jq-${version}.tar.gz";
|
||
hash = "sha256-R4ycoSn9LjRD/icxS0VeIR4NjGC8j/ffcDhz3u7lgMI=";
|
||
};
|
||
|
||
outputs = [ "bin" "doc" "man" "dev" "lib" "out" ];
|
||
|
||
# https://github.com/jqlang/jq/issues/2871
|
||
postPatch = lib.optionalString stdenv.hostPlatform.isFreeBSD ''
|
||
substituteInPlace Makefile.am --replace-fail "tests/mantest" "" --replace-fail "tests/optionaltest" ""
|
||
'';
|
||
|
||
# Upstream script that writes the version that's eventually compiled
|
||
# and printed in `jq --help` relies on a .git directory which our src
|
||
# doesn't keep.
|
||
preConfigure = ''
|
||
echo "#!/bin/sh" > scripts/version
|
||
echo "echo ${version}" >> scripts/version
|
||
patchShebangs scripts/version
|
||
'';
|
||
|
||
# paranoid mode: make sure we never use vendored version of oniguruma
|
||
# Note: it must be run after automake, or automake will complain
|
||
preBuild = ''
|
||
rm -r ./modules/oniguruma
|
||
'';
|
||
|
||
buildInputs = lib.optionals onigurumaSupport [ oniguruma ];
|
||
nativeBuildInputs = [ removeReferencesTo autoreconfHook bison ];
|
||
|
||
# Darwin requires _REENTRANT be defined to use functions like `lgamma_r`.
|
||
# Otherwise, configure will detect that they’re in libm, but the build will fail
|
||
# with clang 16+ due to calls to undeclared functions.
|
||
# This is fixed upstream and can be removed once jq is updated (to 1.7 or an unstable release).
|
||
env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.hostPlatform.isDarwin (toString [
|
||
"-D_REENTRANT=1"
|
||
"-D_DARWIN_C_SOURCE=1"
|
||
]);
|
||
|
||
configureFlags = [
|
||
"--bindir=\${bin}/bin"
|
||
"--sbindir=\${bin}/bin"
|
||
"--datadir=\${doc}/share"
|
||
"--mandir=\${man}/share/man"
|
||
] ++ lib.optional (!onigurumaSupport) "--with-oniguruma=no"
|
||
# jq is linked to libjq:
|
||
++ lib.optional (!stdenv.hostPlatform.isDarwin) "LDFLAGS=-Wl,-rpath,\\\${libdir}";
|
||
|
||
# Break the dependency cycle: $dev refers to $bin via propagated-build-outputs, and
|
||
# $bin refers to $dev because of https://github.com/jqlang/jq/commit/583e4a27188a2db097dd043dd203b9c106bba100
|
||
postFixup = ''
|
||
remove-references-to -t "$dev" "$bin/bin/jq"
|
||
'';
|
||
|
||
doInstallCheck = true;
|
||
installCheckTarget = "check";
|
||
|
||
postInstallCheck = ''
|
||
$bin/bin/jq --help >/dev/null
|
||
$bin/bin/jq -r '.values[1]' <<< '{"values":["hello","world"]}' | grep '^world$' > /dev/null
|
||
'';
|
||
|
||
passthru = { inherit onigurumaSupport; };
|
||
|
||
meta = with lib; {
|
||
description = "Lightweight and flexible command-line JSON processor";
|
||
homepage = "https://jqlang.github.io/jq/";
|
||
license = licenses.mit;
|
||
maintainers = with maintainers; [ raskin artturin ncfavier ];
|
||
platforms = platforms.unix;
|
||
downloadPage = "https://jqlang.github.io/jq/download/";
|
||
mainProgram = "jq";
|
||
};
|
||
}
|