mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-23 15:33:13 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
70 lines
2.1 KiB
Nix
70 lines
2.1 KiB
Nix
{ stdenv, lib, fetchFromGitHub, libxslt, libaio, systemd, perl
|
|
, docbook_xsl, coreutils, lsof, makeWrapper, sg3_utils
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "tgt";
|
|
version = "1.0.93";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "fujita";
|
|
repo = pname;
|
|
rev = "v${version}";
|
|
hash = "sha256-0Yfah8VxmbBe1J1OMhG6kyHlGBBAed8F9uStjMs6S2E=";
|
|
};
|
|
|
|
nativeBuildInputs = [ libxslt docbook_xsl makeWrapper ];
|
|
|
|
buildInputs = [ systemd libaio ];
|
|
|
|
makeFlags = [
|
|
"PREFIX=${placeholder "out"}"
|
|
"SD_NOTIFY=1"
|
|
];
|
|
|
|
env.NIX_CFLAGS_COMPILE = toString [
|
|
# Needed with GCC 12
|
|
"-Wno-error=maybe-uninitialized"
|
|
];
|
|
|
|
hardeningDisable = lib.optionals stdenv.hostPlatform.isAarch64 [
|
|
# error: 'read' writing 1 byte into a region of size 0 overflows the destination
|
|
"fortify3"
|
|
];
|
|
|
|
installFlags = [
|
|
"sysconfdir=${placeholder "out"}/etc"
|
|
];
|
|
|
|
preConfigure = ''
|
|
sed -i 's|/usr/bin/||' doc/Makefile
|
|
sed -i 's|/usr/include/libaio.h|${libaio}/include/libaio.h|' usr/Makefile
|
|
sed -i 's|/usr/include/sys/|${stdenv.cc.libc.dev}/include/sys/|' usr/Makefile
|
|
sed -i 's|/usr/include/linux/|${stdenv.cc.libc.dev}/include/linux/|' usr/Makefile
|
|
'';
|
|
|
|
postInstall = ''
|
|
substituteInPlace $out/sbin/tgt-admin \
|
|
--replace "#!/usr/bin/perl" "#! ${perl.withPackages (p: [ p.ConfigGeneral ])}/bin/perl"
|
|
wrapProgram $out/sbin/tgt-admin --prefix PATH : \
|
|
${lib.makeBinPath [ lsof sg3_utils (placeholder "out") ]}
|
|
|
|
install -D scripts/tgtd.service $out/etc/systemd/system/tgtd.service
|
|
substituteInPlace $out/etc/systemd/system/tgtd.service \
|
|
--replace "/usr/sbin/tgt" "$out/bin/tgt"
|
|
|
|
# See https://bugzilla.redhat.com/show_bug.cgi?id=848942
|
|
sed -i '/ExecStart=/a ExecStartPost=${coreutils}/bin/sleep 5' $out/etc/systemd/system/tgtd.service
|
|
'';
|
|
|
|
enableParallelBuilding = true;
|
|
|
|
meta = with lib; {
|
|
description = "iSCSI Target daemon with RDMA support";
|
|
homepage = "https://github.com/fujita/tgt";
|
|
license = licenses.gpl2Only;
|
|
platforms = platforms.linux;
|
|
maintainers = with maintainers; [ johnazoidberg ];
|
|
};
|
|
}
|