mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-30 09:33:41 +00:00
8305aa29c2
Upstream binutils is missing sensible defaults for a few flags (notably linker personality) when cross-compiling to mips64el-*-*abi64. Most of the time this isn't an issue because packages that invoke the linker directly detect the flags from gcc's behavior (for example, libtool does this) and gcc has good code for detecting the right defaults. However some do not; notably nix, itself lacks this. Presumably Debian is working on upstreaming this, and has more clout than we do. I propose we carry their patch in the meantime. The patch is conditioned on stdenv.targetPlatform.isMips64n64 in order to avoid mass-rebuilds. Closes #164835.
211 lines
8.3 KiB
Nix
211 lines
8.3 KiB
Nix
let
|
||
execFormatIsELF = platform: platform.parsed.kernel.execFormat.name == "elf";
|
||
in
|
||
|
||
{ stdenv, lib, buildPackages
|
||
, fetchFromGitHub, fetchurl, zlib, autoreconfHook, gettext
|
||
# Enabling all targets increases output size to a multiple.
|
||
, withAllTargets ? false, libbfd, libopcodes
|
||
, enableShared ? !stdenv.hostPlatform.isStatic
|
||
, noSysDirs
|
||
, gold ? execFormatIsELF stdenv.targetPlatform
|
||
, bison ? null
|
||
, flex
|
||
, texinfo
|
||
, perl
|
||
, substitute
|
||
}:
|
||
|
||
# configure silently disables ld.gold if it's unsupported,
|
||
# so we need to make sure that intent matches result ourselves.
|
||
assert gold -> execFormatIsELF stdenv.targetPlatform;
|
||
|
||
# Note: this package is used for bootstrapping fetchurl, and thus
|
||
# cannot use fetchpatch! All mutable patches (generated by GitHub or
|
||
# cgit) that are needed here should be included directly in Nixpkgs as
|
||
# files.
|
||
|
||
let
|
||
reuseLibs = enableShared && withAllTargets;
|
||
|
||
version = "2.35.2";
|
||
basename = "binutils";
|
||
# The targetPrefix prepended to binary names to allow multiple binuntils on the
|
||
# PATH to both be usable.
|
||
targetPrefix = lib.optionalString (stdenv.targetPlatform != stdenv.hostPlatform)
|
||
"${stdenv.targetPlatform.config}-";
|
||
vc4-binutils-src = fetchFromGitHub {
|
||
owner = "itszor";
|
||
repo = "binutils-vc4";
|
||
rev = "708acc851880dbeda1dd18aca4fd0a95b2573b36";
|
||
sha256 = "1kdrz6fki55lm15rwwamn74fnqpy0zlafsida2zymk76n3656c63";
|
||
};
|
||
# HACK to ensure that we preserve source from bootstrap binutils to not rebuild LLVM
|
||
normal-src = stdenv.__bootPackages.binutils-unwrapped.src or (fetchurl {
|
||
url = "mirror://gnu/binutils/${basename}-${version}.tar.bz2";
|
||
sha256 = "sha256-z6dkTb7PRZHhNutAfBwdoWV4vSsD8MLorNzroZS7nWE=";
|
||
});
|
||
in
|
||
|
||
stdenv.mkDerivation {
|
||
pname = targetPrefix + basename;
|
||
inherit version;
|
||
|
||
src = if stdenv.targetPlatform.isVc4 then vc4-binutils-src else normal-src;
|
||
|
||
patches = [
|
||
# Make binutils output deterministic by default.
|
||
./deterministic.patch
|
||
|
||
# Help bfd choose between elf32-littlearm, elf32-littlearm-symbian, and
|
||
# elf32-littlearm-vxworks in favor of the first.
|
||
# https://github.com/NixOS/nixpkgs/pull/30484#issuecomment-345472766
|
||
./disambiguate-arm-targets.patch
|
||
|
||
# For some reason bfd ld doesn't search DT_RPATH when cross-compiling. It's
|
||
# not clear why this behavior was decided upon but it has the unfortunate
|
||
# consequence that the linker will fail to find transitive dependencies of
|
||
# shared objects when cross-compiling. Consequently, we are forced to
|
||
# override this behavior, forcing ld to search DT_RPATH even when
|
||
# cross-compiling.
|
||
./always-search-rpath.patch
|
||
|
||
# Fix quadratic slowdown in `strip` performance.
|
||
# See #129467 and https://sourceware.org/bugzilla/show_bug.cgi?id=28058
|
||
# Remove when we're on binutils > 2.36.1.
|
||
# The patch is downloaded from
|
||
# https://sourceware.org/git/?p=binutils-gdb.git;a=blobdiff_plain;f=bfd/elf.c;h=af62aadc3d446cd5b1f0201b207c90c22e7809b1;hp=36733e080dd9d9be28b576b246aaf5bd8c8569c7;hb=84fd26d8209e99fc3a432dd0b09b6c053de1ce65;hpb=abe2a28aaa7a2bfd0f3061c72a98eb898976b721
|
||
# which is the 2.36 backport (using `TRUE` instead of `true` of binutils master commit:
|
||
# https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=956ea65cd707707c0f725930214cbc781367a831
|
||
./bfd-elf-Dont-read-non-existing-secondary-relocs.patch
|
||
|
||
# Fix building plv8’s v8.
|
||
# https://github.com/NixOS/nixpkgs/issues/134190
|
||
# Obtained from: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=586e30940e640f67bd55bd72e1d1355a4faf8079
|
||
./gold-Update-GNU_PROPERTY_X86_XXX-macros.patch
|
||
|
||
./CVE-2020-35448.patch
|
||
./CVE-2021-3487.patch
|
||
./CVE-2021-45078.patch
|
||
] ++ lib.optional stdenv.targetPlatform.isiOS ./support-ios.patch
|
||
++ # This patch was suggested by Nick Clifton to fix
|
||
# https://sourceware.org/bugzilla/show_bug.cgi?id=16177
|
||
# It can be removed when that 7-year-old bug is closed.
|
||
# This binutils bug causes GHC to emit broken binaries on armv7, and
|
||
# indeed GHC will refuse to compile with a binutils suffering from it. See
|
||
# this comment for more information:
|
||
# https://gitlab.haskell.org/ghc/ghc/issues/4210#note_78333
|
||
lib.optional (stdenv.targetPlatform.isAarch32 && stdenv.hostPlatform.system != stdenv.targetPlatform.system) ./R_ARM_COPY.patch
|
||
++ lib.optional stdenv.targetPlatform.isWindows ./windres-locate-gcc.patch
|
||
++ lib.optional stdenv.targetPlatform.isMips64n64
|
||
# this patch is from debian:
|
||
# https://sources.debian.org/data/main/b/binutils/2.38-3/debian/patches/mips64-default-n64.diff
|
||
(if stdenv.targetPlatform.isMusl
|
||
then substitute { src = ./mips64-default-n64.patch; replacements = [ "--replace" "gnuabi64" "muslabi64" ]; }
|
||
else ./mips64-default-n64.patch);
|
||
|
||
outputs = [ "out" "info" "man" ];
|
||
|
||
depsBuildBuild = [ buildPackages.stdenv.cc ];
|
||
nativeBuildInputs = [
|
||
bison
|
||
perl
|
||
texinfo
|
||
] ++ (lib.optionals stdenv.targetPlatform.isiOS [
|
||
autoreconfHook
|
||
]) ++ lib.optionals stdenv.targetPlatform.isVc4 [ flex ];
|
||
buildInputs = [ zlib gettext ];
|
||
|
||
inherit noSysDirs;
|
||
|
||
preConfigure = ''
|
||
# Clear the default library search path.
|
||
if test "$noSysDirs" = "1"; then
|
||
echo 'NATIVE_LIB_DIRS=' >> ld/configure.tgt
|
||
fi
|
||
|
||
# Use symlinks instead of hard links to save space ("strip" in the
|
||
# fixup phase strips each hard link separately).
|
||
for i in binutils/Makefile.in gas/Makefile.in ld/Makefile.in gold/Makefile.in; do
|
||
sed -i "$i" -e 's|ln |ln -s |'
|
||
done
|
||
'';
|
||
|
||
# As binutils takes part in the stdenv building, we don't want references
|
||
# to the bootstrap-tools libgcc (as uses to happen on arm/mips)
|
||
NIX_CFLAGS_COMPILE = if stdenv.hostPlatform.isDarwin
|
||
then "-Wno-string-plus-int -Wno-deprecated-declarations"
|
||
else "-static-libgcc";
|
||
|
||
hardeningDisable = [ "format" "pie" ];
|
||
|
||
configurePlatforms = [ "build" "host" "target" ];
|
||
|
||
configureFlags =
|
||
(if enableShared then [ "--enable-shared" "--disable-static" ]
|
||
else [ "--disable-shared" "--enable-static" ])
|
||
++ lib.optional withAllTargets "--enable-targets=all"
|
||
++ [
|
||
"--enable-64-bit-bfd"
|
||
"--with-system-zlib"
|
||
|
||
"--enable-deterministic-archives"
|
||
"--disable-werror"
|
||
"--enable-fix-loongson2f-nop"
|
||
|
||
# Turn on --enable-new-dtags by default to make the linker set
|
||
# RUNPATH instead of RPATH on binaries. This is important because
|
||
# RUNPATH can be overriden using LD_LIBRARY_PATH at runtime.
|
||
"--enable-new-dtags"
|
||
|
||
# force target prefix. Some versions of binutils will make it empty
|
||
# if `--host` and `--target` are too close, even if Nixpkgs thinks
|
||
# the platforms are different (e.g. because not all the info makes
|
||
# the `config`). Other versions of binutils will always prefix if
|
||
# `--target` is passed, even if `--host` and `--target` are the same.
|
||
# The easiest thing for us to do is not leave it to chance, and force
|
||
# the program prefix to be what we want it to be.
|
||
"--program-prefix=${targetPrefix}"
|
||
] ++ lib.optionals gold [
|
||
"--enable-gold"
|
||
"--enable-plugins"
|
||
];
|
||
|
||
doCheck = false; # fails
|
||
|
||
postFixup = lib.optionalString reuseLibs ''
|
||
rm "$out"/lib/lib{bfd,opcodes}-${version}.so
|
||
ln -s '${lib.getLib libbfd}/lib/libbfd-${version}.so' "$out/lib/"
|
||
ln -s '${lib.getLib libopcodes}/lib/libopcodes-${version}.so' "$out/lib/"
|
||
'';
|
||
|
||
# else fails with "./sanity.sh: line 36: $out/bin/size: not found"
|
||
doInstallCheck = stdenv.buildPlatform == stdenv.hostPlatform && stdenv.hostPlatform == stdenv.targetPlatform;
|
||
|
||
enableParallelBuilding = true;
|
||
|
||
passthru = {
|
||
inherit targetPrefix;
|
||
hasGold = gold;
|
||
isGNU = true;
|
||
};
|
||
|
||
meta = with lib; {
|
||
description = "Tools for manipulating binaries (linker, assembler, etc.)";
|
||
longDescription = ''
|
||
The GNU Binutils are a collection of binary tools. The main
|
||
ones are `ld' (the GNU linker) and `as' (the GNU assembler).
|
||
They also include the BFD (Binary File Descriptor) library,
|
||
`gprof', `nm', `strip', etc.
|
||
'';
|
||
homepage = "https://www.gnu.org/software/binutils/";
|
||
license = licenses.gpl3Plus;
|
||
maintainers = with maintainers; [ ericson2314 ];
|
||
platforms = platforms.unix;
|
||
|
||
/* Give binutils a lower priority than gcc-wrapper to prevent a
|
||
collision due to the ld/as wrappers/symlinks in the latter. */
|
||
priority = 10;
|
||
};
|
||
}
|