mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-02-13 23:53:26 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
104 lines
4.0 KiB
Nix
104 lines
4.0 KiB
Nix
{ stdenv
|
|
, lib
|
|
, callPackage
|
|
, fetchurl
|
|
, nixosTests
|
|
, srcOnly
|
|
, isInsiders ? false
|
|
# sourceExecutableName is the name of the binary in the source archive over
|
|
# which we have no control and it is needed to run the insider version as
|
|
# documented in https://wiki.nixos.org/wiki/Visual_Studio_Code#Insiders_Build
|
|
# On MacOS the insider binary is still called code instead of code-insiders as
|
|
# of 2023-08-06.
|
|
, sourceExecutableName ? "code" + lib.optionalString (isInsiders && stdenv.hostPlatform.isLinux) "-insiders"
|
|
, commandLineArgs ? ""
|
|
, useVSCodeRipgrep ? stdenv.hostPlatform.isDarwin
|
|
}:
|
|
|
|
let
|
|
inherit (stdenv.hostPlatform) system;
|
|
throwSystem = throw "Unsupported system: ${system}";
|
|
|
|
plat = {
|
|
x86_64-linux = "linux-x64";
|
|
x86_64-darwin = "darwin";
|
|
aarch64-linux = "linux-arm64";
|
|
aarch64-darwin = "darwin-arm64";
|
|
armv7l-linux = "linux-armhf";
|
|
}.${system} or throwSystem;
|
|
|
|
archive_fmt = if stdenv.hostPlatform.isDarwin then "zip" else "tar.gz";
|
|
|
|
sha256 = {
|
|
x86_64-linux = "0475kwa3ym14l9ggaf2hg4lcrc0lpi9vchzj4sgj4c3606l9i1aa";
|
|
x86_64-darwin = "15sz42p7khzxpxii4zx14770kzyk4a3g1kwxjwvd46nxqjqciys4";
|
|
aarch64-linux = "14d5p764vx1ppi5f6b6v0wrn1wr3qqyfr6mpncjhnzr2pdss9fz0";
|
|
aarch64-darwin = "0kdh7a0nfpadhyn6cj89vw76hhbab4fg5wifbzdrjikwfg8jbd4b";
|
|
armv7l-linux = "1aqlpxyzjrf6qm0znyqbl7srn251f7ra5lj594b7906lxhirin3c";
|
|
}.${system} or throwSystem;
|
|
in
|
|
callPackage ./generic.nix rec {
|
|
# Please backport all compatible updates to the stable release.
|
|
# This is important for the extension ecosystem.
|
|
version = "1.93.1";
|
|
pname = "vscode" + lib.optionalString isInsiders "-insiders";
|
|
|
|
# This is used for VS Code - Remote SSH test
|
|
rev = "38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40";
|
|
|
|
executableName = "code" + lib.optionalString isInsiders "-insiders";
|
|
longName = "Visual Studio Code" + lib.optionalString isInsiders " - Insiders";
|
|
shortName = "Code" + lib.optionalString isInsiders " - Insiders";
|
|
inherit commandLineArgs useVSCodeRipgrep sourceExecutableName;
|
|
|
|
src = fetchurl {
|
|
name = "VSCode_${version}_${plat}.${archive_fmt}";
|
|
url = "https://update.code.visualstudio.com/${version}/${plat}/stable";
|
|
inherit sha256;
|
|
};
|
|
|
|
# We don't test vscode on CI, instead we test vscodium
|
|
tests = {};
|
|
|
|
sourceRoot = "";
|
|
|
|
# As tests run without networking, we need to download this for the Remote SSH server
|
|
vscodeServer = srcOnly {
|
|
name = "vscode-server-${rev}.tar.gz";
|
|
src = fetchurl {
|
|
name = "vscode-server-${rev}.tar.gz";
|
|
url = "https://update.code.visualstudio.com/commit:${rev}/server-linux-x64/stable";
|
|
sha256 = "0cxpv9q681nk7gjcs1msn2rnj8i86hlrkb0x4ja1id42aj4xwrqy";
|
|
};
|
|
};
|
|
|
|
tests = { inherit (nixosTests) vscode-remote-ssh; };
|
|
|
|
updateScript = ./update-vscode.sh;
|
|
|
|
# Editing the `code` binary within the app bundle causes the bundle's signature
|
|
# to be invalidated, which prevents launching starting with macOS Ventura, because VS Code is notarized.
|
|
# See https://eclecticlight.co/2022/06/17/app-security-changes-coming-in-ventura/ for more information.
|
|
dontFixup = stdenv.hostPlatform.isDarwin;
|
|
|
|
meta = with lib; {
|
|
description = ''
|
|
Open source source code editor developed by Microsoft for Windows,
|
|
Linux and macOS
|
|
'';
|
|
mainProgram = "code";
|
|
longDescription = ''
|
|
Open source source code editor developed by Microsoft for Windows,
|
|
Linux and macOS. It includes support for debugging, embedded Git
|
|
control, syntax highlighting, intelligent code completion, snippets,
|
|
and code refactoring. It is also customizable, so users can change the
|
|
editor's theme, keyboard shortcuts, and preferences
|
|
'';
|
|
homepage = "https://code.visualstudio.com/";
|
|
downloadPage = "https://code.visualstudio.com/Updates";
|
|
license = licenses.unfree;
|
|
maintainers = with maintainers; [ eadwu synthetica bobby285271 johnrtitor ];
|
|
platforms = [ "x86_64-linux" "x86_64-darwin" "aarch64-darwin" "aarch64-linux" "armv7l-linux" ];
|
|
};
|
|
}
|