mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-02-15 00:24:47 +00:00
![Artturin](/assets/img/avatar_default.png)
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
98 lines
2.7 KiB
Nix
98 lines
2.7 KiB
Nix
{ lib
|
|
, stdenv
|
|
, fetchurl
|
|
, pkg-config
|
|
, memstreamHook
|
|
, CoreAudio
|
|
, libobjc
|
|
, libjack2
|
|
, ncurses
|
|
, alsa-lib
|
|
, buildPackages
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "timidity";
|
|
version = "2.15.0";
|
|
|
|
src = fetchurl {
|
|
url = "mirror://sourceforge/timidity/TiMidity++-${version}.tar.bz2";
|
|
sha256 = "1xf8n6dqzvi6nr2asags12ijbj1lwk1hgl3s27vm2szib8ww07qn";
|
|
};
|
|
|
|
patches = [
|
|
./timidity-iA-Oj.patch
|
|
# Fixes misdetection of features by clang 16. The configure script itself is patched because
|
|
# it is old and does not work nicely with autoreconfHook.
|
|
./configure-compat.patch
|
|
];
|
|
|
|
nativeBuildInputs = [ pkg-config ]
|
|
++ lib.optionals (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isx86_64) [ memstreamHook ];
|
|
buildInputs = [
|
|
libjack2
|
|
ncurses
|
|
] ++ lib.optionals stdenv.hostPlatform.isLinux [
|
|
alsa-lib
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
CoreAudio
|
|
libobjc
|
|
];
|
|
|
|
configureFlags = [
|
|
"--enable-ncurses"
|
|
"lib_cv_va_copy=yes"
|
|
"lib_cv___va_copy=yes"
|
|
] ++ lib.optionals stdenv.hostPlatform.isLinux [
|
|
"--enable-audio=oss,alsa,jack"
|
|
"--enable-alsaseq"
|
|
"--with-default-output=alsa"
|
|
"lib_cv_va_val_copy=yes"
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
"--enable-audio=darwin,jack"
|
|
"lib_cv_va_val_copy=no"
|
|
"timidity_cv_ccoption_rdynamic=yes"
|
|
# These configure tests fail because of incompatible function pointer conversions.
|
|
"ac_cv_func_vprintf=yes"
|
|
"ac_cv_func_popen=yes"
|
|
"ac_cv_func_vsnprintf=yes"
|
|
"ac_cv_func_snprintf=yes"
|
|
"ac_cv_func_open_memstream=yes"
|
|
];
|
|
|
|
makeFlags = [
|
|
"AR=${stdenv.cc.targetPrefix}ar"
|
|
];
|
|
|
|
instruments = fetchurl {
|
|
url = "http://www.csee.umbc.edu/pub/midia/instruments.tar.gz";
|
|
sha256 = "0lsh9l8l5h46z0y8ybsjd4pf6c22n33jsjvapfv3rjlfnasnqw67";
|
|
};
|
|
|
|
preBuild = ''
|
|
# calcnewt has to be built with the host compiler.
|
|
${buildPackages.stdenv.cc}/bin/cc -o timidity/calcnewt -lm timidity/calcnewt.c
|
|
# Remove dependencies of calcnewt so it doesn't try to remake it.
|
|
sed -i 's/^\(calcnewt\$(EXEEXT):\).*/\1/g' timidity/Makefile
|
|
'';
|
|
|
|
# the instruments could be compressed (?)
|
|
postInstall = ''
|
|
mkdir -p $out/share/timidity/;
|
|
cp ${./timidity.cfg} $out/share/timidity/timidity.cfg
|
|
substituteAllInPlace $out/share/timidity/timidity.cfg
|
|
tar --strip-components=1 -xf $instruments -C $out/share/timidity/
|
|
'';
|
|
# This fixup step is unnecessary and fails on Darwin
|
|
dontRewriteSymlinks = stdenv.hostPlatform.isDarwin;
|
|
|
|
meta = with lib; {
|
|
homepage = "https://sourceforge.net/projects/timidity/";
|
|
license = licenses.gpl2Plus;
|
|
description = "Software MIDI renderer";
|
|
maintainers = [ maintainers.marcweber ];
|
|
platforms = platforms.unix;
|
|
mainProgram = "timidity";
|
|
};
|
|
}
|