mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-02 20:03:16 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
60 lines
1.5 KiB
Nix
60 lines
1.5 KiB
Nix
{ stdenv
|
|
, lib
|
|
, fetchFromGitHub
|
|
, fetchpatch
|
|
, autoreconfHook
|
|
, pkg-config
|
|
, libcap
|
|
, ncurses
|
|
, jansson
|
|
, withGtk ? false
|
|
, gtk3
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "mtr${lib.optionalString withGtk "-gui"}";
|
|
version = "0.95";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "traviscross";
|
|
repo = "mtr";
|
|
rev = "v${version}";
|
|
sha256 = "sha256-f5bL3IdXibIc1xXCuZHwcEV5vhypRE2mLsS3A8HW2QM=";
|
|
};
|
|
|
|
patches = [ (fetchpatch { # https://github.com/traviscross/mtr/pull/468
|
|
url = "https://github.com/traviscross/mtr/commit/5908af4c19188cb17b62f23368b6ef462831a0cb.patch";
|
|
hash = "sha256-rTydtU8+Wc4nGEKh1GOkhcpgME4hwsACy82gKPaIe64=";
|
|
}) ];
|
|
|
|
# we need this before autoreconfHook does its thing
|
|
postPatch = ''
|
|
echo ${version} > .tarball-version
|
|
'';
|
|
|
|
# and this after autoreconfHook has generated Makefile.in
|
|
preConfigure = ''
|
|
substituteInPlace Makefile.in \
|
|
--replace ' install-exec-hook' ""
|
|
'';
|
|
|
|
configureFlags = lib.optional (!withGtk) "--without-gtk";
|
|
|
|
nativeBuildInputs = [ autoreconfHook pkg-config ];
|
|
|
|
buildInputs = [ ncurses jansson ]
|
|
++ lib.optional withGtk gtk3
|
|
++ lib.optional stdenv.hostPlatform.isLinux libcap;
|
|
|
|
enableParallelBuilding = true;
|
|
|
|
meta = with lib; {
|
|
description = "Network diagnostics tool";
|
|
homepage = "https://www.bitwizard.nl/mtr/";
|
|
license = licenses.gpl2Only;
|
|
maintainers = with maintainers; [ koral orivej raskin globin ];
|
|
mainProgram = "mtr";
|
|
platforms = platforms.unix;
|
|
};
|
|
}
|