mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-25 08:23:09 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
160 lines
5.4 KiB
Nix
160 lines
5.4 KiB
Nix
{ lib
|
|
, stdenv
|
|
, buildPackages
|
|
, fetchurl
|
|
, updateAutotoolsGnuConfigScriptsHook
|
|
, bison
|
|
, util-linux
|
|
|
|
# patch for cygwin requires readline support
|
|
, interactive ? stdenv.hostPlatform.isCygwin
|
|
, readline
|
|
, withDocs ? false
|
|
, texinfo
|
|
, forFHSEnv ? false
|
|
|
|
, pkgsStatic
|
|
}:
|
|
|
|
let
|
|
upstreamPatches = import ./bash-5.2-patches.nix (nr: sha256: fetchurl {
|
|
url = "mirror://gnu/bash/bash-5.2-patches/bash52-${nr}";
|
|
inherit sha256;
|
|
});
|
|
in
|
|
stdenv.mkDerivation rec {
|
|
pname = "bash${lib.optionalString interactive "-interactive"}";
|
|
version = "5.2${patch_suffix}";
|
|
patch_suffix = "p${toString (builtins.length upstreamPatches)}";
|
|
|
|
src = fetchurl {
|
|
url = "mirror://gnu/bash/bash-${lib.removeSuffix patch_suffix version}.tar.gz";
|
|
sha256 = "sha256-oTnBZt9/9EccXgczBRZC7lVWwcyKSnjxRVg8XIGrMvs=";
|
|
};
|
|
|
|
hardeningDisable = [ "format" ]
|
|
# bionic libc is super weird and has issues with fortify outside of its own libc, check this comment:
|
|
# https://github.com/NixOS/nixpkgs/pull/192630#discussion_r978985593
|
|
# or you can check libc/include/sys/cdefs.h in bionic source code
|
|
++ lib.optional (stdenv.hostPlatform.libc == "bionic") "fortify";
|
|
|
|
outputs = [ "out" "dev" "man" "doc" "info" ];
|
|
|
|
separateDebugInfo = true;
|
|
|
|
env.NIX_CFLAGS_COMPILE = ''
|
|
-DSYS_BASHRC="/etc/bashrc"
|
|
-DSYS_BASH_LOGOUT="/etc/bash_logout"
|
|
'' + lib.optionalString (!forFHSEnv) ''
|
|
-DDEFAULT_PATH_VALUE="/no-such-path"
|
|
-DSTANDARD_UTILS_PATH="/no-such-path"
|
|
'' + ''
|
|
-DNON_INTERACTIVE_LOGIN_SHELLS
|
|
-DSSH_SOURCE_BASHRC
|
|
'';
|
|
|
|
patchFlags = [ "-p0" ];
|
|
|
|
patches = upstreamPatches ++ [
|
|
./pgrp-pipe-5.patch
|
|
# Apply parallel build fix pending upstream inclusion:
|
|
# https://savannah.gnu.org/patch/index.php?10373
|
|
# Had to fetch manually to workaround -p0 default.
|
|
./parallel.patch
|
|
# Fix `pop_var_context: head of shell_variables not a function context`.
|
|
./fix-pop-var-context-error.patch
|
|
];
|
|
|
|
configureFlags = [
|
|
# At least on Linux bash memory allocator has pathological performance
|
|
# in scenarios involving use of larger memory:
|
|
# https://lists.gnu.org/archive/html/bug-bash/2023-08/msg00052.html
|
|
# Various distributions default to system allocator. Let's nixpkgs
|
|
# do the same.
|
|
"--without-bash-malloc"
|
|
(if interactive then "--with-installed-readline" else "--disable-readline")
|
|
] ++ lib.optionals (stdenv.hostPlatform != stdenv.buildPlatform) [
|
|
"bash_cv_job_control_missing=nomissing"
|
|
"bash_cv_sys_named_pipes=nomissing"
|
|
"bash_cv_getcwd_malloc=yes"
|
|
# This check cannot be performed when cross compiling. The "yes"
|
|
# default is fine for static linking on Linux (weak symbols?) but
|
|
# not with OpenBSD, when it does clash with the regular `getenv`.
|
|
"bash_cv_getenv_redef=${if !(with stdenv.hostPlatform; isStatic && isOpenBSD) then "yes" else "no"}"
|
|
] ++ lib.optionals stdenv.hostPlatform.isCygwin [
|
|
"--without-libintl-prefix"
|
|
"--without-libiconv-prefix"
|
|
"--with-installed-readline"
|
|
"bash_cv_dev_stdin=present"
|
|
"bash_cv_dev_fd=standard"
|
|
"bash_cv_termcap_lib=libncurses"
|
|
] ++ lib.optionals (stdenv.hostPlatform.libc == "musl") [
|
|
"--disable-nls"
|
|
] ++ lib.optionals stdenv.hostPlatform.isFreeBSD [
|
|
# /dev/fd is optional on FreeBSD. we need it to work when built on a system
|
|
# with it and transferred to a system without it! This includes linux cross.
|
|
"bash_cv_dev_fd=absent"
|
|
];
|
|
|
|
strictDeps = true;
|
|
# Note: Bison is needed because the patches above modify parse.y.
|
|
depsBuildBuild = [ buildPackages.stdenv.cc ];
|
|
nativeBuildInputs = [ updateAutotoolsGnuConfigScriptsHook bison ]
|
|
++ lib.optional withDocs texinfo
|
|
++ lib.optional stdenv.hostPlatform.isDarwin stdenv.cc.bintools;
|
|
|
|
buildInputs = lib.optional interactive readline;
|
|
|
|
enableParallelBuilding = true;
|
|
|
|
makeFlags = lib.optionals stdenv.hostPlatform.isCygwin [
|
|
"LOCAL_LDFLAGS=-Wl,--export-all,--out-implib,libbash.dll.a"
|
|
"SHOBJ_LIBS=-lbash"
|
|
];
|
|
|
|
nativeCheckInputs = [ util-linux ];
|
|
doCheck = false; # dependency cycle, needs to be interactive
|
|
|
|
postInstall = ''
|
|
ln -s bash "$out/bin/sh"
|
|
rm -f $out/lib/bash/Makefile.inc
|
|
'';
|
|
|
|
postFixup =
|
|
if interactive
|
|
then ''
|
|
substituteInPlace "$out/bin/bashbug" \
|
|
--replace '#!/bin/sh' "#!$out/bin/bash"
|
|
''
|
|
# most space is taken by locale data
|
|
else ''
|
|
rm -rf "$out/share" "$out/bin/bashbug"
|
|
'';
|
|
|
|
passthru = {
|
|
shellPath = "/bin/bash";
|
|
tests.static = pkgsStatic.bash;
|
|
};
|
|
|
|
meta = with lib; {
|
|
homepage = "https://www.gnu.org/software/bash/";
|
|
description = "GNU Bourne-Again Shell, the de facto standard shell on Linux" + lib.optionalString interactive " (for interactive use)";
|
|
longDescription = ''
|
|
Bash is the shell, or command language interpreter, that will
|
|
appear in the GNU operating system. Bash is an sh-compatible
|
|
shell that incorporates useful features from the Korn shell
|
|
(ksh) and C shell (csh). It is intended to conform to the IEEE
|
|
POSIX P1003.2/ISO 9945.2 Shell and Tools standard. It offers
|
|
functional improvements over sh for both programming and
|
|
interactive use. In addition, most sh scripts can be run by
|
|
Bash without modification.
|
|
'';
|
|
license = licenses.gpl3Plus;
|
|
platforms = platforms.all;
|
|
# https://github.com/NixOS/nixpkgs/issues/333338
|
|
badPlatforms = [ lib.systems.inspect.patterns.isMinGW ];
|
|
maintainers = [ ];
|
|
mainProgram = "bash";
|
|
};
|
|
}
|