nixpkgs/pkgs/development/libraries/xdg-desktop-portal/default.nix
Jan Tojnar 9121a522fd xdg-desktop-portal: fix icon validation
Validation requires bubblewrap, but the current build system does not enforce it being present.

Additionally, the validation itself needs to have thumbnailer Nix store paths available in sandbox. Let’s add a patch from Flatpak and introduce a test verifying it still works.

This was probably broken since c3b07a052f
2022-10-11 18:52:33 +02:00

112 lines
2.4 KiB
Nix

{ lib
, acl
, autoreconfHook
, dbus
, fetchFromGitHub
, flatpak
, fuse3
, bubblewrap
, systemdMinimal
, geoclue2
, glib
, gsettings-desktop-schemas
, json-glib
, libportal
, libxml2
, nixosTests
, pipewire
, gdk-pixbuf
, librsvg
, python3
, pkg-config
, stdenv
, runCommand
, wrapGAppsHook
, enableGeoLocation ? true
}:
stdenv.mkDerivation (finalAttrs: {
pname = "xdg-desktop-portal";
version = "1.15.0";
outputs = [ "out" "installedTests" ];
src = fetchFromGitHub {
owner = "flatpak";
repo = "xdg-desktop-portal";
rev = finalAttrs.version;
sha256 = "sha256-Kw3zJeGwPfw1fDo8HsgYmrpgCk/PUvWZPRloKJNAJVc=";
};
patches = [
# The icon validator copied from Flatpak needs to access the gdk-pixbuf loaders
# in the Nix store and cannot bind FHS paths since those are not available on NixOS.
(runCommand "icon-validator.patch" { } ''
# Flatpak uses a different path
substitute "${flatpak.icon-validator-patch}" "$out" \
--replace "/icon-validator/validate-icon.c" "/src/validate-icon.c"
'')
];
nativeBuildInputs = [
autoreconfHook
libxml2
pkg-config
wrapGAppsHook
];
buildInputs = [
acl
dbus
flatpak
fuse3
bubblewrap
systemdMinimal # libsystemd
glib
gsettings-desktop-schemas
json-glib
libportal
pipewire
# For icon validator
gdk-pixbuf
librsvg
# For document-fuse installed test.
(python3.withPackages (pp: with pp; [
pygobject3
]))
] ++ lib.optionals enableGeoLocation [
geoclue2
];
configureFlags = [
"--enable-installed-tests"
] ++ lib.optionals (!enableGeoLocation) [
"--disable-geoclue"
];
makeFlags = [
"installed_testdir=${placeholder "installedTests"}/libexec/installed-tests/xdg-desktop-portal"
"installed_test_metadir=${placeholder "installedTests"}/share/installed-tests/xdg-desktop-portal"
];
passthru = {
tests = {
installedTests = nixosTests.installed-tests.xdg-desktop-portal;
validate-icon = runCommand "test-icon-validation" { } ''
${finalAttrs.finalPackage}/libexec/xdg-desktop-portal-validate-icon --sandbox 512 512 ${../../../applications/audio/zynaddsubfx/ZynLogo.svg} > "$out"
grep format=svg "$out"
'';
};
};
meta = with lib; {
description = "Desktop integration portals for sandboxed apps";
license = licenses.lgpl2Plus;
maintainers = with maintainers; [ jtojnar ];
platforms = platforms.linux;
};
})