mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 15:03:28 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
46 lines
1.3 KiB
Nix
46 lines
1.3 KiB
Nix
{ buildOctavePackage
|
|
, stdenv
|
|
, lib
|
|
, fetchurl
|
|
, pkg-config
|
|
, pcre2
|
|
}:
|
|
|
|
buildOctavePackage rec {
|
|
pname = "strings";
|
|
version = "1.3.1";
|
|
|
|
src = fetchurl {
|
|
url = "mirror://sourceforge/octave/${pname}-${version}.tar.gz";
|
|
sha256 = "sha256-9l5eYgzw5K85trRAJW9eMYZxvf0RDNxDlD0MtwrSCLc=";
|
|
};
|
|
|
|
nativeBuildInputs = [
|
|
pkg-config
|
|
];
|
|
|
|
buildInputs = [
|
|
pcre2
|
|
];
|
|
|
|
# The gripes library no longer exists.
|
|
# https://build.opensuse.org/package/view_file/openSUSE:Backports:SLE-15-SP3/octave-forge-strings/octave-forge-strings.spec
|
|
# toascii is a deprecated function. Has been fixed in recent commits, but has
|
|
# not been released yet.
|
|
# https://sourceforge.net/p/octave/strings/ci/2db1dbb75557eef94605cb4ac682783ab78ac8d8/
|
|
patchPhase = ''
|
|
sed -i -s -e 's/gripes.h/errwarn.h/' -e 's/gripe_/err_/g' src/*.cc
|
|
sed -i s/toascii/double/g inst/*.m
|
|
'';
|
|
|
|
meta = with lib; {
|
|
homepage = "https://octave.sourceforge.io/strings/index.html";
|
|
license = licenses.gpl3Plus;
|
|
# Claims to have a freebsd license, but I found none.
|
|
maintainers = with maintainers; [ KarlJoad ];
|
|
description = "Additional functions for manipulation and analysis of strings";
|
|
# Some pcre symbols claimed to be missing
|
|
broken = stdenv.hostPlatform.isDarwin;
|
|
};
|
|
}
|