mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 15:03:28 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
38 lines
1.2 KiB
Nix
38 lines
1.2 KiB
Nix
{ lib, stdenv, fetchFromGitHub, fetchpatch, pkg-config, which, cmake
|
|
, fftwSinglePrec, libsamplerate, qtbase
|
|
, darwin }:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "liblastfm-unstable";
|
|
version = "2019-08-23";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "lastfm";
|
|
repo = "liblastfm";
|
|
rev = "2ce2bfe1879227af8ffafddb82b218faff813db9";
|
|
sha256 = "1crih9xxf3rb109aqw12bjqv47z28lvlk2dpvyym5shf82nz6yd0";
|
|
};
|
|
|
|
patches = [(fetchpatch {
|
|
url = "https://github.com/lastfm/liblastfm/commit/9c5d072b55f2863310e40291677e6397e9cbc3c2.patch";
|
|
name = "0001-Remove-deprecated-staging-server-and-fix-test-for-QT5-at-Ubuntu-19.10.patch";
|
|
sha256 = "04r14prydxshjgfws3pjajjmp2msszhjjs1mjh8s66yg29vq620l";
|
|
})];
|
|
|
|
nativeBuildInputs = [ pkg-config which cmake ];
|
|
buildInputs = [ fftwSinglePrec libsamplerate qtbase ]
|
|
++ lib.optional stdenv.hostPlatform.isDarwin darwin.apple_sdk.frameworks.SystemConfiguration;
|
|
|
|
env.NIX_CFLAGS_COMPILE = lib.optionalString (stdenv.cc.isGNU && lib.versionAtLeast stdenv.cc.version "11") "-std=c++11";
|
|
|
|
dontWrapQtApps = true;
|
|
|
|
meta = with lib; {
|
|
homepage = "https://github.com/lastfm/liblastfm";
|
|
description = "Official LastFM library";
|
|
platforms = platforms.unix;
|
|
maintainers = [ ];
|
|
license = licenses.gpl3;
|
|
};
|
|
}
|