mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-01-10 15:04:44 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
56 lines
1.4 KiB
Nix
56 lines
1.4 KiB
Nix
{ lib
|
|
, stdenv
|
|
, fetchFromGitLab
|
|
, autoreconfHook
|
|
, pkg-config
|
|
, utilmacros
|
|
, libX11
|
|
, libXaw
|
|
, libXmu
|
|
, libXt
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "xedit";
|
|
version = "1.2.4";
|
|
|
|
src = fetchFromGitLab {
|
|
domain = "gitlab.freedesktop.org";
|
|
owner = "xorg/app";
|
|
repo = "xedit";
|
|
rev = "${pname}-${version}";
|
|
sha256 = "sha256-0vP+aR8QBXAqbULOLEs7QXsehk18BJ405qoelrcepwE=";
|
|
};
|
|
|
|
# ./lisp/mathimp.c:493:10: error: implicitly declaring library function 'finite' with type 'int (double)'
|
|
postPatch = lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
for i in $(find . -type f -name "*.c"); do
|
|
substituteInPlace $i --replace "finite" "isfinite"
|
|
done
|
|
'';
|
|
|
|
nativeBuildInputs = [ autoreconfHook pkg-config utilmacros ];
|
|
buildInputs = [
|
|
libX11
|
|
libXaw
|
|
libXmu
|
|
libXt
|
|
];
|
|
|
|
configureFlags = [
|
|
"--with-lispdir=$out/share/X11/xedit/lisp"
|
|
"--with-appdefaultdir=$out/share/X11/app-defaults"
|
|
];
|
|
|
|
meta = with lib; {
|
|
description = "Simple graphical text editor using Athena Widgets (Xaw)";
|
|
homepage = "https://gitlab.freedesktop.org/xorg/app/xedit";
|
|
license = with licenses; [ mit ];
|
|
maintainers = with maintainers; [ shamilton ];
|
|
platforms = platforms.unix;
|
|
# never built on aarch64-darwin, x86_64-darwin since first introduction in nixpkgs
|
|
broken = stdenv.hostPlatform.isDarwin;
|
|
mainProgram = "xedit";
|
|
};
|
|
}
|