nixpkgs/nixos/modules/services/x11/display-managers
Jan Tojnar af0cdb44a0 nixos/gdm: Fix fingerprint auth rules
We introduced the gdm-fingerprint.pam in 9d41fe6fcc.

We used the [upstream Arch config] as a template, which contains an extended control field that jumps over **one** immediately-following `auth` rule unless `pam_gdm.so` succeeds.

But we decided to not include `pam_gnome_keyring.so` so there was no rule to skip over, resulting in a broken control flow and the PAM module failing with “PAM bad jump in stack”, breaking the fingerprint authentication in GDM.

Let’s actually add `pam_gnome_keyring.so`, like the Arch config does. Because we are creating the PAM file using the `text` option, `security.pam.services.gdm-fingerprint.enableGnomeKeyring` does not do anything so we need to do it manually.

For the case where gnome-keyring is not enabled, we could add a no-op rule like `optional pam_permit.so` after `pam_gdm.so` so that the branching always has something to jump over but it will be simpler to just make the both conditional. There are no further `auth` rules that could benefit from `pam_gdm.so` doing something so it should be fine.

Unlike in Arch, we are not going to invoke `pam_gnome_keyring.so` in a `session` rule since that is already done by the included `login` module.

[upstream Arch config]: 81ee658c11/data/pam-arch/gdm-fingerprint.pam
2024-07-03 23:36:52 +02:00
..
lightdm-greeters gnome-themes-extra: Move from gnome scope to top-level 2024-07-01 08:26:49 +02:00
account-service-util.nix
default.nix nixos/xserver: Remove with statements 2024-05-02 23:20:02 +02:00
gdm.nix nixos/gdm: Fix fingerprint auth rules 2024-07-03 23:36:52 +02:00
lightdm.nix nixos/lightdm-greeters/lomiri: init 2024-04-14 21:38:32 +02:00
set-session.py
slim.nix
startx.nix nixos: remove all uses of lib.mdDoc 2024-04-13 10:07:35 -07:00
sx.nix nixos: remove all uses of lib.mdDoc 2024-04-13 10:07:35 -07:00
xpra.nix nixos: remove all uses of lib.mdDoc 2024-04-13 10:07:35 -07:00