mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-24 06:33:42 +00:00
45a04ed6d4
This caused none of these flags to have any effect. That's because
the configure command looked like this:
./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \
--without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
with one giant flag '--without-test --without-contrib...', containing
internal spaces.
This can be seen in `nix log nixpkgs.gbsplay`, in this line:
configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
and then in the fact that features like "devdsp" and "midi" are listed
as enabled in later output, and source files like plugout_midi.c are
included in the build.
I don't have a real opinion on whether it's better to have these flags
or not, but it's clear the author's intention was to pass them. So,
fix the attr name so they get passed.
29 lines
766 B
Nix
29 lines
766 B
Nix
{ stdenv, fetchFromGitHub, libpulseaudio }:
|
|
|
|
stdenv.mkDerivation {
|
|
name = "gbsplay-2016-12-17";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "mmitch";
|
|
repo = "gbsplay";
|
|
rev = "2c4486e17fd4f4cdea8c3fd79ae898c892616b70";
|
|
sha256 = "1214j67sr87zfhvym41cw2g823fmqh4hr451r7y1s9ql3jpjqhpz";
|
|
};
|
|
|
|
buildInputs = [ libpulseaudio ];
|
|
|
|
configureFlags =
|
|
[ "--without-test" "--without-contrib" "--disable-devdsp"
|
|
"--enable-pulse" "--disable-alsa" "--disable-midi"
|
|
"--disable-nas" "--disable-dsound" "--disable-i18n" ];
|
|
|
|
makeFlags = [ "tests=" ];
|
|
|
|
meta = with stdenv.lib; {
|
|
description = "gameboy sound player";
|
|
license = licenses.gpl1;
|
|
platforms = ["i686-linux" "x86_64-linux"];
|
|
maintainers = with maintainers; [ dasuxullebt ];
|
|
};
|
|
}
|