mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-04 12:53:05 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
74 lines
1.3 KiB
Nix
74 lines
1.3 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
buildPythonPackage,
|
|
fetchFromGitHub,
|
|
pytestCheckHook,
|
|
p7zip,
|
|
cabextract,
|
|
zip,
|
|
lzip,
|
|
zpaq,
|
|
gnutar,
|
|
unar, # Free alternative to unrar
|
|
gnugrep,
|
|
diffutils,
|
|
file,
|
|
gzip,
|
|
bzip2,
|
|
xz,
|
|
}:
|
|
|
|
let
|
|
compression-utilities = [
|
|
p7zip
|
|
gnutar
|
|
unar
|
|
cabextract
|
|
zip
|
|
lzip
|
|
zpaq
|
|
gzip
|
|
gnugrep
|
|
diffutils
|
|
bzip2
|
|
file
|
|
xz
|
|
];
|
|
in
|
|
buildPythonPackage rec {
|
|
pname = "patool";
|
|
version = "2.1.1";
|
|
format = "setuptools";
|
|
|
|
#pypi doesn't have test data
|
|
src = fetchFromGitHub {
|
|
owner = "wummel";
|
|
repo = pname;
|
|
rev = "upstream/${version}";
|
|
hash = "sha256-B2P6JldMOAxr4WS+wST+kRVvEm41zH3Nh5LLKoFOws4=";
|
|
};
|
|
|
|
postPatch = ''
|
|
substituteInPlace patoolib/util.py \
|
|
--replace "path = None" 'path = os.environ["PATH"] + ":${lib.makeBinPath compression-utilities}"'
|
|
'';
|
|
|
|
nativeCheckInputs = [ pytestCheckHook ] ++ compression-utilities;
|
|
|
|
disabledTests = [
|
|
"test_unzip"
|
|
"test_unzip_file"
|
|
"test_zip"
|
|
"test_zip_file"
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [ "test_ar" ];
|
|
|
|
meta = with lib; {
|
|
description = "portable archive file manager";
|
|
mainProgram = "patool";
|
|
homepage = "https://wummel.github.io/patool/";
|
|
license = licenses.gpl3;
|
|
maintainers = with maintainers; [ marius851000 ];
|
|
};
|
|
}
|