mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-02-09 21:53:24 +00:00
4f0dadbf38
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
56 lines
1.6 KiB
Nix
56 lines
1.6 KiB
Nix
{
|
|
lib,
|
|
makeSetupHook,
|
|
zig,
|
|
}:
|
|
|
|
makeSetupHook {
|
|
name = "zig-hook";
|
|
|
|
propagatedBuildInputs = [ zig ];
|
|
|
|
substitutions = {
|
|
# This zig_default_flags below is meant to avoid CPU feature impurity in
|
|
# Nixpkgs. However, this flagset is "unstable": it is specifically meant to
|
|
# be controlled by the upstream development team - being up to that team
|
|
# exposing or not that flags to the outside (especially the package manager
|
|
# teams).
|
|
|
|
# Because of this hurdle, @andrewrk from Zig Software Foundation proposed
|
|
# some solutions for this issue. Hopefully they will be implemented in
|
|
# future releases of Zig. When this happens, this flagset should be
|
|
# revisited accordingly.
|
|
|
|
# Below are some useful links describing the discovery process of this 'bug'
|
|
# in Nixpkgs:
|
|
|
|
# https://github.com/NixOS/nixpkgs/issues/169461
|
|
# https://github.com/NixOS/nixpkgs/issues/185644
|
|
# https://github.com/NixOS/nixpkgs/pull/197046
|
|
# https://github.com/NixOS/nixpkgs/pull/241741#issuecomment-1624227485
|
|
# https://github.com/ziglang/zig/issues/14281#issuecomment-1624220653
|
|
|
|
zig_default_flags =
|
|
let
|
|
releaseType =
|
|
if lib.versionAtLeast zig.version "0.12" then
|
|
"--release=safe"
|
|
else if lib.versionAtLeast zig.version "0.11" then
|
|
"-Doptimize=ReleaseSafe"
|
|
else
|
|
"-Drelease-safe=true";
|
|
in
|
|
[
|
|
"-Dcpu=baseline"
|
|
releaseType
|
|
];
|
|
};
|
|
|
|
passthru = { inherit zig; };
|
|
|
|
meta = {
|
|
description = "Setup hook for using the Zig compiler in Nixpkgs";
|
|
inherit (zig.meta) maintainers platforms broken;
|
|
};
|
|
} ./setup-hook.sh
|