mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-15 02:03:01 +00:00
5feec424de
This diff regenerates the package sets for `codimd` and `codemirror` using NodeJS 8 to get rid of the deprecated[1] `nodejs-6_x`. Additionally the following issues had to be fixed during the update: * The package `js-sequence-diagram` has been removed from the NPM registry and was replaced by a security holding package[2]. The package was published by a third-party (upstream only supports bower builds), so it's unclear whether the package will re-appear[3]. As the tarballs still exist (and the hash didn't change), the package will be loaded manually into the build env. * For the babel-related packages, `dontNpmInstall` will be set for `node2nix` installs as some of those packages bundle a `package-lock.json` that triggers `ENOTCACHED` errors for optional dependencies[4]. For now it should be sufficient to use NodeJS 8 (`codimd` v1.2.x doesn't support NodeJS 10), in the long term we probably want to use `yarn2nix` here with NodeJS 10. This is much rather a fix to get rid of another NodeJS 6 dependency. [1] `nodejs-6_x` is about to be deprecated, see #58976 [2] https://www.npmjs.com/package/js-sequence-diagrams, https://github.com/npm/security-holder [3] https://github.com/bramp/js-sequence-diagrams/issues/212 [4] https://github.com/svanderburg/node2nix/issues/134
199 lines
5.8 KiB
Nix
199 lines
5.8 KiB
Nix
{ stdenv, pkgs, buildEnv, fetchFromGitHub, makeWrapper
|
|
, fetchpatch, nodejs-8_x, phantomjs2, runtimeShell }:
|
|
let
|
|
nodePackages = let
|
|
# Some packages fail to install with ENOTCACHED due to a mistakenly added
|
|
# package-lock.json that bundles optional dependencies not resolved with `node2nix.
|
|
# See also https://github.com/svanderburg/node2nix/issues/134
|
|
dontInstall = n: v:
|
|
if builtins.match ".*babel.*" n == null
|
|
then v
|
|
else v.override { dontNpmInstall = true; };
|
|
|
|
packages = stdenv.lib.mapAttrs (dontInstall) (
|
|
import ./node.nix {
|
|
inherit pkgs;
|
|
system = stdenv.system;
|
|
}
|
|
);
|
|
in packages // {
|
|
"js-url-^2.3.0" = packages."js-url-^2.3.0".overrideAttrs (_: {
|
|
# Don't download chromium (this isn't needed anyway for our case).
|
|
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD = "1";
|
|
});
|
|
};
|
|
|
|
addPhantomjs = (pkgs:
|
|
map (pkg: pkg.override ( oldAttrs: {
|
|
buildInputs = oldAttrs.buildInputs or [] ++ [ phantomjs2 ];
|
|
})) pkgs);
|
|
|
|
drvName = drv: (builtins.parseDrvName drv).name;
|
|
|
|
linkNodeDeps = ({ pkg, deps, name ? "" }:
|
|
let
|
|
targetModule = if name != "" then name else drvName pkg;
|
|
in nodePackages.${pkg}.override (oldAttrs: {
|
|
postInstall = ''
|
|
mkdir -p $out/lib/node_modules/${targetModule}/node_modules
|
|
${stdenv.lib.concatStringsSep "\n" (map (dep: ''
|
|
ln -s ${nodePackages.${dep}}/lib/node_modules/${drvName dep} \
|
|
$out/lib/node_modules/${targetModule}/node_modules/${drvName dep}
|
|
'') deps
|
|
)}
|
|
'';
|
|
})
|
|
);
|
|
|
|
filterNodePackagesToList = (filterPkgs: allPkgs:
|
|
stdenv.lib.mapAttrsToList (_: v: v) (
|
|
stdenv.lib.filterAttrs (n: _:
|
|
! builtins.elem (drvName n) filterPkgs
|
|
) allPkgs)
|
|
);
|
|
|
|
# add phantomjs to buildInputs
|
|
pkgsWithPhantomjs = (addPhantomjs (map (
|
|
p: nodePackages.${p}
|
|
) [
|
|
"js-url-^2.3.0"
|
|
"markdown-pdf-^8.0.0"
|
|
]));
|
|
|
|
# link extra dependencies to lib/node_modules
|
|
pkgsWithExtraDeps = map (args:
|
|
linkNodeDeps args ) [
|
|
{ pkg = "select2-^3.5.2-browserify";
|
|
deps = [ "url-loader-^0.5.7" ]; }
|
|
{ pkg = "ionicons-~2.0.1";
|
|
deps = [ "url-loader-^0.5.7" "file-loader-^0.9.0" ]; }
|
|
{ pkg = "font-awesome-^4.7.0";
|
|
deps = [ "url-loader-^0.5.7" "file-loader-^0.9.0" ]; }
|
|
{ pkg = "bootstrap-^3.3.7";
|
|
deps = [ "url-loader-^0.5.7" "file-loader-^0.9.0" ]; }
|
|
{ pkg = "markdown-it-^8.2.2";
|
|
deps = [ "json-loader-^0.5.4" ]; }
|
|
{ pkg = "markdown-it-emoji-^1.3.0";
|
|
deps = [ "json-loader-^0.5.4" ]; }
|
|
{ pkg = "raphael-git+https://github.com/dmitrybaranovskiy/raphael";
|
|
deps = [ "eve-^0.5.4" ];
|
|
name = "raphael"; }
|
|
];
|
|
|
|
codemirror = pkgs.callPackage ./CodeMirror { };
|
|
|
|
nodeEnv = buildEnv {
|
|
name = "codimd-env";
|
|
paths = pkgsWithPhantomjs ++ pkgsWithExtraDeps ++ [
|
|
codemirror
|
|
|
|
# `js-sequence-diagrams` has been removed from the registry
|
|
# and replaced by a security holding package (the tarballs weren't published by
|
|
# upstream as upstream only supports bower,
|
|
# see https://github.com/bramp/js-sequence-diagrams/issues/212).
|
|
#
|
|
# As the tarballs are still there, we build this manually for now until codimd's upstream
|
|
# has resolved the issue.
|
|
(import ./js-sequence-diagrams {
|
|
inherit pkgs;
|
|
nodejs = nodejs-8_x;
|
|
extraNodePackages = {
|
|
lodash = nodePackages."lodash-^4.17.4";
|
|
eve = nodePackages."eve-^0.5.4";
|
|
};
|
|
})
|
|
] ++ filterNodePackagesToList [
|
|
"bootstrap"
|
|
"codemirror-git+https://github.com/hackmdio/CodeMirror.git"
|
|
"font-awesome"
|
|
"ionicons"
|
|
"js-url"
|
|
"markdown-it"
|
|
"markdown-pdf"
|
|
"node-uuid"
|
|
"raphael-git+https://github.com/dmitrybaranovskiy/raphael"
|
|
"select2-browserify"
|
|
"url-loader"
|
|
] nodePackages;
|
|
};
|
|
|
|
name = "codimd-${version}";
|
|
version = "1.2.0";
|
|
|
|
src = stdenv.mkDerivation {
|
|
name = "${name}-src";
|
|
inherit version;
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "hackmdio";
|
|
repo = "codimd";
|
|
rev = version;
|
|
sha256 = "003v90g5sxxjv5smxvz6y6bq2ny0xpxhsx2cdgkvj7jla243v48s";
|
|
};
|
|
|
|
dontBuild = true;
|
|
|
|
installPhase = ''
|
|
mkdir $out
|
|
cp -R . $out
|
|
'';
|
|
};
|
|
in
|
|
stdenv.mkDerivation rec {
|
|
inherit name version src;
|
|
|
|
nativeBuildInputs = [ makeWrapper ];
|
|
buildInputs = [ nodejs-8_x ];
|
|
|
|
NODE_PATH = "${nodeEnv}/lib/node_modules";
|
|
|
|
patches = [
|
|
(fetchpatch { # fixes for configurable paths
|
|
url = "https://patch-diff.githubusercontent.com/raw/hackmdio/codimd/pull/940.patch";
|
|
sha256 = "0w1cvnp3k1n8690gzlrfijisn182i0v8psjs3df394rfx2347xyp";
|
|
})
|
|
];
|
|
|
|
postPatch = ''
|
|
# due to the `dontNpmInstall` workaround, `node_modules/.bin` isn't created anymore.
|
|
substituteInPlace package.json \
|
|
--replace "webpack --config" "${nodejs-8_x}/bin/node ./node_modules/webpack/bin/webpack.js --config"
|
|
'';
|
|
|
|
buildPhase = ''
|
|
ln -s ${nodeEnv}/lib/node_modules node_modules
|
|
npm run build
|
|
'';
|
|
|
|
installPhase = ''
|
|
mkdir -p $out/bin
|
|
cat > $out/bin/codimd <<EOF
|
|
#!${runtimeShell}
|
|
${nodejs-8_x}/bin/node $out/app.js
|
|
EOF
|
|
cp -R {app.js,bin,lib,locales,package.json,public} $out/
|
|
'';
|
|
|
|
postFixup = ''
|
|
chmod +x $out/bin/codimd
|
|
wrapProgram $out/bin/codimd \
|
|
--set NODE_PATH "${nodeEnv}/lib/node_modules"
|
|
'';
|
|
|
|
passthru = {
|
|
sequelize = pkgs.writeScript "codimd-sequelize" ''
|
|
#!${pkgs.bash}/bin/bash -e
|
|
export NODE_PATH="${nodeEnv}/lib/node_modules"
|
|
exec -a "$0" "${nodeEnv}/lib/node_modules/sequelize-cli/bin/sequelize" "$@"
|
|
'';
|
|
};
|
|
|
|
meta = with stdenv.lib; {
|
|
description = "Realtime collaborative markdown notes on all platforms";
|
|
license = licenses.agpl3;
|
|
homepage = https://github.com/hackmdio/codimd;
|
|
maintainers = with maintainers; [ willibutz ma27 ];
|
|
platforms = platforms.linux;
|
|
};
|
|
}
|