mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-30 19:02:57 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
81 lines
2.1 KiB
Nix
81 lines
2.1 KiB
Nix
{ lib, stdenv
|
|
, fetchFromGitHub
|
|
, fetchpatch
|
|
, autoconf
|
|
, bison
|
|
, bzip2
|
|
, flex
|
|
, gperf
|
|
, ncurses
|
|
, perl
|
|
, python3
|
|
, readline
|
|
, zlib
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "iverilog";
|
|
version = "12.0";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "steveicarus";
|
|
repo = pname;
|
|
rev = "v${lib.replaceStrings ["."] ["_"] version}";
|
|
hash = "sha256-J9hedSmC6mFVcoDnXBtaTXigxrSCFa2AhhFd77ueo7I=";
|
|
};
|
|
|
|
nativeBuildInputs = [ autoconf bison flex gperf ];
|
|
|
|
CC_FOR_BUILD="${stdenv.cc}/bin/cc";
|
|
CXX_FOR_BUILD="${stdenv.cc}/bin/c++";
|
|
|
|
patches = [
|
|
# NOTE(jleightcap): `-Werror=format-security` warning patched shortly after release, backport the upstream fix
|
|
(fetchpatch {
|
|
name = "format-security";
|
|
url = "https://github.com/steveicarus/iverilog/commit/23e51ef7a8e8e4ba42208936e0a6a25901f58c65.patch";
|
|
hash = "sha256-fMWfBsCl2fuXe+6AR10ytb8QpC84bXlP5RSdrqsWzEk=";
|
|
})
|
|
];
|
|
|
|
buildInputs = [ bzip2 ncurses readline zlib ];
|
|
|
|
preConfigure = "sh autoconf.sh";
|
|
|
|
enableParallelBuilding = true;
|
|
|
|
env = lib.optionalAttrs stdenv.hostPlatform.isDarwin {
|
|
NIX_CFLAGS_COMPILE = "-Wno-error=implicit-function-declaration";
|
|
};
|
|
|
|
# NOTE(jleightcap): the `make check` target only runs a "Hello, World"-esque sanity check.
|
|
# the tests in the doInstallCheck phase run a full regression test suite.
|
|
# however, these tests currently fail upstream on aarch64
|
|
# (see https://github.com/steveicarus/iverilog/issues/917)
|
|
# so disable the full suite for now.
|
|
doCheck = true;
|
|
doInstallCheck = !stdenv.hostPlatform.isAarch64;
|
|
|
|
nativeInstallCheckInputs = [
|
|
perl
|
|
(python3.withPackages (pp: with pp; [
|
|
docopt
|
|
]))
|
|
];
|
|
|
|
installCheckPhase = ''
|
|
runHook preInstallCheck
|
|
export PATH="$PATH:$out/bin"
|
|
sh .github/test.sh
|
|
runHook postInstallCheck
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "Icarus Verilog compiler";
|
|
homepage = "http://iverilog.icarus.com/"; # https does not work
|
|
license = with licenses; [ gpl2Plus lgpl21Plus ];
|
|
maintainers = with maintainers; [ thoughtpolice ];
|
|
platforms = platforms.all;
|
|
};
|
|
}
|