mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-29 02:13:23 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
26 lines
635 B
Nix
26 lines
635 B
Nix
{ lib, buildDunePackage, dune-configurator, pkg-config, callPackage
|
|
, ffmpeg-base ? callPackage ./base.nix { }
|
|
, ffmpeg-avutil, ffmpeg-avcodec, ffmpeg
|
|
, stdenv
|
|
, VideoToolbox
|
|
}:
|
|
|
|
buildDunePackage {
|
|
pname = "ffmpeg-swresample";
|
|
|
|
minimalOCamlVersion = "4.08";
|
|
|
|
inherit (ffmpeg-base) version src;
|
|
|
|
nativeBuildInputs = [ pkg-config ];
|
|
buildInputs = [ dune-configurator ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ VideoToolbox ];
|
|
propagatedBuildInputs = [ ffmpeg-avutil ffmpeg-avcodec ffmpeg.dev ];
|
|
|
|
doCheck = true;
|
|
|
|
meta = ffmpeg-base.meta // {
|
|
description = "Bindings for the ffmpeg swresample library";
|
|
};
|
|
|
|
}
|