mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-11 08:13:04 +00:00
2ad2295bb3
In NixOS/nixpkgs#290081 it came to attention that autoPatchelfHook is one of if not the only hook in Nixpkgs that is a multiline string expression. Almost all hooks are functions, which guard with something like `if [ -z "${dontDoTheThing-}" ]; then ...` in the function, or single-line strings which include that guard inline and then call the real function, e.g. `if [ -z "${dontDoTheThing-} ]; then doTheThing; fi`. This commit moves autoPatchelfHook to the former, which seems to be the most common style now.
109 lines
3.9 KiB
Bash
109 lines
3.9 KiB
Bash
# shellcheck shell=bash
|
|
|
|
declare -a autoPatchelfLibs
|
|
declare -a extraAutoPatchelfLibs
|
|
|
|
gatherLibraries() {
|
|
autoPatchelfLibs+=("$1/lib")
|
|
}
|
|
|
|
# shellcheck disable=SC2154
|
|
# (targetOffset is referenced but not assigned.)
|
|
addEnvHooks "$targetOffset" gatherLibraries
|
|
|
|
# Can be used to manually add additional directories with shared object files
|
|
# to be included for the next autoPatchelf invocation.
|
|
addAutoPatchelfSearchPath() {
|
|
local -a findOpts=()
|
|
|
|
while [ $# -gt 0 ]; do
|
|
case "$1" in
|
|
--) shift; break;;
|
|
--no-recurse) shift; findOpts+=("-maxdepth" 1);;
|
|
--*)
|
|
echo "addAutoPatchelfSearchPath: ERROR: Invalid command line" \
|
|
"argument: $1" >&2
|
|
return 1;;
|
|
*) break;;
|
|
esac
|
|
done
|
|
|
|
local dir=
|
|
while IFS= read -r -d '' dir; do
|
|
extraAutoPatchelfLibs+=("$dir")
|
|
done < <(find "$@" "${findOpts[@]}" \! -type d \
|
|
\( -name '*.so' -o -name '*.so.*' \) -print0 \
|
|
| sed -z 's#/[^/]*$##' \
|
|
| uniq -z
|
|
)
|
|
}
|
|
|
|
|
|
autoPatchelf() {
|
|
local norecurse=
|
|
while [ $# -gt 0 ]; do
|
|
case "$1" in
|
|
--) shift; break;;
|
|
--no-recurse) shift; norecurse=1;;
|
|
--*)
|
|
echo "autoPatchelf: ERROR: Invalid command line" \
|
|
"argument: $1" >&2
|
|
return 1;;
|
|
*) break;;
|
|
esac
|
|
done
|
|
|
|
if [ -n "$__structuredAttrs" ]; then
|
|
local ignoreMissingDepsArray=( "${autoPatchelfIgnoreMissingDeps[@]}" )
|
|
local appendRunpathsArray=( "${appendRunpaths[@]}" )
|
|
local runtimeDependenciesArray=( "${runtimeDependencies[@]}" )
|
|
local patchelfFlagsArray=( "${patchelfFlags[@]}" )
|
|
else
|
|
readarray -td' ' ignoreMissingDepsArray < <(echo -n "$autoPatchelfIgnoreMissingDeps")
|
|
local appendRunpathsArray=($appendRunpaths)
|
|
local runtimeDependenciesArray=($runtimeDependencies)
|
|
local patchelfFlagsArray=($patchelfFlags)
|
|
fi
|
|
|
|
# Check if ignoreMissingDepsArray contains "1" and if so, replace it with
|
|
# "*", printing a deprecation warning.
|
|
for dep in "${ignoreMissingDepsArray[@]}"; do
|
|
if [ "$dep" == "1" ]; then
|
|
echo "autoPatchelf: WARNING: setting 'autoPatchelfIgnoreMissingDeps" \
|
|
"= true;' is deprecated and will be removed in a future release." \
|
|
"Use 'autoPatchelfIgnoreMissingDeps = [ \"*\" ];' instead." >&2
|
|
ignoreMissingDepsArray=( "*" )
|
|
break
|
|
fi
|
|
done
|
|
|
|
@pythonInterpreter@ @autoPatchelfScript@ \
|
|
${norecurse:+--no-recurse} \
|
|
--ignore-missing "${ignoreMissingDepsArray[@]}" \
|
|
--paths "$@" \
|
|
--libs "${autoPatchelfLibs[@]}" \
|
|
"${extraAutoPatchelfLibs[@]}" \
|
|
--runtime-dependencies "${runtimeDependenciesArray[@]/%//lib}" \
|
|
--append-rpaths "${appendRunpathsArray[@]}" \
|
|
--extra-args "${patchelfFlagsArray[@]}"
|
|
}
|
|
|
|
autoPatchelfPostFixup() {
|
|
# XXX: This should ultimately use fixupOutputHooks but we currently don't have
|
|
# a way to enforce the order. If we have $runtimeDependencies set, the setup
|
|
# hook of patchelf is going to ruin everything and strip out those additional
|
|
# RPATHs.
|
|
#
|
|
# So what we do here is basically run in postFixup and emulate the same
|
|
# behaviour as fixupOutputHooks because the setup hook for patchelf is run in
|
|
# fixupOutput and the postFixup hook runs later.
|
|
if [[ -z "${dontAutoPatchelf-}" ]]; then
|
|
autoPatchelf -- $(for output in $(getAllOutputNames); do
|
|
[ -e "${!output}" ] || continue
|
|
echo "${!output}"
|
|
done)
|
|
fi
|
|
}
|
|
|
|
postFixupHooks+=(autoPatchelfPostFixup)
|