mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-01-23 05:14:45 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
59 lines
2.2 KiB
Nix
59 lines
2.2 KiB
Nix
{ lib, stdenv, fetchFromGitHub, cmake, libGLU, libGL, libglut
|
|
, Cocoa, OpenGL
|
|
}:
|
|
|
|
stdenv.mkDerivation {
|
|
pname = "bullet";
|
|
version = "2019-03-27";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "olegklimov";
|
|
repo = "bullet3";
|
|
# roboschool needs the HEAD of a specific branch of this fork, see
|
|
# https://github.com/openai/roboschool/issues/126#issuecomment-421643980
|
|
# https://github.com/openai/roboschool/pull/62
|
|
# https://github.com/openai/roboschool/issues/124
|
|
rev = "3687507ddc04a15de2c5db1e349ada3f2b34b3d6";
|
|
sha256 = "1wd7vj9136dl7lfb8ll0rc2fdl723y3ls9ipp7657yfl2xrqhvkb";
|
|
};
|
|
|
|
nativeBuildInputs = [ cmake ];
|
|
buildInputs = lib.optionals stdenv.hostPlatform.isLinux [ libGLU libGL libglut ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ Cocoa OpenGL ];
|
|
|
|
patches = [ ./gwen-narrowing.patch ];
|
|
|
|
postPatch = lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
sed -i 's/FIND_PACKAGE(OpenGL)//' CMakeLists.txt
|
|
sed -i 's/FIND_LIBRARY(COCOA_LIBRARY Cocoa)//' CMakeLists.txt
|
|
'';
|
|
|
|
cmakeFlags = [
|
|
"-DBUILD_SHARED_LIBS=ON"
|
|
"-DBUILD_CPU_DEMOS=OFF"
|
|
"-DINSTALL_EXTRA_LIBS=ON"
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
"-DOPENGL_FOUND=true"
|
|
"-DOPENGL_LIBRARIES=${OpenGL}/Library/Frameworks/OpenGL.framework"
|
|
"-DOPENGL_INCLUDE_DIR=${OpenGL}/Library/Frameworks/OpenGL.framework"
|
|
"-DOPENGL_gl_LIBRARY=${OpenGL}/Library/Frameworks/OpenGL.framework"
|
|
"-DCOCOA_LIBRARY=${Cocoa}/Library/Frameworks/Cocoa.framework"
|
|
"-DBUILD_BULLET2_DEMOS=OFF"
|
|
"-DBUILD_UNIT_TESTS=OFF"
|
|
];
|
|
|
|
meta = with lib; {
|
|
description = "Professional free 3D Game Multiphysics Library";
|
|
longDescription = ''
|
|
Bullet 3D Game Multiphysics Library provides state of the art collision
|
|
detection, soft body and rigid body dynamics.
|
|
'';
|
|
homepage = "http://bulletphysics.org";
|
|
license = licenses.zlib;
|
|
platforms = platforms.unix;
|
|
# /tmp/nix-build-bullet-2019-03-27.drv-0/source/src/Bullet3Common/b3Vector3.h:297:7: error: argument value 10880 is outside the valid range [0, 255] [-Wargument-outside-range]
|
|
# y = b3_splat_ps(y, 0x80);
|
|
broken = (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isx86_64);
|
|
};
|
|
}
|