mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-01-09 14:33:22 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
51 lines
1.1 KiB
Nix
51 lines
1.1 KiB
Nix
{ lib, stdenv, fetchFromGitHub, cmake, zlib, Cocoa }:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "atomicparsley";
|
|
version = "20240608.083822.1ed9031";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "wez";
|
|
repo = pname;
|
|
rev = version;
|
|
sha256 = "sha256-VhrOMpGNMkNNYjcfCqlHI8gdApWr1ThtcxDwQ6gyV/g=";
|
|
};
|
|
|
|
nativeBuildInputs = [ cmake ];
|
|
|
|
buildInputs = [ zlib ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ Cocoa ];
|
|
|
|
installPhase = ''
|
|
runHook preInstall
|
|
install -D AtomicParsley $out/bin/AtomicParsley
|
|
runHook postInstall
|
|
'';
|
|
|
|
doCheck = true;
|
|
|
|
postPatch = ''
|
|
patchShebangs tests/test.sh
|
|
'';
|
|
|
|
# copying files so that we dont need to patch the test.sh
|
|
checkPhase = ''
|
|
(
|
|
cp AtomicParsley ../tests
|
|
cd ../tests
|
|
mkdir tests
|
|
mv *.mp4 tests
|
|
./test.sh
|
|
)
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "CLI program for reading, parsing and setting metadata into MPEG-4 files";
|
|
homepage = "https://github.com/wez/atomicparsley";
|
|
license = licenses.gpl2Plus;
|
|
platforms = platforms.unix;
|
|
maintainers = with maintainers; [ pjones ];
|
|
mainProgram = "AtomicParsley";
|
|
};
|
|
}
|