0c2a7f8159
It is within our scope. The general team consensus seems to be that it is in a similar position to nix-ld: in-tree users should migrate away from it, but out-of-tree users can use it as a workaround, in place of a wrapper. |
||
---|---|---|
.. | ||
codeowners-validator | ||
eval | ||
nixpkgs-vet | ||
request-reviews | ||
default.nix | ||
get-merge-commit.sh | ||
nixpkgs-vet.sh | ||
OWNERS | ||
pinned-nixpkgs.json | ||
README.md | ||
supportedSystems.nix | ||
update-pinned-nixpkgs.sh |
CI support files
This directory contains files to support CI, such as GitHub Actions and Ofborg.
This is in contrast with maintainers/scripts
which is for human use instead.
Pinned Nixpkgs
CI may need certain packages from Nixpkgs.
In order to ensure that the needed packages are generally available without building,
pinned-nixpkgs.json
contains a pinned Nixpkgs version tested by Hydra.
Run update-pinned-nixpkgs.sh
to update it.
ci/nixpkgs-vet.sh BASE_BRANCH [REPOSITORY]
Runs the nixpkgs-vet
tool on the HEAD commit, closely matching what CI does. This can't do exactly the same as CI, because CI needs to rely on GitHub's server-side Git history to compute the mergeability of PRs before the check can be started.
In turn, when contributors are running this tool locally, we don't want to have to push commits to test them, and we can also rely on the local Git history to do the mergeability check.
Arguments:
BASE_BRANCH
: The base branch to use, e.g. master or release-24.05REPOSITORY
: The repository from which to fetch the base branch. Defaults to https://github.com/NixOS/nixpkgs.git.
ci/nixpkgs-vet
This directory contains scripts and files used and related to nixpkgs-vet
, which the CI uses to implement pkgs/by-name
checks, along with many other Nixpkgs architecture rules.
See also the CI GitHub Action.
ci/nixpkgs-vet/update-pinned-tool.sh
Updates the pinned nixpkgs-vet
tool in ci/nixpkgs-vet/pinned-version.txt
to the latest release.
Each release contains a pre-built x86_64-linux
version of the tool which is used by CI.
This script currently needs to be called manually when the CI tooling needs to be updated.
Why not just build the tooling right from the PRs Nixpkgs version?
- Because it allows CI to check all PRs, even if they would break the CI tooling.
- Because it makes the CI check very fast, since no Nix builds need to be done, even for mass rebuilds.
- Because it improves security, since we don't have to build potentially untrusted code from PRs. The tool only needs a very minimal Nix evaluation at runtime, which can work with readonly-mode and restrict-eval.
get-merge-commit.sh GITHUB_REPO PR_NUMBER
Check whether a PR is mergeable and return the test merge commit as computed by GitHub.
Arguments:
GITHUB_REPO
: The repository of the PR, e.g.NixOS/nixpkgs
PR_NUMBER
: The PR number, e.g.1234
Exit codes:
- 0: The PR can be merged, the test merge commit hash is returned on stdout
- 1: The PR cannot be merged because it's not open anymore
- 2: The PR cannot be merged because it has a merge conflict
- 3: The merge commit isn't being computed, GitHub is likely having internal issues, unknown if the PR is mergeable
Usage
This script can be used in GitHub Actions workflows as follows:
on: pull_request_target
# We need a token to query the API, but it doesn't need any special permissions
permissions: {}
jobs:
build:
name: Build
runs-on: ubuntu-latest
steps:
# Important: Because of `pull_request_target`, this doesn't check out the PR,
# but rather the base branch of the PR, which is needed so we don't run untrusted code
- uses: actions/checkout@<VERSION>
with:
path: base
sparse-checkout: ci
- name: Resolving the merge commit
env:
GH_TOKEN: ${{ github.token }}
run: |
if mergedSha=$(base/ci/get-merge-commit.sh ${{ github.repository }} ${{ github.event.number }}); then
echo "Checking the merge commit $mergedSha"
echo "mergedSha=$mergedSha" >> "$GITHUB_ENV"
else
# Skipping so that no notifications are sent
echo "Skipping the rest..."
fi
rm -rf base
- uses: actions/checkout@<VERSION>
# Add this to _all_ subsequent steps to skip them
if: env.mergedSha
with:
ref: ${{ env.mergedSha }}
- ...