nixpkgs/pkgs/development/python-modules/websockets/default.nix
Sergei Trofimovich 775e3c8e2b python3Packages.websockets: disable time-sentitive test
Without the change python3Packages.websockets fails tests on
machines under load:

    python3.9-websockets> ERROR: test_keepalive_ping_with_no_ping_timeout (tests.legacy.test_protocol.ServerTests)
    python3.9-websockets> Traceback (most recent call last):
    python3.9-websockets>   File "/build/source/tests/legacy/test_protocol.py", line 1270, in test_keepalive_ping_with_no_ping_timeout
    python3.9-websockets>     ping_1_again, ping_2 = tuple(self.protocol.pings)
    python3.9-websockets> ValueError: too many values to unpack (expected 2)

The change disables the test.
2022-02-07 14:12:37 -08:00

64 lines
1.7 KiB
Nix

{ lib
, stdenv
, buildPythonPackage
, fetchFromGitHub
, python
, pythonOlder
}:
buildPythonPackage rec {
pname = "websockets";
version = "10.1";
format = "setuptools";
disabled = pythonOlder "3.7";
src = fetchFromGitHub {
owner = "aaugustin";
repo = pname;
rev = version;
sha256 = "sha256-FFaoqxa+TmKJ+P6T7HrwodjbVCir+2qJSfZsoj6deJU=";
};
# Tests fail on Darwin with `OSError: AF_UNIX path too long`
doCheck = !stdenv.isDarwin;
patchPhase = ''
# Disable all tests that need to terminate within a predetermined amount of
# time. This is nondeterministic.
sed -i 's/with self.assertCompletesWithin.*:/if True:/' \
tests/legacy/test_protocol.py
# Disables tests relying on tight timeouts to avoid failures like:
# File "/build/source/tests/legacy/test_protocol.py", line 1270, in test_keepalive_ping_with_no_ping_timeout
# ping_1_again, ping_2 = tuple(self.protocol.pings)
# ValueError: too many values to unpack (expected 2)
for t in \
test_keepalive_ping_stops_when_connection_closing \
test_keepalive_ping_does_not_crash_when_connection_lost \
test_keepalive_ping \
test_keepalive_ping_not_acknowledged_closes_connection \
test_keepalive_ping_with_no_ping_timeout \
; do
sed -i "s/def $t(/def skip_$t(/" tests/legacy/test_protocol.py
done
'';
checkPhase = ''
runHook preCheck
${python.interpreter} -m unittest discover
runHook postCheck
'';
pythonImportsCheck = [
"websockets"
];
meta = with lib; {
description = "WebSocket implementation in Python";
homepage = "https://websockets.readthedocs.io/";
license = licenses.bsd3;
maintainers = with maintainers; [ fab ];
};
}